From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/7] ARM: davinci, intc: Add OF support for TI interrupt controller
Date: Wed, 22 Feb 2012 16:23:00 +0400 [thread overview]
Message-ID: <4F44DE24.30606@mvista.com> (raw)
In-Reply-To: <1329893410-24413-2-git-send-email-hs@denx.de>
Hello.
On 22-02-2012 10:50, Heiko Schocher wrote:
> Add a function to initialize the davinci interrupt controller (INTC)
> using a device tree node.
cp_intc is not DaVinci interrupt controller, it's only used in OMAP-L1x
SoCs. cp_intc stands for Common Platform Interrupt Controller. I don't see
where you are initializiing the DaVinci interrupt controller itself. You
should understand that there are two disctinct types of interrupt controllers
used in the SoCs supported by arch/arm/mach-davinci/.
> Signed-off-by: Heiko Schocher<hs@denx.de>
> Cc: davinci-linux-open-source at linux.davincidsp.com
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: devicetree-discuss at lists.ozlabs.org
> Cc: Grant Likely<grant.likely@secretlab.ca>
> Cc: Sekhar Nori<nsekhar@ti.com>
> Cc: Wolfgang Denk<wd@denx.de>
[...]
> diff --git a/Documentation/devicetree/bindings/arm/davinci/intc.txt b/Documentation/devicetree/bindings/arm/davinci/intc.txt
> new file mode 100644
> index 0000000..dac2f69
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/davinci/intc.txt
> @@ -0,0 +1,26 @@
> +* TI Davinci Interrupt Controller
> +
> +davinci are using a TI interrupt controller that can support several
> +configurable number of interrupts.
> +
> +Main node required properties:
> +
> +- compatible : should be:
> + "ti,davinci-intc"
The right "compatible" prop would be "ti,cp_intc" in this case.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
To: Heiko Schocher <hs-ynQEQJNshbs@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
Wolfgang Denk <wd-ynQEQJNshbs@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 1/7] ARM: davinci, intc: Add OF support for TI interrupt controller
Date: Wed, 22 Feb 2012 16:23:00 +0400 [thread overview]
Message-ID: <4F44DE24.30606@mvista.com> (raw)
In-Reply-To: <1329893410-24413-2-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
Hello.
On 22-02-2012 10:50, Heiko Schocher wrote:
> Add a function to initialize the davinci interrupt controller (INTC)
> using a device tree node.
cp_intc is not DaVinci interrupt controller, it's only used in OMAP-L1x
SoCs. cp_intc stands for Common Platform Interrupt Controller. I don't see
where you are initializiing the DaVinci interrupt controller itself. You
should understand that there are two disctinct types of interrupt controllers
used in the SoCs supported by arch/arm/mach-davinci/.
> Signed-off-by: Heiko Schocher<hs-ynQEQJNshbs@public.gmane.org>
> Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org
> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> Cc: Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Cc: Sekhar Nori<nsekhar-l0cyMroinI0@public.gmane.org>
> Cc: Wolfgang Denk<wd-ynQEQJNshbs@public.gmane.org>
[...]
> diff --git a/Documentation/devicetree/bindings/arm/davinci/intc.txt b/Documentation/devicetree/bindings/arm/davinci/intc.txt
> new file mode 100644
> index 0000000..dac2f69
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/davinci/intc.txt
> @@ -0,0 +1,26 @@
> +* TI Davinci Interrupt Controller
> +
> +davinci are using a TI interrupt controller that can support several
> +configurable number of interrupts.
> +
> +Main node required properties:
> +
> +- compatible : should be:
> + "ti,davinci-intc"
The right "compatible" prop would be "ti,cp_intc" in this case.
WBR, Sergei
next prev parent reply other threads:[~2012-02-22 12:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 6:50 [PATCH v2 0/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
2012-02-22 6:50 ` Heiko Schocher
2012-02-22 6:50 ` Heiko Schocher
2012-02-22 6:50 ` [PATCH v2 1/7] ARM: davinci, intc: Add OF support for TI interrupt controller Heiko Schocher
2012-02-22 6:50 ` Heiko Schocher
2012-02-22 12:23 ` Sergei Shtylyov [this message]
2012-02-22 12:23 ` Sergei Shtylyov
2012-02-29 6:42 ` Heiko Schocher
2012-02-29 6:42 ` Heiko Schocher
2012-02-29 10:22 ` Sergei Shtylyov
2012-02-29 10:22 ` Sergei Shtylyov
2012-02-22 6:50 ` [PATCH v2 2/7] ARM: davinci: configure davinci aemif chipselects through OF Heiko Schocher
2012-02-22 6:50 ` Heiko Schocher
2012-02-22 6:50 ` [PATCH v2 3/7] ARM: davinci: mux: add OF support Heiko Schocher
2012-02-22 6:50 ` Heiko Schocher
2012-02-22 6:50 ` [PATCH v2 4/7] ARM: davinci: net: davinci_emac: " Heiko Schocher
2012-02-22 6:50 ` Heiko Schocher
[not found] ` <1329893410-24413-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2012-02-22 6:50 ` [PATCH v2 5/7] ARM: davinci: i2c: " Heiko Schocher
2012-02-22 6:50 ` Heiko Schocher
2012-02-22 6:50 ` [PATCH v2 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
2012-02-22 6:50 ` Heiko Schocher
2012-02-22 6:50 ` Heiko Schocher
2012-02-22 6:50 ` [PATCH v2 6/7] ARM: mtd: nand: davinci: add OF support for davinci nand controller Heiko Schocher
2012-02-22 6:50 ` Heiko Schocher
2012-02-22 6:50 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F44DE24.30606@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.