From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org,
"Corey Bryant" <coreyb@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, 陳韋任 <chenwj@iis.sinica.edu.tw>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Add dependency to fix linux-user-only build
Date: Wed, 22 Feb 2012 12:46:32 -0600 [thread overview]
Message-ID: <4F453808.7020401@codemonkey.ws> (raw)
In-Reply-To: <1329835480-22192-1-git-send-email-peter.maydell@linaro.org>
On 02/21/2012 08:44 AM, Peter Maydell wrote:
> Make qemu-bridge-helper explicitly depend on $(GENERATED_HEADERS)
> so that it doesn't fail to build when we configured for linux-user
> targets only. (Build breakage introduced in commit 7b93fad.)
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> I suspect we could handle generated headers better in our makefile
> than having to scatter $(GENERATED_HEADERS) dependencies into almost
> everything (eg "%.o: $(GENERATED_HEADERS)" ??) but this is the minimal
> fix for the build breakage which we should apply for now I think.
>
> Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index e66e885..c67493e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -159,6 +159,7 @@ qemu-nbd$(EXESUF): qemu-nbd.o $(tools-obj-y) $(block-obj-y)
> qemu-io$(EXESUF): qemu-io.o cmd.o $(tools-obj-y) $(block-obj-y)
>
> qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o
> +qemu-bridge-helper.o: $(GENERATED_HEADERS)
>
> fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/virtio-9p-marshal.o oslib-posix.o $(trace-obj-y)
> fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org,
"Corey Bryant" <coreyb@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, 陳韋任 <chenwj@iis.sinica.edu.tw>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Add dependency to fix linux-user-only build
Date: Wed, 22 Feb 2012 12:46:32 -0600 [thread overview]
Message-ID: <4F453808.7020401@codemonkey.ws> (raw)
In-Reply-To: <1329835480-22192-1-git-send-email-peter.maydell@linaro.org>
On 02/21/2012 08:44 AM, Peter Maydell wrote:
> Make qemu-bridge-helper explicitly depend on $(GENERATED_HEADERS)
> so that it doesn't fail to build when we configured for linux-user
> targets only. (Build breakage introduced in commit 7b93fad.)
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> I suspect we could handle generated headers better in our makefile
> than having to scatter $(GENERATED_HEADERS) dependencies into almost
> everything (eg "%.o: $(GENERATED_HEADERS)" ??) but this is the minimal
> fix for the build breakage which we should apply for now I think.
>
> Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index e66e885..c67493e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -159,6 +159,7 @@ qemu-nbd$(EXESUF): qemu-nbd.o $(tools-obj-y) $(block-obj-y)
> qemu-io$(EXESUF): qemu-io.o cmd.o $(tools-obj-y) $(block-obj-y)
>
> qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o
> +qemu-bridge-helper.o: $(GENERATED_HEADERS)
>
> fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/virtio-9p-marshal.o oslib-posix.o $(trace-obj-y)
> fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap
next prev parent reply other threads:[~2012-02-22 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 14:44 [Qemu-trivial] [PATCH] Makefile: Add dependency to fix linux-user-only build Peter Maydell
2012-02-21 14:44 ` [Qemu-devel] " Peter Maydell
2012-02-22 18:46 ` Anthony Liguori [this message]
2012-02-22 18:46 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F453808.7020401@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=chenwj@iis.sinica.edu.tw \
--cc=coreyb@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.