* grub-mount (ubuntu) hangs with hfs+ partition @ 2012-02-23 20:46 Kees Bakker 2012-02-24 10:34 ` Vladimir 'φ-coder/phcoder' Serbinenko 0 siblings, 1 reply; 6+ messages in thread From: Kees Bakker @ 2012-02-23 20:46 UTC (permalink / raw) To: The development of GNU GRUB Hi, In Ubuntu (and Debian I guess) there is a grub-mount command. It's added to grub with branch_fuse.patch, and in that file it mentions http://lists.gnu.org/archive/html/grub-devel/2011-01/msg00056.html I have a MacPro system with Ubuntu installed and some HFS+ partitions. Everytime I do a kernel update (and update-grub) it hangs when a grub-mount command is used on one of the HFS+ partitions. The grub-mount command does not hang on all my HFS+ partitions. But the fact that it hangs on one of them makes it very annoying. I've tried to debug this problem, but I am not making any progress. The program hangs in a while(1) loop at line 657 in grub-core/fs/hfsplus.c BTW. I've also tried to contact Macro Gerards (the contributor of the HFS+ code), but I didn't get a reply from him. -- Kees ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: grub-mount (ubuntu) hangs with hfs+ partition 2012-02-23 20:46 grub-mount (ubuntu) hangs with hfs+ partition Kees Bakker @ 2012-02-24 10:34 ` Vladimir 'φ-coder/phcoder' Serbinenko 2012-02-24 19:25 ` Kees Bakker 2012-02-24 20:28 ` Kees Bakker 0 siblings, 2 replies; 6+ messages in thread From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2012-02-24 10:34 UTC (permalink / raw) To: The development of GNU GRUB On 23.02.2012 21:46, Kees Bakker wrote: > Hi, > > In Ubuntu (and Debian I guess) there is a grub-mount command. > It's added to grub with branch_fuse.patch, and in that file it mentions > http://lists.gnu.org/archive/html/grub-devel/2011-01/msg00056.html > > I have a MacPro system with Ubuntu installed and some HFS+ > partitions. Everytime I do a kernel update (and update-grub) > it hangs when a grub-mount command is used on one of the HFS+ > partitions. > > The grub-mount command does not hang on all my HFS+ partitions. > But the fact that it hangs on one of them makes it very annoying. > > I've tried to debug this problem, but I am not making any progress. > The program hangs in a while(1) loop at line 657 in > grub-core/fs/hfsplus.c > there is no loop at this location in the latest trunk. Could you use this please? Also what is the value of currnode on every loop iteration? > BTW. I've also tried to contact Macro Gerards (the contributor of the > HFS+ > code), but I didn't get a reply from him. -- Regards Vladimir 'φ-coder/phcoder' Serbinenko ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: grub-mount (ubuntu) hangs with hfs+ partition 2012-02-24 10:34 ` Vladimir 'φ-coder/phcoder' Serbinenko @ 2012-02-24 19:25 ` Kees Bakker 2012-02-24 20:28 ` Kees Bakker 1 sibling, 0 replies; 6+ messages in thread From: Kees Bakker @ 2012-02-24 19:25 UTC (permalink / raw) To: The development of GNU GRUB On 24-02-12 11:34, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 23.02.2012 21:46, Kees Bakker wrote: >> I've tried to debug this problem, but I am not making any progress. >> The program hangs in a while(1) loop at line 657 in >> grub-core/fs/hfsplus.c >> > there is no loop at this location in the latest trunk. Could you use > this please? OK. I'll take a look (but please be patient, because I am moving to a new location, and I won't have internet access at least until March 19) > Also what is the value of currnode on every loop iteration? I've added several print statement and limited the loop to 10 iterations. currnode has these values. So, the first time it is 0x8d7d and all next iterations it is 0x4bdff. reading node currnode=0000000000008d7d match, currkey=0x9e531e, pointer=0x9e532c, keylen=0c00, currnode=000000000004bdff reading node currnode=000000000004bdff match, currkey=0x9e531e, pointer=0x9e532c, keylen=0c00, currnode=000000000004bdff reading node currnode=000000000004bdff match, currkey=0x9e531e, pointer=0x9e532c, keylen=0c00, currnode=000000000004bdff reading node currnode=000000000004bdff match, currkey=0x9e531e, pointer=0x9e532c, keylen=0c00, currnode=000000000004bdff reading node currnode=000000000004bdff match, currkey=0x9e531e, pointer=0x9e532c, keylen=0c00, currnode=000000000004bdff reading node currnode=000000000004bdff match, currkey=0x9e531e, pointer=0x9e532c, keylen=0c00, currnode=000000000004bdff reading node currnode=000000000004bdff match, currkey=0x9e531e, pointer=0x9e532c, keylen=0c00, currnode=000000000004bdff reading node currnode=000000000004bdff match, currkey=0x9e531e, pointer=0x9e532c, keylen=0c00, currnode=000000000004bdff reading node currnode=000000000004bdff match, currkey=0x9e531e, pointer=0x9e532c, keylen=0c00, currnode=000000000004bdff -- Kees ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: grub-mount (ubuntu) hangs with hfs+ partition 2012-02-24 10:34 ` Vladimir 'φ-coder/phcoder' Serbinenko 2012-02-24 19:25 ` Kees Bakker @ 2012-02-24 20:28 ` Kees Bakker 2012-02-24 21:30 ` Vladimir 'φ-coder/phcoder' Serbinenko 1 sibling, 1 reply; 6+ messages in thread From: Kees Bakker @ 2012-02-24 20:28 UTC (permalink / raw) To: The development of GNU GRUB On 24-02-12 11:34, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 23.02.2012 21:46, Kees Bakker wrote: >> >> I've tried to debug this problem, but I am not making any progress. >> The program hangs in a while(1) loop at line 657 in >> grub-core/fs/hfsplus.c >> > there is no loop at this location in the latest trunk. Could you use > this please? Correct, the while (1) is at line 665. Here is the good news: the hang does not happen with the trunk version anymore. Great work Vladimir. You seem to have done quite a bit of work there, according to the ChangeLog. Thanks a lot. Now, if only Ubuntu would like to take a more recent upstream version ... -- Kees ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: grub-mount (ubuntu) hangs with hfs+ partition 2012-02-24 20:28 ` Kees Bakker @ 2012-02-24 21:30 ` Vladimir 'φ-coder/phcoder' Serbinenko 2012-02-25 16:44 ` Kees Bakker 0 siblings, 1 reply; 6+ messages in thread From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2012-02-24 21:30 UTC (permalink / raw) To: The development of GNU GRUB On 24.02.2012 21:28, Kees Bakker wrote: > On 24-02-12 11:34, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 23.02.2012 21:46, Kees Bakker wrote: >>> >>> I've tried to debug this problem, but I am not making any progress. >>> The program hangs in a while(1) loop at line 657 in >>> grub-core/fs/hfsplus.c >>> >> there is no loop at this location in the latest trunk. Could you use >> this please? > > Correct, the while (1) is at line 665. > > Here is the good news: the hang does not happen with the trunk version > anymore. But there is still a minor bug that you can make this loop hang with a broken FS (btree loop). I've added standard Brent's check to avoid this. > > Great work Vladimir. You seem to have done quite a bit of work there, > according to the ChangeLog. Thanks a lot. > > Now, if only Ubuntu would like to take a more recent upstream version ... -- Regards Vladimir 'φ-coder/phcoder' Serbinenko ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: grub-mount (ubuntu) hangs with hfs+ partition 2012-02-24 21:30 ` Vladimir 'φ-coder/phcoder' Serbinenko @ 2012-02-25 16:44 ` Kees Bakker 0 siblings, 0 replies; 6+ messages in thread From: Kees Bakker @ 2012-02-25 16:44 UTC (permalink / raw) To: The development of GNU GRUB On 24-02-12 22:30, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 24.02.2012 21:28, Kees Bakker wrote: >> Here is the good news: the hang does not happen with the trunk version >> anymore. > But there is still a minor bug that you can make this loop hang with a > broken FS (btree loop). I've added standard Brent's check to avoid this. OK. Great. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-25 16:44 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-02-23 20:46 grub-mount (ubuntu) hangs with hfs+ partition Kees Bakker 2012-02-24 10:34 ` Vladimir 'φ-coder/phcoder' Serbinenko 2012-02-24 19:25 ` Kees Bakker 2012-02-24 20:28 ` Kees Bakker 2012-02-24 21:30 ` Vladimir 'φ-coder/phcoder' Serbinenko 2012-02-25 16:44 ` Kees Bakker
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.