All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 4/7] ARM: OMAP2+: Fix zoom LCD backlight if TWL_CORE is not selected
Date: Fri, 24 Feb 2012 15:53:58 +0400	[thread overview]
Message-ID: <4F477A56.9000005@ru.mvista.com> (raw)
In-Reply-To: <20120224005411.16794.720.stgit@kaulin.local>

Hello.

On 24-02-2012 4:54, Tony Lindgren wrote:

> Otherwise we get:

> arch/arm/mach-omap2/board-zoom-display.c:64: undefined reference to `twl_i2c_read_u8'
> arch/arm/mach-omap2/board-zoom-display.c:65: undefined reference to `twl_i2c_read_u8'
> arch/arm/mach-omap2/board-zoom-display.c:84: undefined reference to `twl_i2c_write_u8'
> arch/arm/mach-omap2/board-zoom-display.c:86: undefined reference to `twl_i2c_write_u8'
> arch/arm/mach-omap2/board-zoom-display.c:91: undefined reference to `twl_i2c_write_u8'
> arch/arm/mach-omap2/board-zoom-display.c:92: undefined reference to `twl_i2c_write_u8'
> arch/arm/mach-omap2/board-zoom-display.c:72: undefined reference to `twl_i2c_write_u8'

> Signed-off-by: Tony Lindgren<tony@atomide.com>
[...]

> diff --git a/arch/arm/mach-omap2/board-zoom-display.c b/arch/arm/mach-omap2/board-zoom-display.c
> index d4683ba..7f75fcd 100644
> --- a/arch/arm/mach-omap2/board-zoom-display.c
> +++ b/arch/arm/mach-omap2/board-zoom-display.c
> @@ -53,8 +53,11 @@ static void zoom_panel_disable_lcd(struct omap_dss_device *dssdev)
>   #define TWL_LED_PWMON	0x0
>   #define TWL_LED_PWMOFF	0x1
>
> +
>   static int zoom_set_bl_intensity(struct omap_dss_device *dssdev, int level)
>   {
> +

    Empty lines not needed.

> +#ifdef CONFIG_TWL4030_CORE
>   	unsigned char c;
>   	u8 mux_pwm, enb_pwm;
>

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@ru.mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] ARM: OMAP2+: Fix zoom LCD backlight if TWL_CORE is not selected
Date: Fri, 24 Feb 2012 15:53:58 +0400	[thread overview]
Message-ID: <4F477A56.9000005@ru.mvista.com> (raw)
In-Reply-To: <20120224005411.16794.720.stgit@kaulin.local>

Hello.

On 24-02-2012 4:54, Tony Lindgren wrote:

> Otherwise we get:

> arch/arm/mach-omap2/board-zoom-display.c:64: undefined reference to `twl_i2c_read_u8'
> arch/arm/mach-omap2/board-zoom-display.c:65: undefined reference to `twl_i2c_read_u8'
> arch/arm/mach-omap2/board-zoom-display.c:84: undefined reference to `twl_i2c_write_u8'
> arch/arm/mach-omap2/board-zoom-display.c:86: undefined reference to `twl_i2c_write_u8'
> arch/arm/mach-omap2/board-zoom-display.c:91: undefined reference to `twl_i2c_write_u8'
> arch/arm/mach-omap2/board-zoom-display.c:92: undefined reference to `twl_i2c_write_u8'
> arch/arm/mach-omap2/board-zoom-display.c:72: undefined reference to `twl_i2c_write_u8'

> Signed-off-by: Tony Lindgren<tony@atomide.com>
[...]

> diff --git a/arch/arm/mach-omap2/board-zoom-display.c b/arch/arm/mach-omap2/board-zoom-display.c
> index d4683ba..7f75fcd 100644
> --- a/arch/arm/mach-omap2/board-zoom-display.c
> +++ b/arch/arm/mach-omap2/board-zoom-display.c
> @@ -53,8 +53,11 @@ static void zoom_panel_disable_lcd(struct omap_dss_device *dssdev)
>   #define TWL_LED_PWMON	0x0
>   #define TWL_LED_PWMOFF	0x1
>
> +
>   static int zoom_set_bl_intensity(struct omap_dss_device *dssdev, int level)
>   {
> +

    Empty lines not needed.

> +#ifdef CONFIG_TWL4030_CORE
>   	unsigned char c;
>   	u8 mux_pwm, enb_pwm;
>

WBR, Sergei

  reply	other threads:[~2012-02-24 11:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-24  0:54 [PATCH 0/7] More omap2+ randconfig fixes Tony Lindgren
2012-02-24  0:54 ` Tony Lindgren
2012-02-24  0:54 ` [PATCH 1/7] ARM: OMAP2+: Fix Kconfig dependencies for USB_ARCH_HAS_EHCI Tony Lindgren
2012-02-24  0:54   ` Tony Lindgren
2012-02-24  0:54 ` [PATCH 2/7] ARM: OMAP2+: Fix OMAP_HDQ_BASE build error Tony Lindgren
2012-02-24  0:54   ` Tony Lindgren
2012-02-24  0:54 ` [PATCH 3/7] ARM: OMAP2+: Fix board_mux section type conflict when OMAP_MUX is not set Tony Lindgren
2012-02-24  0:54   ` Tony Lindgren
2012-02-24  0:54 ` [PATCH 4/7] ARM: OMAP2+: Fix zoom LCD backlight if TWL_CORE is not selected Tony Lindgren
2012-02-24  0:54   ` Tony Lindgren
2012-02-24 11:53   ` Sergei Shtylyov [this message]
2012-02-24 11:53     ` Sergei Shtylyov
2012-02-24 16:25     ` Tony Lindgren
2012-02-24 16:25       ` Tony Lindgren
2012-02-24  0:54 ` [PATCH 5/7] ARM: OMAP2+: Fix devexit for smartreflex when CONFIG_HOTPLUG is not set Tony Lindgren
2012-02-24  0:54   ` Tony Lindgren
2012-02-24  0:54 ` [PATCH 6/7] ARM: OMAP: Fix devexit for dma " Tony Lindgren
2012-02-24  0:54   ` Tony Lindgren
2012-02-24  0:54 ` [PATCH 7/7] ARM: OMAP2+: Fix multiple randconfig errors with SOC_OMAP and SOC_OMAP_NOOP Tony Lindgren
2012-02-24  0:54   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F477A56.9000005@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.