Re: [Qemu-devel] [PATCH 5/5] boards: move all machine type functions to boards.c

["Andreas Färber" <afaerber@suse.de>]

Am 24.02.2012 15:13, schrieb Luiz Capitulino:
> The license text is the same as used in vl.c. Also note that it's
> necessary to make machine_parse() public.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  Makefile.target |    3 +-
>  hw/boards.c     |   86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/boards.h     |    1 +
>  vl.c            |   65 -----------------------------------------
>  4 files changed, 89 insertions(+), 66 deletions(-)
>  create mode 100644 hw/boards.c

In anticipation of a "board" class derived from "container" I would
rather have the file name match the class name, i.e. board.c.
Unfortunately boards.h is used in quite a lot of places already, but
when we QOM'ify it we might want to move it to include/qemu so all users
would need to be touched anyway.

> diff --git a/Makefile.target b/Makefile.target
> index d5eb70d..dc76eba 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -195,7 +195,8 @@ endif #CONFIG_BSD_USER
>  # System emulator target
>  ifdef CONFIG_SOFTMMU
>  
> -obj-y = arch_init.o cpus.o monitor.o machine.o gdbstub.o balloon.o ioport.o
> +obj-y = arch_init.o cpus.o monitor.o machine.o gdbstub.o balloon.o ioport.o \
> +		boards.o

Please use obj-y += ... instead of the line break.

Otherwise looks okay.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg