Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions

[Anthony Liguori <aliguori@us.ibm.com>]

On 02/24/2012 10:12 AM, Peter Maydell wrote:
> On 24 February 2012 14:13, Luiz Capitulino<lcapitulino@redhat.com>  wrote:
>> Perform the following renames:
>>
>>   o qemu_register_machine() ->  machine_register()
>>   o find_machine() ->  machine_find()
>>   o find_default_machine()  ->  machine_find_default()
>>
>> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
>>   52 files changed, 96 insertions(+), 96 deletions(-)
>
> I said I was going to nack the next change-whole-tree
> change, so here it is: nack.
>
> At some point we're going to have to actually start
> converting boards to be QOM objects themselves, but
> (a) I hope we can make that incremental so we can do
> things in batches the way we did with MemoryRegion
> conversions and (b) until then the qemu_register_machine
> rename just looks like unnecessary churn to me.

I think I agree with you here.  I don't see the value compared to the churn here 
given that we're going to have to touch all of this again anyway soon.

Regards,

Anthony Liguori

>
> -- PMM
>
>