All of lore.kernel.org
 help / color / mirror / Atom feed
* Search for images within sub-directories of the theme's directory.
@ 2012-02-24  2:29 Towheed Mohammed
  2012-02-24 20:53 ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 1 reply; 3+ messages in thread
From: Towheed Mohammed @ 2012-02-24  2:29 UTC (permalink / raw)
  To: grub-devel@gnu.org

The following components:
1. image
2. progress_bar, and

3. circular_progress

have the 'theme_dir' property.  A theme designer can use this property to place image files within sub-directories of the theme's directory.  However, 00_header searches for images only in the theme's directory:


        if [ x"`echo "$themedir"/*.jpg`" != x"$themedir/*.jpg" ] || [ x"`echo "$themedir"/*.jpeg`" != x"$themedir/*.jpeg" ]; then
                cat << EOF
        insmod jpeg
        EOF
         fi
         if [ x"`echo "$themedir"/*.png`" != x"$themedir/*.png" ]; then
                cat << EOF
        insmod png
        EOF
         fi
         if [ x"`echo "$themedir"/*.tga`" != x"$themedir/*.tga" ]; then
                cat << EOF
        insmod tga
        EOF
         fi

Please modify 00_header so that it will search for image files within sub-directories of the theme's directory.


Thank you.

Towheed Mohammed



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Search for images within sub-directories of the theme's directory.
  2012-02-24  2:29 Search for images within sub-directories of the theme's directory Towheed Mohammed
@ 2012-02-24 20:53 ` Vladimir 'φ-coder/phcoder' Serbinenko
  2012-02-24 23:12   ` Towheed Mohammed
  0 siblings, 1 reply; 3+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2012-02-24 20:53 UTC (permalink / raw)
  To: The development of GNU GRUB

On 24.02.2012 03:29, Towheed Mohammed wrote:
> The following components:
> 1. image
> 2. progress_bar, and
>
> 3. circular_progress
>
> have the 'theme_dir' property.  A theme designer can use this property to place image files within sub-directories of the theme's directory.  However, 00_header searches for images only in the theme's directory:
theme_dir isn't intended to be set in theme file. It's internal.


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Search for images within sub-directories of the theme's directory.
  2012-02-24 20:53 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2012-02-24 23:12   ` Towheed Mohammed
  0 siblings, 0 replies; 3+ messages in thread
From: Towheed Mohammed @ 2012-02-24 23:12 UTC (permalink / raw)
  To: The development of GNU GRUB

Then it should not be searched for in the theme file as a component's property:

From gui_image.c
210  if (grub_strcmp (name, "theme_dir") == 0)
211 		    {

Other components uses theme_dir but do not look for it as one of their properties.

For others like myself, who peruses the source files looking for changed components/properties/properties' default values etc , it would not lead us into thinking that properties etc have been changed.

Thanks

Towheed Mohammed

----- Original Message -----
From: Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: 
Sent: Friday, February 24, 2012 4:53 PM
Subject: Re: Search for images within sub-directories of the theme's directory.

On 24.02.2012 03:29, Towheed Mohammed wrote:
> The following components:
> 1. image
> 2. progress_bar, and
>
> 3. circular_progress
>
> have the 'theme_dir' property.  A theme designer can use this property to place image files within sub-directories of the theme's directory.  However, 00_header searches for images only in the theme's directory:
theme_dir isn't intended to be set in theme file. It's internal.


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-02-24 23:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-24  2:29 Search for images within sub-directories of the theme's directory Towheed Mohammed
2012-02-24 20:53 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-24 23:12   ` Towheed Mohammed

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.