From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/2] ppc: Add missing 'static' to spin_rw_ops
Date: Sun, 26 Feb 2012 00:16:33 +0100 [thread overview]
Message-ID: <4F496BD1.5010205@suse.de> (raw)
In-Reply-To: <1330173433-32043-2-git-send-email-sw@weilnetz.de>
Am 25.02.2012 13:37, schrieb Stefan Weil:
> spin_rw_ops is only used in hw/ppce500_spin.c.
>
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Acked-by: Andreas Färber <afaerber@suse.de>
/-F
> ---
> hw/ppce500_spin.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ppce500_spin.c b/hw/ppce500_spin.c
> index 6b8a189..6ed676b 100644
> --- a/hw/ppce500_spin.c
> +++ b/hw/ppce500_spin.c
> @@ -182,7 +182,7 @@ static uint64_t spin_read(void *opaque, target_phys_addr_t addr, unsigned len)
> }
> }
>
> -const MemoryRegionOps spin_rw_ops = {
> +static const MemoryRegionOps spin_rw_ops = {
> .read = spin_read,
> .write = spin_write,
> .endianness = DEVICE_BIG_ENDIAN,
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/2] ppc: Add missing 'static' to spin_rw_ops
Date: Sun, 26 Feb 2012 00:16:33 +0100 [thread overview]
Message-ID: <4F496BD1.5010205@suse.de> (raw)
In-Reply-To: <1330173433-32043-2-git-send-email-sw@weilnetz.de>
Am 25.02.2012 13:37, schrieb Stefan Weil:
> spin_rw_ops is only used in hw/ppce500_spin.c.
>
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Acked-by: Andreas Färber <afaerber@suse.de>
/-F
> ---
> hw/ppce500_spin.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ppce500_spin.c b/hw/ppce500_spin.c
> index 6b8a189..6ed676b 100644
> --- a/hw/ppce500_spin.c
> +++ b/hw/ppce500_spin.c
> @@ -182,7 +182,7 @@ static uint64_t spin_read(void *opaque, target_phys_addr_t addr, unsigned len)
> }
> }
>
> -const MemoryRegionOps spin_rw_ops = {
> +static const MemoryRegionOps spin_rw_ops = {
> .read = spin_read,
> .write = spin_write,
> .endianness = DEVICE_BIG_ENDIAN,
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-02-25 23:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 12:37 [Qemu-trivial] [PATCH 0/2] Trivial MemoryRegionOps patches Stefan Weil
2012-02-25 12:37 ` [Qemu-devel] " Stefan Weil
2012-02-25 12:37 ` [Qemu-trivial] [PATCH 1/2] ppc: Add missing 'static' to spin_rw_ops Stefan Weil
2012-02-25 12:37 ` [Qemu-devel] " Stefan Weil
2012-02-25 23:16 ` Andreas Färber [this message]
2012-02-25 23:16 ` Andreas Färber
2012-02-25 12:37 ` [Qemu-trivial] [PATCH 2/2] sh7750: Remove redundant 'struct' from MemoryRegionOps Stefan Weil
2012-02-25 12:37 ` [Qemu-devel] " Stefan Weil
2012-03-05 13:05 ` [Qemu-trivial] [PATCH 0/2] Trivial MemoryRegionOps patches Stefan Hajnoczi
2012-03-05 13:05 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F496BD1.5010205@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.