All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] libcacard: Spelling and grammar fixes in documentation
Date: Sun, 26 Feb 2012 19:52:15 +0100	[thread overview]
Message-ID: <4F4A7F5F.2020808@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA_82UCPWVukhAWcxGjeRQfkb+_E7OOdx8fh9y-6Ya_OMg@mail.gmail.com>

Am 26.02.2012 19:18, schrieb Peter Maydell:
> On 26 February 2012 13:30, Stefan Weil<sw@weilnetz.de>  wrote:
>> @@ -217,10 +217,10 @@ the card using the following functions:
>>           VCardStatus vcard_add_applet(VCard *card, VCardApplet *applet);
>>
>>    Add an applet onto the list of applets attached to the card. Once an applet
>> -  has been added, it can be selected by it's aid, and then commands will be
>> +  has been added, it can be selected by its aid, and then commands will be
> While you're changing this line, it looks like 'aid' here should be 'AID'
> (it is capitalised elsewhere in the doc except where referring to a function
> parameter name).
>
>>    routed to it VCardProcessAPDU function. This function adopts the applet the
>>    passed int applet.
> The sentence "This function..." clearly needs correcting as it doesn't
> make much sense as it stands, but I'm not sure what it should be changed to.

Nor was I when I read that sentence, that's why I did not fix it :-)

AID looks correct, so I'll send an update of my patch which fixes
that, too.

Thanks,

Stefan Weil



WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] libcacard: Spelling and grammar fixes in documentation
Date: Sun, 26 Feb 2012 19:52:15 +0100	[thread overview]
Message-ID: <4F4A7F5F.2020808@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA_82UCPWVukhAWcxGjeRQfkb+_E7OOdx8fh9y-6Ya_OMg@mail.gmail.com>

Am 26.02.2012 19:18, schrieb Peter Maydell:
> On 26 February 2012 13:30, Stefan Weil<sw@weilnetz.de>  wrote:
>> @@ -217,10 +217,10 @@ the card using the following functions:
>>           VCardStatus vcard_add_applet(VCard *card, VCardApplet *applet);
>>
>>    Add an applet onto the list of applets attached to the card. Once an applet
>> -  has been added, it can be selected by it's aid, and then commands will be
>> +  has been added, it can be selected by its aid, and then commands will be
> While you're changing this line, it looks like 'aid' here should be 'AID'
> (it is capitalised elsewhere in the doc except where referring to a function
> parameter name).
>
>>    routed to it VCardProcessAPDU function. This function adopts the applet the
>>    passed int applet.
> The sentence "This function..." clearly needs correcting as it doesn't
> make much sense as it stands, but I'm not sure what it should be changed to.

Nor was I when I read that sentence, that's why I did not fix it :-)

AID looks correct, so I'll send an update of my patch which fixes
that, too.

Thanks,

Stefan Weil

  reply	other threads:[~2012-02-26 18:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-26 13:30 [Qemu-trivial] [PATCH] libcacard: Spelling and grammar fixes in documentation Stefan Weil
2012-02-26 13:30 ` [Qemu-devel] " Stefan Weil
2012-02-26 13:38 ` [Qemu-trivial] " Alon Levy
2012-02-26 13:38   ` Alon Levy
2012-02-26 18:18 ` [Qemu-trivial] " Peter Maydell
2012-02-26 18:18   ` Peter Maydell
2012-02-26 18:52   ` Stefan Weil [this message]
2012-02-26 18:52     ` Stefan Weil
2012-02-27 21:24   ` [Qemu-trivial] " Alon Levy
2012-02-27 21:24     ` Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4A7F5F.2020808@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.