From: Florian Fainelli <florian@openwrt.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linuxppc-dev@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH] of/mdio: fix fixed link bus name
Date: Mon, 27 Feb 2012 15:46:32 +0100 [thread overview]
Message-ID: <4F4B9748.8020509@openwrt.org> (raw)
In-Reply-To: <8ebe6a3f11343c392a7353581d5f648980206e8e.1330346765.git.baruch@tkos.co.il>
Le 02/27/12 13:48, Baruch Siach a écrit :
> Since 9e6c643b (phy/fixed: use an unique MDIO bus name) the name of the fixed
> PHY bus is "fixed-0". Teach of_phy_connect_fixed_link() the new name.
>
> Tested on a P1020RDB PowerPC system.
>
> Signed-off-by: Baruch Siach<baruch@tkos.co.il>
Acked-by: Florian Fainelli <florian@openwrt.org>
> ---
> drivers/of/of_mdio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 980c079..483c0ad 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -182,7 +182,7 @@ struct phy_device *of_phy_connect_fixed_link(struct net_device *dev,
> if (!phy_id || sz< sizeof(*phy_id))
> return NULL;
>
> - sprintf(bus_id, PHY_ID_FMT, "0", be32_to_cpu(phy_id[0]));
> + sprintf(bus_id, PHY_ID_FMT, "fixed-0", be32_to_cpu(phy_id[0]));
>
> phy = phy_connect(dev, bus_id, hndlr, 0, iface);
> return IS_ERR(phy) ? NULL : phy;
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
devicetree-discuss@lists.ozlabs.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] of/mdio: fix fixed link bus name
Date: Mon, 27 Feb 2012 15:46:32 +0100 [thread overview]
Message-ID: <4F4B9748.8020509@openwrt.org> (raw)
In-Reply-To: <8ebe6a3f11343c392a7353581d5f648980206e8e.1330346765.git.baruch@tkos.co.il>
Le 02/27/12 13:48, Baruch Siach a écrit :
> Since 9e6c643b (phy/fixed: use an unique MDIO bus name) the name of the fixed
> PHY bus is "fixed-0". Teach of_phy_connect_fixed_link() the new name.
>
> Tested on a P1020RDB PowerPC system.
>
> Signed-off-by: Baruch Siach<baruch@tkos.co.il>
Acked-by: Florian Fainelli <florian@openwrt.org>
> ---
> drivers/of/of_mdio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 980c079..483c0ad 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -182,7 +182,7 @@ struct phy_device *of_phy_connect_fixed_link(struct net_device *dev,
> if (!phy_id || sz< sizeof(*phy_id))
> return NULL;
>
> - sprintf(bus_id, PHY_ID_FMT, "0", be32_to_cpu(phy_id[0]));
> + sprintf(bus_id, PHY_ID_FMT, "fixed-0", be32_to_cpu(phy_id[0]));
>
> phy = phy_connect(dev, bus_id, hndlr, 0, iface);
> return IS_ERR(phy) ? NULL : phy;
next prev parent reply other threads:[~2012-02-27 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 12:48 [PATCH] of/mdio: fix fixed link bus name Baruch Siach
2012-02-27 12:48 ` Baruch Siach
2012-02-27 14:46 ` Florian Fainelli [this message]
2012-02-27 14:46 ` Florian Fainelli
2012-02-27 15:59 ` Rob Herring
2012-02-27 15:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4B9748.8020509@openwrt.org \
--to=florian@openwrt.org \
--cc=baruch@tkos.co.il \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.