From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] add some length verification to avoid reading not owned memory
Date: Mon, 27 Feb 2012 20:38:11 -0600 [thread overview]
Message-ID: <4F4C3E13.40906@gmail.com> (raw)
In-Reply-To: <4F4C9099.7070609@vfnet.de>
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
Hi Jens,
> Well, my mail client (Thunderbird) and most modern clients I
> know are able to show attached files of text/x-patch (and
> similar) type. OTOH I wonder why you want to review patches
> in your mail client. Wouldn't it much better to use a
It is not that we read patches in the mail client, but that is also
useful. The main use-case is to be able to easily comment on the patch
if changes are required. And for that we require patches to be sent inline.
> specialized too which highlights the changes like
> $ gvim "+vert diffpatch <patchfile>" <originalfile>
> $ emacs
> or
> $ xfdiff ?
> Don't you have to save the patch files in such cases anyway?
>
No, the typical workflow (at least for me) is to
- 'Save Email'
- vim email
- if looks okay, git am and compile test
Regards,
-Denis
prev parent reply other threads:[~2012-02-28 2:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 9:21 [PATCH] add some length verification to avoid reading not owned memory Jens Rehsack
2012-02-27 17:22 ` Marcel Holtmann
2012-02-28 8:30 ` Jens Rehsack
2012-02-28 2:38 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4C3E13.40906@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.