From: Jens Rehsack <jr_extern@vfnet.de>
To: ofono@ofono.org
Subject: Re: [PATCH] add some length verification to avoid reading not owned memory
Date: Tue, 28 Feb 2012 09:30:17 +0100 [thread overview]
Message-ID: <4F4C9099.7070609@vfnet.de> (raw)
In-Reply-To: <1330363339.3392.52.camel@aeonflux>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
Am 27.02.2012 18:22, schrieb Marcel Holtmann:
> Hi Jens,
Hi Marcel,
>> while reading mmsd sources I stumbled over missing length
>> checks in src/push.c:mms_push_notify(). I didn't re-read
>> the entire source to prove overall ;)
>
> please use git format-patch and git send-email to send us inline
> patches. In case your email client doesn't support inline patches
> nicely.
Well, inline patches aren't requested at
http://ofono.org/wiki/ofono-etiquette. You probably should do.
> Reviewing patches that are attached is super painful and in most
> cases they get ignored then.
Well, my mail client (Thunderbird) and most modern clients I
know are able to show attached files of text/x-patch (and
similar) type. OTOH I wonder why you want to review patches
in your mail client. Wouldn't it much better to use a
specialized too which highlights the changes like
$ gvim "+vert diffpatch <patchfile>" <originalfile>
$ emacs
or
$ xfdiff ?
Don't you have to save the patch files in such cases anyway?
Best regards,
Jens
next prev parent reply other threads:[~2012-02-28 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 9:21 [PATCH] add some length verification to avoid reading not owned memory Jens Rehsack
2012-02-27 17:22 ` Marcel Holtmann
2012-02-28 8:30 ` Jens Rehsack [this message]
2012-02-28 2:38 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4C9099.7070609@vfnet.de \
--to=jr_extern@vfnet.de \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.