From: Igor Mitsyanko <i.mitsyanko@samsung.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qom: if @instance_size==0, assign size of object to parent object size
Date: Tue, 28 Feb 2012 13:43:57 +0400 [thread overview]
Message-ID: <4F4CA1DD.6080905@samsung.com> (raw)
In-Reply-To: <jii3sl$lo4$1@dough.gmane.org>
On 02/28/2012 12:39 PM, Paolo Bonzini wrote:
> Il 28/02/2012 08:18, Igor Mitsyanko ha scritto:
>> QOM documentation states that for objects of type with @instance_size == 0 size
>> will be assigned to match parent object's size. But currently this feauture is
>> not implemented and qemu asserts during creation of object with zero instance_size.
>> This patch adjusts actual behaviour in accordance with documentation.
>
> You can do it just once, in type_get_parent instead.
>
> Paolo
>
>
>
Can't understand how type_get_parent() is relevant to this, we can call
object_initialize() or object_new_with_type() and these two functions
must set instance_size before calling object_initialize_with_type(). Up
to this point there are no calls to type_get_parent().
Mitsyanko Igor
ASWG, Moscow R&D center, Samsung Electronics
email: i.mitsyanko@samsung.com
next prev parent reply other threads:[~2012-02-28 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 7:18 [Qemu-devel] [PATCH] qom: if @instance_size==0, assign size of object to parent object size Igor Mitsyanko
2012-02-28 8:39 ` Paolo Bonzini
2012-02-28 9:43 ` Igor Mitsyanko [this message]
2012-02-28 10:03 ` Paolo Bonzini
2012-02-28 11:09 ` Igor Mitsyanko
2012-02-28 11:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4CA1DD.6080905@samsung.com \
--to=i.mitsyanko@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.