All of lore.kernel.org
 help / color / mirror / Atom feed
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: LPC32xx: Ethernet driver
Date: Tue, 28 Feb 2012 14:32:49 +0100	[thread overview]
Message-ID: <4F4CD781.2090802@antcom.de> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B6E83@saturn3.aculab.com>

Hi,

On 02/28/2012 02:11 PM, David Laight wrote:
>> Thanks for the note! I actually found out that in many cases, the
>> bootloader already initialized the hardware with the target 
>> MAC address so we can use this one.
>>
>> For the case that it _isn't_ initialized already, is it the right
> thing
>> to use a hard coded default MAC address to be replaced by the final
> one
>> in userspace? (I found such examples in some current micrel/ and amd/
> drivers.)
> 
> Using a fixed address is a very bad idea ...

Yes, that's why we previously had a cmdline param for it (but removed it
upon request from the netdev maintainer).

So if the hardware defaults to 00:00:00:00:00:00, what is the
"consistent policy we want to enforce in all drivers"?

A link or hint would be sufficient.

Thanks in advance,

Roland

WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: David Laight <David.Laight@ACULAB.COM>
Cc: baruch@tkos.co.il, alexander.h.duyck@intel.com,
	ian.campbell@citrix.com, netdev@vger.kernel.org,
	eilong@broadcom.com, Kevin Wells <kevin.wells@nxp.com>,
	Wolfram Sang <w.sang@pengutronix.de>,
	jeffrey.t.kirsher@intel.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] ARM: LPC32xx: Ethernet driver
Date: Tue, 28 Feb 2012 14:32:49 +0100	[thread overview]
Message-ID: <4F4CD781.2090802@antcom.de> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B6E83@saturn3.aculab.com>

Hi,

On 02/28/2012 02:11 PM, David Laight wrote:
>> Thanks for the note! I actually found out that in many cases, the
>> bootloader already initialized the hardware with the target 
>> MAC address so we can use this one.
>>
>> For the case that it _isn't_ initialized already, is it the right
> thing
>> to use a hard coded default MAC address to be replaced by the final
> one
>> in userspace? (I found such examples in some current micrel/ and amd/
> drivers.)
> 
> Using a fixed address is a very bad idea ...

Yes, that's why we previously had a cmdline param for it (but removed it
upon request from the netdev maintainer).

So if the hardware defaults to 00:00:00:00:00:00, what is the
"consistent policy we want to enforce in all drivers"?

A link or hint would be sufficient.

Thanks in advance,

Roland

  reply	other threads:[~2012-02-28 13:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 13:08 [PATCH v2] ARM: LPC32xx: Ethernet driver Roland Stigge
2012-02-28 13:11 ` David Laight
2012-02-28 13:11   ` David Laight
2012-02-28 13:32   ` Roland Stigge [this message]
2012-02-28 13:32     ` Roland Stigge
2012-02-28 13:41     ` Arnd Bergmann
2012-02-28 13:41       ` Arnd Bergmann
2012-02-28 13:41       ` Arnd Bergmann
2012-02-28 13:49       ` Roland Stigge
2012-02-28 13:49         ` Roland Stigge
2012-02-28 15:53       ` Ben Hutchings
2012-02-28 15:53         ` Ben Hutchings
2012-02-28 19:13 ` David Miller
2012-02-28 19:13   ` David Miller
2012-02-28 19:13   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2012-02-25 20:21 Roland Stigge
2012-02-25 20:21 ` Roland Stigge
2012-02-25 20:41 ` Joe Perches
2012-02-25 20:41   ` Joe Perches
2012-02-26  1:52 ` Baruch Siach
2012-02-26  1:52   ` Baruch Siach
2012-02-26  2:28   ` David Miller
2012-02-26  2:28     ` David Miller
2012-02-26  2:28     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4CD781.2090802@antcom.de \
    --to=stigge@antcom.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.