* [PATCH 2/2] stb0899: fixed reading of IF_AGC_GAIN register
@ 2012-02-28 18:40 Andreas Regel
2012-02-29 8:24 ` [linux-media] " Klaus Schmidinger
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Regel @ 2012-02-28 18:40 UTC (permalink / raw)
To: Manu Abraham; +Cc: Linux Media Mailing List
When reading IF_AGC_GAIN register a wrong value for the base address
register was used (STB0899_DEMOD instead of STB0899_S2DEMOD). That
lead to a wrong signal strength value on DVB-S2 transponders.
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
---
drivers/media/dvb/frontends/stb0899_drv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c
b/drivers/media/dvb/frontends/stb0899_drv.c
index 4a58afc..a2e9eba 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -983,7 +983,7 @@ static int stb0899_read_signal_strength(struct
dvb_frontend *fe, u16 *strength)
break;
case SYS_DVBS2:
if (internal->lock) {
- reg = STB0899_READ_S2REG(STB0899_DEMOD, IF_AGC_GAIN);
+ reg = STB0899_READ_S2REG(STB0899_S2DEMOD, IF_AGC_GAIN);
val = STB0899_GETFIELD(IF_AGC_GAIN, reg);
*strength = stb0899_table_lookup(stb0899_dvbs2rf_tab,
ARRAY_SIZE(stb0899_dvbs2rf_tab) - 1, val);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [linux-media] [PATCH 2/2] stb0899: fixed reading of IF_AGC_GAIN register
2012-02-28 18:40 [PATCH 2/2] stb0899: fixed reading of IF_AGC_GAIN register Andreas Regel
@ 2012-02-29 8:24 ` Klaus Schmidinger
0 siblings, 0 replies; 2+ messages in thread
From: Klaus Schmidinger @ 2012-02-29 8:24 UTC (permalink / raw)
To: linux-media
> When reading IF_AGC_GAIN register a wrong value for the base address
> register was used (STB0899_DEMOD instead of STB0899_S2DEMOD). That
> lead to a wrong signal strength value on DVB-S2 transponders.
>
> Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
> ---
> drivers/media/dvb/frontends/stb0899_drv.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
> index 4a58afc..a2e9eba 100644
> --- a/drivers/media/dvb/frontends/stb0899_drv.c
> +++ b/drivers/media/dvb/frontends/stb0899_drv.c
> @@ -983,7 +983,7 @@ static int stb0899_read_signal_strength(struct dvb_frontend *fe, u16 *strength)
> break;
> case SYS_DVBS2:
> if (internal->lock) {
> - reg = STB0899_READ_S2REG(STB0899_DEMOD, IF_AGC_GAIN);
> + reg = STB0899_READ_S2REG(STB0899_S2DEMOD, IF_AGC_GAIN);
> val = STB0899_GETFIELD(IF_AGC_GAIN, reg);
> *strength = stb0899_table_lookup(stb0899_dvbs2rf_tab, ARRAY_SIZE(stb0899_dvbs2rf_tab) - 1, val);
Acked-by: Klaus Schmidinger <Klaus.Schmidinger@tvdr.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-29 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-28 18:40 [PATCH 2/2] stb0899: fixed reading of IF_AGC_GAIN register Andreas Regel
2012-02-29 8:24 ` [linux-media] " Klaus Schmidinger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.