From: Tushar Behera <tushar.behera@linaro.org>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: Sangwook Lee <sangwook.lee@linaro.org>,
linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org,
gregkh@suse.de, kgene.kim@samsung.com, stern@rowland.harvard.edu,
jg1.han@samsung.com, jy0922.shim@samsung.com, patches@linaro.org,
linaro-dev@lists.linaro.org, linux@arm.linux.org.uk
Subject: Re: [PATCH 1/2] ARM: EXYNOS: Add EHCI AHB burst function
Date: Thu, 01 Mar 2012 08:54:54 +0530 [thread overview]
Message-ID: <4F4EEC06.8010400@linaro.org> (raw)
In-Reply-To: <CAJuYYwTW6rBiSJdeFYMui96t6nszjADW4t+14XakRkc=_4DbBA@mail.gmail.com>
On 02/29/2012 06:31 PM, Thomas Abraham wrote:
> Hi Sangwook,
>
> On 29 February 2012 18:11, Sangwook Lee <sangwook.lee@linaro.org> wrote:
>> Enable burst transfer from AHB for EHCI.
>> This fixes data transfer of USB Ethernet with EHCI.
>> Without this patch, scp hardly works.
>>
>> Signed-off-by: Sangwook Lee <sangwook.lee@linaro.org>
>> ---
>> arch/arm/mach-exynos/setup-usb-phy.c | 6 ++++++
>> arch/arm/plat-samsung/devs.c | 2 ++
>> arch/arm/plat-samsung/include/plat/ehci.h | 19 +++++++++++++++++++
>> 3 files changed, 27 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/setup-usb-phy.c b/arch/arm/mach-exynos/setup-usb-phy.c
>> index 41743d2..5a20460 100644
>> --- a/arch/arm/mach-exynos/setup-usb-phy.c
>> +++ b/arch/arm/mach-exynos/setup-usb-phy.c
>> @@ -18,6 +18,7 @@
>> #include <mach/regs-usb-phy.h>
>> #include <plat/cpu.h>
>> #include <plat/usb-phy.h>
>> +#include <plat/ehci.h>
>>
>> static atomic_t host_usage;
>>
>> @@ -149,3 +150,8 @@ int s5p_usb_phy_exit(struct platform_device *pdev, int type)
>>
>> return -EINVAL;
>> }
>> +
>> +void s5p_ehci_burst_enable(struct platform_device *pdev, void __iomem *base)
>> +{
>> + writel(EHCI_INSNREG00_ENABLE_BURST, base + EHCI_INSNREG00);
>> +}
>
> This functionality can be added in ehci-s5p itself and avoid adding a
> new platform callback in platform data. If this is specific to exynos,
> driver data could be added in ehci-s5p to indicate platforms that need
> this to be enabled.
>
Am I right in assuming that ehci-s5p driver can also be used for
mach-s5pv210?
The related bit-fields are reserved in S5PV210. So, won't it cause any
side-effects?
> Thanks,
> Thomas.
>
> [...]
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Tushar Behera
WARNING: multiple messages have this Message-ID (diff)
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: EXYNOS: Add EHCI AHB burst function
Date: Thu, 01 Mar 2012 08:54:54 +0530 [thread overview]
Message-ID: <4F4EEC06.8010400@linaro.org> (raw)
In-Reply-To: <CAJuYYwTW6rBiSJdeFYMui96t6nszjADW4t+14XakRkc=_4DbBA@mail.gmail.com>
On 02/29/2012 06:31 PM, Thomas Abraham wrote:
> Hi Sangwook,
>
> On 29 February 2012 18:11, Sangwook Lee <sangwook.lee@linaro.org> wrote:
>> Enable burst transfer from AHB for EHCI.
>> This fixes data transfer of USB Ethernet with EHCI.
>> Without this patch, scp hardly works.
>>
>> Signed-off-by: Sangwook Lee <sangwook.lee@linaro.org>
>> ---
>> arch/arm/mach-exynos/setup-usb-phy.c | 6 ++++++
>> arch/arm/plat-samsung/devs.c | 2 ++
>> arch/arm/plat-samsung/include/plat/ehci.h | 19 +++++++++++++++++++
>> 3 files changed, 27 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/setup-usb-phy.c b/arch/arm/mach-exynos/setup-usb-phy.c
>> index 41743d2..5a20460 100644
>> --- a/arch/arm/mach-exynos/setup-usb-phy.c
>> +++ b/arch/arm/mach-exynos/setup-usb-phy.c
>> @@ -18,6 +18,7 @@
>> #include <mach/regs-usb-phy.h>
>> #include <plat/cpu.h>
>> #include <plat/usb-phy.h>
>> +#include <plat/ehci.h>
>>
>> static atomic_t host_usage;
>>
>> @@ -149,3 +150,8 @@ int s5p_usb_phy_exit(struct platform_device *pdev, int type)
>>
>> return -EINVAL;
>> }
>> +
>> +void s5p_ehci_burst_enable(struct platform_device *pdev, void __iomem *base)
>> +{
>> + writel(EHCI_INSNREG00_ENABLE_BURST, base + EHCI_INSNREG00);
>> +}
>
> This functionality can be added in ehci-s5p itself and avoid adding a
> new platform callback in platform data. If this is specific to exynos,
> driver data could be added in ehci-s5p to indicate platforms that need
> this to be enabled.
>
Am I right in assuming that ehci-s5p driver can also be used for
mach-s5pv210?
The related bit-fields are reserved in S5PV210. So, won't it cause any
side-effects?
> Thanks,
> Thomas.
>
> [...]
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Tushar Behera
next prev parent reply other threads:[~2012-03-01 3:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 12:41 [PATCH 0/2] add ehci-s5p AHB burst function Sangwook Lee
2012-02-29 12:41 ` Sangwook Lee
[not found] ` <1330519283-4722-1-git-send-email-sangwook.lee-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-02-29 12:41 ` [PATCH 1/2] ARM: EXYNOS: Add EHCI " Sangwook Lee
2012-02-29 12:41 ` Sangwook Lee
2012-02-29 13:01 ` Thomas Abraham
2012-02-29 13:01 ` Thomas Abraham
2012-02-29 13:13 ` Jingoo Han
2012-02-29 13:13 ` Jingoo Han
2012-02-29 14:27 ` Sangwook Lee
2012-02-29 14:27 ` Sangwook Lee
2012-03-01 3:24 ` Tushar Behera [this message]
2012-03-01 3:24 ` Tushar Behera
[not found] ` <4F4EEC06.8010400-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-03-01 9:18 ` Sangwook Lee
2012-02-29 13:23 ` Jingoo Han
2012-02-29 13:23 ` Jingoo Han
[not found] ` <000701ccf6e5$63bb6170$2b322450$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-02-29 14:21 ` Sangwook Lee
2012-02-29 14:21 ` Sangwook Lee
2012-02-29 12:41 ` [PATCH 2/2] USB: ehci-s5p: add function for burst Sangwook Lee
2012-02-29 12:41 ` Sangwook Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4EEC06.8010400@linaro.org \
--to=tushar.behera@linaro.org \
--cc=ben-linux@fluff.org \
--cc=gregkh@suse.de \
--cc=jg1.han@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=sangwook.lee@linaro.org \
--cc=stern@rowland.harvard.edu \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.