From: Tushar Behera <tushar.behera@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-usb@vger.kernel.org,
'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
'Sangwook Lee' <sangwook.lee@linaro.org>,
'Alan Stern' <stern@rowland.harvard.edu>,
'Joonyoung Shim' <jy0922.shim@samsung.com>,
'Kukjin Kim' <kgene.kim@samsung.com>,
patches@linaro.org, linaro-dev@lists.linaro.org,
'Thomas Abraham' <thomas.abraham@linaro.org>
Subject: Re: [PATCH 1/2] ARM: EXYNOS: Add USB HOST register definitions
Date: Thu, 01 Mar 2012 09:00:10 +0530 [thread overview]
Message-ID: <4F4EED42.2010700@linaro.org> (raw)
In-Reply-To: <000101ccf6ef$f4efbab0$decf3010$%han@samsung.com>
On 02/29/2012 08:09 PM, Jingoo Han wrote:
> This patch adds USB HOST register definitions. The definition for
> EHCI INSNREG00 regiser and corresponding bit field definitions are
> added.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> arch/arm/mach-exynos/include/mach/regs-usb-host.h | 23 +++++++++++++++++++++
> 1 files changed, 23 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/mach-exynos/include/mach/regs-usb-host.h
>
> diff --git a/arch/arm/mach-exynos/include/mach/regs-usb-host.h b/arch/arm/mach-exynos/include/mach/regs-usb-host.h
> new file mode 100644
> index 0000000..1a60f27
> --- /dev/null
> +++ b/arch/arm/mach-exynos/include/mach/regs-usb-host.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (C) 2012 Samsung Electronics Co.Ltd
> + * http://www.samsung.com
> + *
> + * EXYNOS - USB HOST register definitions
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef __REGS_USB_HOST_H
> +#define __REGS_USB_HOST_H __FILE__
> +
> +#define EHCI_INSNREG00(base) (base + 0x90)
> +#define EHCI_ENA_INCR16 (0x1 << 25)
> +#define EHCI_ENA_INCR8 (0x1 << 24)
> +#define EHCI_ENA_INCR4 (0x1 << 23)
> +#define EHCI_ENA_INCRX_ALIGN (0x1 << 22)
> +#define EHCI_ENABLE_DMA_INCR (EHCI_ENA_INCR16 | EHCI_ENA_INCR8| \
> + EHCI_ENA_INCR4 | EHCI_ENA_INCRX_ALIGN)
> +
As per the definition of bit-fields in other registers, it would be good
to prepend the complete register name before the bit-field defines.
EHCI_INSNREG00_ENA_INCR16 ...
Considering the similarity of this patchset with the earlier patchset
from Sangwook, IMO, it would be appropriate to give him due credit in
both these patches.
> +#endif /* __REGS_USB_HOST_H */
--
Tushar Behera
WARNING: multiple messages have this Message-ID (diff)
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: EXYNOS: Add USB HOST register definitions
Date: Thu, 01 Mar 2012 09:00:10 +0530 [thread overview]
Message-ID: <4F4EED42.2010700@linaro.org> (raw)
In-Reply-To: <000101ccf6ef$f4efbab0$decf3010$%han@samsung.com>
On 02/29/2012 08:09 PM, Jingoo Han wrote:
> This patch adds USB HOST register definitions. The definition for
> EHCI INSNREG00 regiser and corresponding bit field definitions are
> added.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> arch/arm/mach-exynos/include/mach/regs-usb-host.h | 23 +++++++++++++++++++++
> 1 files changed, 23 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/mach-exynos/include/mach/regs-usb-host.h
>
> diff --git a/arch/arm/mach-exynos/include/mach/regs-usb-host.h b/arch/arm/mach-exynos/include/mach/regs-usb-host.h
> new file mode 100644
> index 0000000..1a60f27
> --- /dev/null
> +++ b/arch/arm/mach-exynos/include/mach/regs-usb-host.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (C) 2012 Samsung Electronics Co.Ltd
> + * http://www.samsung.com
> + *
> + * EXYNOS - USB HOST register definitions
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef __REGS_USB_HOST_H
> +#define __REGS_USB_HOST_H __FILE__
> +
> +#define EHCI_INSNREG00(base) (base + 0x90)
> +#define EHCI_ENA_INCR16 (0x1 << 25)
> +#define EHCI_ENA_INCR8 (0x1 << 24)
> +#define EHCI_ENA_INCR4 (0x1 << 23)
> +#define EHCI_ENA_INCRX_ALIGN (0x1 << 22)
> +#define EHCI_ENABLE_DMA_INCR (EHCI_ENA_INCR16 | EHCI_ENA_INCR8| \
> + EHCI_ENA_INCR4 | EHCI_ENA_INCRX_ALIGN)
> +
As per the definition of bit-fields in other registers, it would be good
to prepend the complete register name before the bit-field defines.
EHCI_INSNREG00_ENA_INCR16 ...
Considering the similarity of this patchset with the earlier patchset
from Sangwook, IMO, it would be appropriate to give him due credit in
both these patches.
> +#endif /* __REGS_USB_HOST_H */
--
Tushar Behera
next prev parent reply other threads:[~2012-03-01 3:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 14:39 [PATCH 1/2] ARM: EXYNOS: Add USB HOST register definitions Jingoo Han
2012-02-29 14:39 ` Jingoo Han
2012-03-01 3:30 ` Tushar Behera [this message]
2012-03-01 3:30 ` Tushar Behera
2012-03-01 5:15 ` Jingoo Han
2012-03-01 5:15 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4EED42.2010700@linaro.org \
--to=tushar.behera@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sangwook.lee@linaro.org \
--cc=stern@rowland.harvard.edu \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.