All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Paul Brook <paul@codesourcery.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Riku Voipio <riku.voipio@iki.fi>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Userspace ARM BE8 support
Date: Thu, 01 Mar 2012 09:06:09 +0100	[thread overview]
Message-ID: <4F4F2DF1.8030906@suse.de> (raw)
In-Reply-To: <1330530051-20404-1-git-send-email-paul@codesourcery.com>

Am 29.02.2012 16:40, schrieb Paul Brook:
> Add support for ARM BE8 userspace binaries.
> i.e. big-endian data and little-endian code.
> In principle LE8 mode is also possible, but AFAIK has never actually
> been implemented/used.
> 
> System emulation doesn't have any useable big-endian board models,
> but should in principle work once you fix that.
> Dynamic iendianness switching requires messing with data accesses,
> preferably with TCG cooperation, and is orthogonal to BE8 support.
> 
> Signed-off-by: Paul Brook <paul@codesourcery.com>

Patch looks good in general. There's some braces missing though for ifs:
It's considered mandatory for new code, and we usually fix up old code
that we touch.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2012-03-01  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 15:40 [Qemu-devel] [PATCH] Userspace ARM BE8 support Paul Brook
2012-03-01  8:06 ` Andreas Färber [this message]
2012-03-05 19:04 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4F2DF1.8030906@suse.de \
    --to=afaerber@suse.de \
    --cc=paul@codesourcery.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.