* [Qemu-devel] [PATCH] usb: Fix signature of stub usb_host_device_open
@ 2012-03-01 9:43 ` Jan Kiszka
0 siblings, 0 replies; 8+ messages in thread
From: Jan Kiszka @ 2012-03-01 9:43 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: Gerd Hoffmann, Roy Tam
This was a breakage of 3741715cf2.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
usb-stub.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/usb-stub.c b/usb-stub.c
index 9c3fcea..b4e10c1 100644
--- a/usb-stub.c
+++ b/usb-stub.c
@@ -41,7 +41,7 @@ void usb_host_info(Monitor *mon)
}
/* XXX: modify configure to compile the right host driver */
-USBDevice *usb_host_device_open(const char *devname)
+USBDevice *usb_host_device_open(USBBus *bus, const char *devname)
{
return NULL;
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [PATCH] usb: Fix signature of stub usb_host_device_open
2012-03-01 9:43 ` [Qemu-devel] " Jan Kiszka
@ 2012-03-01 10:50 ` Gerd Hoffmann
-1 siblings, 0 replies; 8+ messages in thread
From: Gerd Hoffmann @ 2012-03-01 10:50 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-trivial, qemu-devel, Roy Tam
On 03/01/12 10:43, Jan Kiszka wrote:
> -USBDevice *usb_host_device_open(const char *devname)
> +USBDevice *usb_host_device_open(USBBus *bus, const char *devname)
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] usb: Fix signature of stub usb_host_device_open
2012-03-01 9:43 ` [Qemu-devel] " Jan Kiszka
@ 2012-03-03 17:56 ` Blue Swirl
-1 siblings, 0 replies; 8+ messages in thread
From: Blue Swirl @ 2012-03-03 17:56 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-trivial, Roy Tam, qemu-devel, Gerd Hoffmann
Thanks, applied.
On Thu, Mar 1, 2012 at 09:43, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> This was a breakage of 3741715cf2.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> usb-stub.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/usb-stub.c b/usb-stub.c
> index 9c3fcea..b4e10c1 100644
> --- a/usb-stub.c
> +++ b/usb-stub.c
> @@ -41,7 +41,7 @@ void usb_host_info(Monitor *mon)
> }
>
> /* XXX: modify configure to compile the right host driver */
> -USBDevice *usb_host_device_open(const char *devname)
> +USBDevice *usb_host_device_open(USBBus *bus, const char *devname)
> {
> return NULL;
> }
> --
> 1.7.3.4
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] usb: Fix signature of stub usb_host_device_open
@ 2012-03-03 17:56 ` Blue Swirl
0 siblings, 0 replies; 8+ messages in thread
From: Blue Swirl @ 2012-03-03 17:56 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-trivial, Roy Tam, qemu-devel, Gerd Hoffmann
Thanks, applied.
On Thu, Mar 1, 2012 at 09:43, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> This was a breakage of 3741715cf2.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> usb-stub.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/usb-stub.c b/usb-stub.c
> index 9c3fcea..b4e10c1 100644
> --- a/usb-stub.c
> +++ b/usb-stub.c
> @@ -41,7 +41,7 @@ void usb_host_info(Monitor *mon)
> }
>
> /* XXX: modify configure to compile the right host driver */
> -USBDevice *usb_host_device_open(const char *devname)
> +USBDevice *usb_host_device_open(USBBus *bus, const char *devname)
> {
> return NULL;
> }
> --
> 1.7.3.4
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] usb: Fix signature of stub usb_host_device_open
2012-03-01 9:43 ` [Qemu-devel] " Jan Kiszka
@ 2012-03-05 16:47 ` Stefan Hajnoczi
-1 siblings, 0 replies; 8+ messages in thread
From: Stefan Hajnoczi @ 2012-03-05 16:47 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-trivial, Roy Tam, qemu-devel, Gerd Hoffmann
On Thu, Mar 01, 2012 at 10:43:50AM +0100, Jan Kiszka wrote:
> This was a breakage of 3741715cf2.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> usb-stub.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Even if a build fix is trivial, I suggest sending it only to
qemu-devel@nongnu.org because trivial patches pull requests only get
sent out about once per week. It's fastest to get build fixed committed
directly.
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] usb: Fix signature of stub usb_host_device_open
@ 2012-03-05 16:47 ` Stefan Hajnoczi
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Hajnoczi @ 2012-03-05 16:47 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-trivial, Roy Tam, qemu-devel, Gerd Hoffmann
On Thu, Mar 01, 2012 at 10:43:50AM +0100, Jan Kiszka wrote:
> This was a breakage of 3741715cf2.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> usb-stub.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Even if a build fix is trivial, I suggest sending it only to
qemu-devel@nongnu.org because trivial patches pull requests only get
sent out about once per week. It's fastest to get build fixed committed
directly.
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread