From: Eric Blake <eblake@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Bobby Powers <bobbypowers@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory slots
Date: Thu, 01 Mar 2012 10:08:47 -0700 [thread overview]
Message-ID: <4F4FAD1F.7080603@redhat.com> (raw)
In-Reply-To: <4F4FABD7.1030709@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On 03/01/2012 10:03 AM, Avi Kivity wrote:
>>>
>>> - ram = memory_region_get_ram_ptr(mr) + section->offset_within_region;
>>> + ram = memory_region_get_ram_ptr(mr) + section->offset_within_region
>>> + delta;
>>
>> Am I crazy, or does this look wrong?
>
> Could be both. Why do you thing it is wrong?
Line wrapping makes it look like we are adding two lines, one line
ending in 'section->offset_within_region', and the next line starting
with 'delta;', which is a syntax error.
But without line wrapping, we are adding just one line with
'offset_within_region + delta;' at the end of that line.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel <qemu-devel@nongnu.org>,
Bobby Powers <bobbypowers@gmail.com>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory slots
Date: Thu, 01 Mar 2012 10:08:47 -0700 [thread overview]
Message-ID: <4F4FAD1F.7080603@redhat.com> (raw)
In-Reply-To: <4F4FABD7.1030709@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On 03/01/2012 10:03 AM, Avi Kivity wrote:
>>>
>>> - ram = memory_region_get_ram_ptr(mr) + section->offset_within_region;
>>> + ram = memory_region_get_ram_ptr(mr) + section->offset_within_region
>>> + delta;
>>
>> Am I crazy, or does this look wrong?
>
> Could be both. Why do you thing it is wrong?
Line wrapping makes it look like we are adding two lines, one line
ending in 'section->offset_within_region', and the next line starting
with 'delta;', which is a syntax error.
But without line wrapping, we are adding just one line with
'offset_within_region + delta;' at the end of that line.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-03-01 17:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 13:40 [PULL] Urgent memory fix for kvm with unaligned memory slots Avi Kivity
2012-03-01 13:40 ` [Qemu-devel] " Avi Kivity
2012-03-01 16:51 ` Bobby Powers
2012-03-01 16:51 ` [Qemu-devel] " Bobby Powers
2012-03-01 17:03 ` Avi Kivity
2012-03-01 17:03 ` [Qemu-devel] " Avi Kivity
2012-03-01 17:08 ` Eric Blake [this message]
2012-03-01 17:08 ` Eric Blake
2012-03-01 17:11 ` Bobby Powers
2012-03-01 17:11 ` Bobby Powers
2012-03-01 17:13 ` Avi Kivity
2012-03-01 17:13 ` Avi Kivity
2012-03-02 13:23 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4FAD1F.7080603@redhat.com \
--to=eblake@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=bobbypowers@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.