[PATCH] include usbinit package with usbgadget feature

[PATCH] include usbinit package with usbgadget feature

[Hollis Blanchard]

The g_ether kernel module, in the kernel-module-g-ether package, allows 
targets to use a USB connection as a network interface. However, that's 
not useful until the module is loaded.

The usbinit package provides the /etc/init.d/usb-gether script to load 
the g_ether module at boot, so it should be included along with 
kernel-module-g-ether.

Tested with core-image-base on beagleboard.

Signed-off-by: Hollis Blanchard <hollis_blanchard@mentor.com>
---

diff --git a/meta/recipes-core/tasks/task-base.bb b/meta/recipes-core/tasks/task-base.bb
index 2032432..fda0384 100644
--- a/meta/recipes-core/tasks/task-base.bb
+++ b/meta/recipes-core/tasks/task-base.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "Merge machine and distro options to create a basic machine task/p
  LICENSE = "MIT"
  LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
                      file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-PR = "r73"
+PR = "r74"

  inherit task

@@ -248,7 +248,8 @@ RRECOMMENDS_task-base-usbgadget = "\
      kernel-module-gadgetfs \
      kernel-module-g-file-storage \
      kernel-module-g-serial \
-    kernel-module-g-ether"
+    kernel-module-g-ether \
+    usbinit"

  RDEPENDS_task-base-usbhost = "\
      usbutils "

Re: [PATCH] include usbinit package with usbgadget feature

[Darren Hart]

On 03/01/2012 02:26 PM, Hollis Blanchard wrote:
> The g_ether kernel module, in the kernel-module-g-ether package, allows 
> targets to use a USB connection as a network interface. However, that's 
> not useful until the module is loaded.
> 
> The usbinit package provides the /etc/init.d/usb-gether script to load 
> the g_ether module at boot, so it should be included along with 
> kernel-module-g-ether.

So if the g-ether kernel module is built-in to the kernel, the
kernel-module-g-ether will not be installed (as it's RRECOMMENDS). The
usbinit package still will be (unless for some reason it can't be built
for the target).

I assume this doesn't pose a problem?

This does mean usbinit would be installed when it isn't strictly
necessary - but that's better than not installing it if it's required.
Looks good to me.

--
Darren



> 
> Tested with core-image-base on beagleboard.
> 
> Signed-off-by: Hollis Blanchard <hollis_blanchard@mentor.com>
> ---
> 
> diff --git a/meta/recipes-core/tasks/task-base.bb b/meta/recipes-core/tasks/task-base.bb
> index 2032432..fda0384 100644
> --- a/meta/recipes-core/tasks/task-base.bb
> +++ b/meta/recipes-core/tasks/task-base.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "Merge machine and distro options to create a basic machine task/p
>   LICENSE = "MIT"
>   LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>                       file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> -PR = "r73"
> +PR = "r74"
> 
>   inherit task
> 
> @@ -248,7 +248,8 @@ RRECOMMENDS_task-base-usbgadget = "\
>       kernel-module-gadgetfs \
>       kernel-module-g-file-storage \
>       kernel-module-g-serial \
> -    kernel-module-g-ether"
> +    kernel-module-g-ether \
> +    usbinit"
> 
>   RDEPENDS_task-base-usbhost = "\
>       usbutils "
> 
> 
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH] include usbinit package with usbgadget feature

[Hollis Blanchard]

On 03/01/2012 02:45 PM, Darren Hart wrote:
> On 03/01/2012 02:26 PM, Hollis Blanchard wrote:
>> The g_ether kernel module, in the kernel-module-g-ether package, allows
>> targets to use a USB connection as a network interface. However, that's
>> not useful until the module is loaded.
>>
>> The usbinit package provides the /etc/init.d/usb-gether script to load
>> the g_ether module at boot, so it should be included along with
>> kernel-module-g-ether.
> So if the g-ether kernel module is built-in to the kernel, the
> kernel-module-g-ether will not be installed (as it's RRECOMMENDS). The
> usbinit package still will be (unless for some reason it can't be built
> for the target).
>
> I assume this doesn't pose a problem?

Well, hmm, I don't know. The usb-gether script is not very intelligent, 
so I suppose that would result in yet another boot time error message. 
Perhaps testing the result of 'modinfo g_ether' in the script would be a 
good follow-up patch?

Hollis Blanchard
Mentor Graphics, Embedded Systems Division

Re: [PATCH] include usbinit package with usbgadget feature

[Darren Hart]

On 03/01/2012 03:01 PM, Hollis Blanchard wrote:
> On 03/01/2012 02:45 PM, Darren Hart wrote:
>> On 03/01/2012 02:26 PM, Hollis Blanchard wrote:
>>> The g_ether kernel module, in the kernel-module-g-ether package, allows
>>> targets to use a USB connection as a network interface. However, that's
>>> not useful until the module is loaded.
>>>
>>> The usbinit package provides the /etc/init.d/usb-gether script to load
>>> the g_ether module at boot, so it should be included along with
>>> kernel-module-g-ether.
>> So if the g-ether kernel module is built-in to the kernel, the
>> kernel-module-g-ether will not be installed (as it's RRECOMMENDS). The
>> usbinit package still will be (unless for some reason it can't be built
>> for the target).
>>
>> I assume this doesn't pose a problem?
> 
> Well, hmm, I don't know. The usb-gether script is not very intelligent, 
> so I suppose that would result in yet another boot time error message. 
> Perhaps testing the result of 'modinfo g_ether' in the script would be a 
> good follow-up patch?
> 

Sounds reasonable to me.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH] include usbinit package with usbgadget feature

[Hollis Blanchard]

On 03/01/2012 02:26 PM, Hollis Blanchard wrote:
> The g_ether kernel module, in the kernel-module-g-ether package, 
> allows targets to use a USB connection as a network interface. 
> However, that's not useful until the module is loaded.
>
> The usbinit package provides the /etc/init.d/usb-gether script to load 
> the g_ether module at boot, so it should be included along with 
> kernel-module-g-ether.
>
> Tested with core-image-base on beagleboard.
>
> Signed-off-by: Hollis Blanchard <hollis_blanchard@mentor.com>
> ---
>
> diff --git a/meta/recipes-core/tasks/task-base.bb 
> b/meta/recipes-core/tasks/task-base.bb
> index 2032432..fda0384 100644
> --- a/meta/recipes-core/tasks/task-base.bb
> +++ b/meta/recipes-core/tasks/task-base.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "Merge machine and distro options to 
> create a basic machine task/p
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = 
> "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>                      
> file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> -PR = "r73"
> +PR = "r74"
>
>  inherit task
>
> @@ -248,7 +248,8 @@ RRECOMMENDS_task-base-usbgadget = "\
>      kernel-module-gadgetfs \
>      kernel-module-g-file-storage \
>      kernel-module-g-serial \
> -    kernel-module-g-ether"
> +    kernel-module-g-ether \
> +    usbinit"
>
>  RDEPENDS_task-base-usbhost = "\
>      usbutils "

Any additional comments?

Hollis Blanchard
Mentor Graphics, Embedded Systems Division