From: "H. Peter Anvin" <hpa@zytor.com>
To: "Joshua C." <joshuacov@googlemail.com>
Cc: Bodo Eggert <7eggert@gmx.de>, linux-kernel@vger.kernel.org
Subject: Re: [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock
Date: Fri, 02 Mar 2012 10:28:29 -0800 [thread overview]
Message-ID: <4F51114D.80704@zytor.com> (raw)
In-Reply-To: <CAKL7Q7owDCs0=RyhY7gLpyYgOJ9gisdH=p2+qvZ043dDFMN76Q@mail.gmail.com>
On 03/02/2012 09:53 AM, Joshua C. wrote:
>
> I thought about your idea for separating the platform specific code in
> another file. It will make the code more modular but at the end we're
> talking about a single function that flips a single bit. I really
> don't see any real benefit from defining it in a separate file. It
> makes (from my point of view) reading the file just more difficult.
> That's why I decided to return the platform specific code back where
> it originally was and only modifiy the x86 code. So I can keep the
> changes at minimum. I'll post the patch later today and cc the tty
> maintainer. Thanks for the help and the ideas.
>
Yeah, it seems a bit excessive in this case.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-03-02 18:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 19:23 [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock Joshua C.
2012-02-27 21:09 ` H. Peter Anvin
2012-02-28 0:08 ` Joshua C.
2012-02-28 0:14 ` H. Peter Anvin
2012-02-28 0:27 ` H. Peter Anvin
2012-02-28 9:14 ` Joshua C.
2012-02-28 18:32 ` Bodo Eggert
2012-02-28 18:35 ` H. Peter Anvin
2012-02-29 11:43 ` Joshua C.
2012-02-29 17:54 ` Bodo Eggert
2012-02-29 18:16 ` H. Peter Anvin
2012-02-29 22:56 ` Joshua C.
2012-02-29 23:11 ` H. Peter Anvin
2012-02-29 23:51 ` Joshua C.
2012-03-01 0:13 ` H. Peter Anvin
2012-03-01 0:21 ` Joshua C.
2012-03-01 0:23 ` H. Peter Anvin
2012-03-01 0:28 ` Joshua C.
2012-03-01 19:42 ` Joshua C.
2012-03-01 20:54 ` H. Peter Anvin
2012-03-02 17:53 ` Joshua C.
2012-03-02 18:28 ` H. Peter Anvin [this message]
2012-03-02 21:21 ` Joshua C.
2012-03-02 21:32 ` H. Peter Anvin
[not found] ` <CAKL7Q7ru8NDW=2wVRjzkYnw5GMordFEUKGLBUon0-knH5fAsew@mail.gmail.com>
[not found] ` <20120304000031.58d23f65@pyramind.ukuu.org.uk>
[not found] ` <CAKL7Q7pzhg+_W65Ce2Kj9QRPrFmT2kTOdzY_TDEeQibgpERxTw@mail.gmail.com>
[not found] ` <4F6A045C.5090602@zytor.com>
[not found] ` <CAKL7Q7q_fOTovsBLDFqsC49dni_MDiioZjCCE-2DY4a0hqNPOA@mail.gmail.com>
2012-04-08 12:56 ` Joshua C.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F51114D.80704@zytor.com \
--to=hpa@zytor.com \
--cc=7eggert@gmx.de \
--cc=joshuacov@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.