From: "H. Peter Anvin" <hpa@zytor.com>
To: "Joshua C." <joshuacov@googlemail.com>
Cc: Bodo Eggert <7eggert@gmx.de>,
linux-kernel@vger.kernel.org, Alan Cox <alan@linux.intel.com>
Subject: Re: [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock
Date: Fri, 02 Mar 2012 13:32:48 -0800 [thread overview]
Message-ID: <4F513C80.2090709@zytor.com> (raw)
In-Reply-To: <CAKL7Q7rKVu-5OkKWoO3ZiCakiKsC=MAugRTXWB+rnudqUzvPvw@mail.gmail.com>
On 03/02/2012 01:21 PM, Joshua C. wrote:
> 2012/3/2 H. Peter Anvin <hpa@zytor.com>:
>>
>> Yeah, it seems a bit excessive in this case.
>>
>> -hpa
>>
>> --
>> H. Peter Anvin, Intel Open Source Technology Center
>> I work for Intel. I don't speak on their behalf.
>>
>
> This is the final version. It works fine here on one laptop and a desktop.
>
> @Alan
> Can you, please, queue this for the mainline and also push it to
> stable? The patch is straight forward and set the NumLock on a
> keyboard according to the data in the BIOS.
>
I still prefer the inline function instead of a macro for KBD_DEFLEDS,
but this is in deep nitpick territory at this point, and the macro is
already there.
Reviewed-by: H. Peter Anvin <hpa@zytor.com>
-hpa
next prev parent reply other threads:[~2012-03-02 21:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 19:23 [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock Joshua C.
2012-02-27 21:09 ` H. Peter Anvin
2012-02-28 0:08 ` Joshua C.
2012-02-28 0:14 ` H. Peter Anvin
2012-02-28 0:27 ` H. Peter Anvin
2012-02-28 9:14 ` Joshua C.
2012-02-28 18:32 ` Bodo Eggert
2012-02-28 18:35 ` H. Peter Anvin
2012-02-29 11:43 ` Joshua C.
2012-02-29 17:54 ` Bodo Eggert
2012-02-29 18:16 ` H. Peter Anvin
2012-02-29 22:56 ` Joshua C.
2012-02-29 23:11 ` H. Peter Anvin
2012-02-29 23:51 ` Joshua C.
2012-03-01 0:13 ` H. Peter Anvin
2012-03-01 0:21 ` Joshua C.
2012-03-01 0:23 ` H. Peter Anvin
2012-03-01 0:28 ` Joshua C.
2012-03-01 19:42 ` Joshua C.
2012-03-01 20:54 ` H. Peter Anvin
2012-03-02 17:53 ` Joshua C.
2012-03-02 18:28 ` H. Peter Anvin
2012-03-02 21:21 ` Joshua C.
2012-03-02 21:32 ` H. Peter Anvin [this message]
[not found] ` <CAKL7Q7ru8NDW=2wVRjzkYnw5GMordFEUKGLBUon0-knH5fAsew@mail.gmail.com>
[not found] ` <20120304000031.58d23f65@pyramind.ukuu.org.uk>
[not found] ` <CAKL7Q7pzhg+_W65Ce2Kj9QRPrFmT2kTOdzY_TDEeQibgpERxTw@mail.gmail.com>
[not found] ` <4F6A045C.5090602@zytor.com>
[not found] ` <CAKL7Q7q_fOTovsBLDFqsC49dni_MDiioZjCCE-2DY4a0hqNPOA@mail.gmail.com>
2012-04-08 12:56 ` Joshua C.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F513C80.2090709@zytor.com \
--to=hpa@zytor.com \
--cc=7eggert@gmx.de \
--cc=alan@linux.intel.com \
--cc=joshuacov@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.