"usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc

"usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc

[Paul Gortmaker]

This commit:

---------------
commit 637b78eb31e0b167ed913f1750bb645dfeda38f0
Author: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Date:   Fri Feb 3 16:14:18 2012 +0900

    usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt
    
    Problem:
     pch_udc continues operation even if VBUS becomes Low.
     pch_udc performs D+ pulling up before VBUS becomes High.
     USB device should be controlled according to VBUS state.
    
    Root cause:
     The current pch_udc is not always monitoring VBUS.
    
    Solution:
     The change of VBUS is detected using an interrupt of GPIO.
     If VBUS became Low, pch_udc handles 'disconnect'.
     After VBUS became High, a pull improves D+, and pch_udc
     handles 'connect'.
    
    [ balbi@ti.com : make it actually compile ]
    
    Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
    Signed-off-by: Felipe Balbi <balbi@ti.com>
---------------

breaks the sparc builds in next:

http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/

Thanks,
Paul.

Re: "usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

[Just cc'ing Greg as this commit is in the usb tree]

On Fri, 2 Mar 2012 17:01:16 -0500 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>
> This commit:
> 
> ---------------
> commit 637b78eb31e0b167ed913f1750bb645dfeda38f0
> Author: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> Date:   Fri Feb 3 16:14:18 2012 +0900
> 
>     usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt
>     
>     Problem:
>      pch_udc continues operation even if VBUS becomes Low.
>      pch_udc performs D+ pulling up before VBUS becomes High.
>      USB device should be controlled according to VBUS state.
>     
>     Root cause:
>      The current pch_udc is not always monitoring VBUS.
>     
>     Solution:
>      The change of VBUS is detected using an interrupt of GPIO.
>      If VBUS became Low, pch_udc handles 'disconnect'.
>      After VBUS became High, a pull improves D+, and pch_udc
>      handles 'connect'.
>     
>     [ balbi@ti.com : make it actually compile ]
>     
>     Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
>     Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---------------
> 
> breaks the sparc builds in next:
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
> http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/
> 
> Thanks,
> Paul.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: "usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc

[Greg KH]

On Sat, Mar 03, 2012 at 10:41:42AM +1100, Stephen Rothwell wrote:
> [Just cc'ing Greg as this commit is in the usb tree]
> 
> On Fri, 2 Mar 2012 17:01:16 -0500 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> >
> > This commit:
> > 
> > ---------------
> > commit 637b78eb31e0b167ed913f1750bb645dfeda38f0
> > Author: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> > Date:   Fri Feb 3 16:14:18 2012 +0900
> > 
> >     usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt
> >     
> >     Problem:
> >      pch_udc continues operation even if VBUS becomes Low.
> >      pch_udc performs D+ pulling up before VBUS becomes High.
> >      USB device should be controlled according to VBUS state.
> >     
> >     Root cause:
> >      The current pch_udc is not always monitoring VBUS.
> >     
> >     Solution:
> >      The change of VBUS is detected using an interrupt of GPIO.
> >      If VBUS became Low, pch_udc handles 'disconnect'.
> >      After VBUS became High, a pull improves D+, and pch_udc
> >      handles 'connect'.
> >     
> >     [ balbi@ti.com : make it actually compile ]
> >     
> >     Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> >     Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---------------
> > 
> > breaks the sparc builds in next:
> > 
> > http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
> > http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/

Ick, not good.

Tomoya, can you please send me a patch to fix this?  Felipe is off-line
for a few days and can't do this himself.


greg k-h

Re: "usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc

[Tomoya MORINAGA]

Hi Greg

Sorry, for inconvenience.
I'll re-submit ASAP.

thanks

-- 
ROHM Co., Ltd.
tomoya

2012年3月6日1:43 Greg KH <gregkh@linuxfoundation.org>:
> On Sat, Mar 03, 2012 at 10:41:42AM +1100, Stephen Rothwell wrote:
>> [Just cc'ing Greg as this commit is in the usb tree]
>>
>> On Fri, 2 Mar 2012 17:01:16 -0500 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>> >
>> > This commit:
>> >
>> > ---------------
>> > commit 637b78eb31e0b167ed913f1750bb645dfeda38f0
>> > Author: Tomoya MORINAGA <tomoya.rohm@gmail.com>
>> > Date:   Fri Feb 3 16:14:18 2012 +0900
>> >
>> >     usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt
>> >
>> >     Problem:
>> >      pch_udc continues operation even if VBUS becomes Low.
>> >      pch_udc performs D+ pulling up before VBUS becomes High.
>> >      USB device should be controlled according to VBUS state.
>> >
>> >     Root cause:
>> >      The current pch_udc is not always monitoring VBUS.
>> >
>> >     Solution:
>> >      The change of VBUS is detected using an interrupt of GPIO.
>> >      If VBUS became Low, pch_udc handles 'disconnect'.
>> >      After VBUS became High, a pull improves D+, and pch_udc
>> >      handles 'connect'.
>> >
>> >     [ balbi@ti.com : make it actually compile ]
>> >
>> >     Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
>> >     Signed-off-by: Felipe Balbi <balbi@ti.com>
>> > ---------------
>> >
>> > breaks the sparc builds in next:
>> >
>> > http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
>> > http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/
>
> Ick, not good.
>
> Tomoya, can you please send me a patch to fix this?  Felipe is off-line
> for a few days and can't do this himself.
>
>
> greg k-h

[PATCH][linux-next] usb/gadget/pch_udc: Fix compile error

[Tomoya MORINAGA]

Though I've tested this patch,
http://marc.info/?l=linux-usb&m=132825305710285&w=2,
I've received the following reports.
http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/

So, I added header file for these symbols.
Using this patch, this compile error must be disappeared.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
---
 drivers/usb/gadget/pch_udc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
index 350dbcd..6530706 100644
--- a/drivers/usb/gadget/pch_udc.c
+++ b/drivers/usb/gadget/pch_udc.c
@@ -16,6 +16,7 @@
 #include <linux/usb/ch9.h>
 #include <linux/usb/gadget.h>
 #include <linux/gpio.h>
+#include <linux/irq.h>
 
 /* GPIO port for VBUS detecting */
 static int vbus_gpio_port = -1;		/* GPIO port number (-1:Not used) */
-- 
1.7.7.6

[PATCH][linux-next][RESEND] usb/gadget/pch_udc: Fix compile error

[Tomoya MORINAGA]

Greg's e-mail address was old. So, I resend it.

Though I've tested this patch,
http://marc.info/?l=linux-usb&m=132825305710285&w=2,
I've received the following reports.
http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/

So, I added header file for these symbols.
Using this patch, this compile error must be disappeared.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
---
 drivers/usb/gadget/pch_udc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
index 350dbcd..6530706 100644
--- a/drivers/usb/gadget/pch_udc.c
+++ b/drivers/usb/gadget/pch_udc.c
@@ -16,6 +16,7 @@
 #include <linux/usb/ch9.h>
 #include <linux/usb/gadget.h>
 #include <linux/gpio.h>
+#include <linux/irq.h>
 
 /* GPIO port for VBUS detecting */
 static int vbus_gpio_port = -1;		/* GPIO port number (-1:Not used) */
-- 
1.7.7.6

Re: [PATCH][linux-next][RESEND] usb/gadget/pch_udc: Fix compile error

[Tomoya MORINAGA]

Hi

Add information.

My develop environment is on x86.

According to following report,
  http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
  http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/

This occurred on sparc64.

I suspect this issue ins GPIO implementation for sparc64.
Does sparc64 support GPIO interrupt ?
(Even x86, before 2.6.39, GPIO interrupt is not implemented !)

Additionally, this driver is for companion chip of Intel Atom E6xx series.
So, this driver is never used for except x86, e.g. sparc.

thanks
-- 
ROHM Co., Ltd.
tomoya

Re: [PATCH][linux-next][RESEND] usb/gadget/pch_udc: Fix compile error

[Greg Kroah-Hartman]

On Tue, Mar 06, 2012 at 03:39:37PM +0900, Tomoya MORINAGA wrote:
> Hi
> 
> Add information.
> 
> My develop environment is on x86.
> 
> According to following report,
>   http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
>   http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/
> 
> This occurred on sparc64.
> 
> I suspect this issue ins GPIO implementation for sparc64.
> Does sparc64 support GPIO interrupt ?
> (Even x86, before 2.6.39, GPIO interrupt is not implemented !)
> 
> Additionally, this driver is for companion chip of Intel Atom E6xx series.
> So, this driver is never used for except x86, e.g. sparc.

Then the Kconfig file should probably only enable it on x86 to prevent
these kinds of things :)

thanks,

greg k-h

Re: [PATCH][linux-next][RESEND] usb/gadget/pch_udc: Fix compile error

[Tomoya MORINAGA]

On Tue, Mar 6, 2012 at 11:58 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>> Additionally, this driver is for companion chip of Intel Atom E6xx series.
>> So, this driver is never used for except x86, e.g. sparc.
>
> Then the Kconfig file should probably only enable it on x86 to prevent
> these kinds of things :)

Yes, you are right.
I should have added "x86" to Kconfig.

thanks,
-- 
ROHM Co., Ltd.
tomoya