From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Enhanced hotkey handling for menuentry
Date: Sat, 03 Mar 2012 22:01:33 +0100 [thread overview]
Message-ID: <4F5286AD.1000506@gmail.com> (raw)
In-Reply-To: <4F528288.7030200@anvo-it.de>
On 03.03.2012 21:43, Andreas Vogel wrote:
> Here is a small patch which enhances the hotkey handling for menu entries.
Could you use GNU style? You miss the spaces before braces. Comments
have to be full sentences, start with uppercase and end with a dot
followed by 2 spaces.
Comment /*NOTHING*/ is not useful.
> - new static function parse_key()
> - hotkey aliases are now case insensitive
> - additional hotkey aliases
All added aliases conflict with normal function of these keys (arrows
and pages)
> - handling now<SHIFT> and<CTRL> modifiers for hotkeys
Could you change to the emacs notation? Shift flag isn't valid with
alphanumeric keys.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
next prev parent reply other threads:[~2012-03-03 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 20:43 [PATCH] Enhanced hotkey handling for menuentry Andreas Vogel
2012-03-03 21:01 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-03-03 21:30 ` Andreas Vogel
2012-03-04 12:23 ` Andreas Vogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5286AD.1000506@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.