[PATCH] Making exported variables really global

[Andreas Vogel <Andreas.Vogel@anvo-it.de>]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

Hi all,

This tiny patch makes exported variables really global. Right now
exported variables are set in the context of a submenu when running it.
But any changes to those vars are lost when leaving the submenu. This
patch sets and exports all vars in the calling context for the submenu
which are exported in the context of the submenu.

This feature is needed in order to have submenus implementing something
like setting boot options like boot params, language setttings and the
like using environment variables.

Any comments? If it's OK any chance to be included?

Andreas

[-- Attachment #2: 08-global_environ_vars.patch --]
[-- Type: text/plain, Size: 800 bytes --]

=== modified file 'grub-core/normal/context.c'
--- grub-core/normal/context.c	2012-03-01 21:43:03 +0000
+++ grub-core/normal/context.c	2012-03-04 13:51:28 +0000
@@ -126,6 +126,20 @@
 
       for (p = grub_current_context->vars[i]; p; p = q)
 	{
+	  if (p->global)
+	    {
+	      /* Set and export all global variables inside
+		 the calling/previous context.  */
+	      struct grub_env_context *tmp_context = grub_current_context;
+	      grub_current_context = grub_current_context->prev;
+	      if (grub_env_set (p->name, p->value) == GRUB_ERR_NONE)
+		{
+		  grub_env_export (p->name);
+		  grub_register_variable_hook (p->name, p->read_hook, p->write_hook);
+		}
+	      grub_current_context = tmp_context;
+	    }
+
 	  q = p->next;
           grub_free (p->name);
 	  grub_free (p->value);