From: Andreas Vogel <Andreas.Vogel@anvo-it.de>
To: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Making exported variables really global
Date: Sun, 04 Mar 2012 14:47:13 +0100 [thread overview]
Message-ID: <4F537261.3070402@anvo-it.de> (raw)
In-Reply-To: <4F536B8A.6060501@gmail.com>
Am 04.03.2012 14:18, schrieb Vladimir 'φ-coder/phcoder' Serbinenko:
> On 04.03.2012 14:08, Andreas Vogel wrote:
>> Hi all,
>>
>> This tiny patch makes exported variables really global. Right now
>> exported variables are set in the context of a submenu when running it.
>> But any changes to those vars are lost when leaving the submenu. This
>> patch sets and exports all vars in the calling context for the submenu
>> which are exported in the context of the submenu.
> We follow the bash behaviour. And the bash behaviour is exactly what
> GRUB does:
> phcoder@debian.x201.phnet:14:15:11:~/grub2/bzr/mainline$ bash
> phcoder@debian.x201.phnet:14:15:15:~/grub2/bzr/mainline$ export XYZ=x
> phcoder@debian.x201.phnet:14:15:19:~/grub2/bzr/mainline$ exit
> phcoder@debian.x201.phnet:14:15:20:~/grub2/bzr/mainline$ echo $XYZ
>
> phcoder@debian.x201.phnet:14:15:24:~/grub2/bzr/mainline$
>
I understand your point, but IMHO we do need to be able to set global
vars in submenus, that's my patch about.
Otherwise how can you use a "Settings..." submenu to configure
environment variables which are used by other menu entries for booting?
The analogy with bash is not useful here.
next prev parent reply other threads:[~2012-03-04 13:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 13:08 [PATCH] Making exported variables really global Andreas Vogel
2012-03-04 13:18 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-03-04 13:47 ` Andreas Vogel [this message]
2012-03-04 14:10 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-03-04 16:16 ` Andreas Vogel
2012-03-04 17:55 ` Andreas Vogel
2012-03-04 21:03 ` Andreas Born
2012-03-04 22:48 ` Andreas Vogel
2012-03-04 23:39 ` Andreas Born
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F537261.3070402@anvo-it.de \
--to=andreas.vogel@anvo-it.de \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.