Frozen

Frozen

[Vladimir 'φ-coder/phcoder' Serbinenko]

Hello, all. As of now trunk is officially frozen. Now the feature 
patches should be committed to experimental until 2.00 is released. 
Exceptions are still possible but need to be discussed separately. 
Following actions are allowed in trunk:
- Bugfixes as long as they are unlikely to add more bugs.
- Documentation updates.
- Adding TRANSLATORS comments. Please avoid changing strings from now on 
except if they are seriously wrong in order to ensure good translations 
for 2.00
I'm now running a battery of tests and once they are completed and I 
caught some sleep it will be uploaded to alpha.gnu.org.
Following pending patches *may* qualify for freeze exceptions:
- relocatable kernel support due to problems associated with overlaying 
EFI structures.
- EDID support for EFI. It's small, unintrusive and enhances video
- Submenus. Late arrival, seems to be unintrusive

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

Re: Frozen

[Lennart Sorensen]

On Tue, Feb 28, 2012 at 04:41:28AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Hello, all. As of now trunk is officially frozen. Now the feature
> patches should be committed to experimental until 2.00 is released.
> Exceptions are still possible but need to be discussed separately.
> Following actions are allowed in trunk:
> - Bugfixes as long as they are unlikely to add more bugs.
> - Documentation updates.
> - Adding TRANSLATORS comments. Please avoid changing strings from
> now on except if they are seriously wrong in order to ensure good
> translations for 2.00
> I'm now running a battery of tests and once they are completed and I
> caught some sleep it will be uploaded to alpha.gnu.org.
> Following pending patches *may* qualify for freeze exceptions:
> - relocatable kernel support due to problems associated with
> overlaying EFI structures.
> - EDID support for EFI. It's small, unintrusive and enhances video
> - Submenus. Late arrival, seems to be unintrusive

I should do another powerpc build of trunk to make sure we got all the
warnings now.

-- 
Len Sorensen

Re: Frozen

[Lennart Sorensen]

On Tue, Feb 28, 2012 at 11:39:32AM -0500, Lennart Sorensen wrote:
> I should do another powerpc build of trunk to make sure we got all the
> warnings now.

gcc-4.4 -DHAVE_CONFIG_H -I. -I../../../grub-core -I..  -Wall -W -I../../../include -I../include  -DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1 -m32 -DGRUB_FILE=\"normal/charset.c\" -I. -I../../../grub-core -I.. -I../../.. -I../../../include -I../include   -I../../../grub-core/lib/posix_wrap   -Os -Wall -W -Wshadow -Wold-style-declaration -Wold-style-definition -Wpointer-arith -Wundef -Wextra -Waddress -Warray-bounds -Wattributes -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered -Wcomment -Wcoverage-mismatch -Wdeprecated -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels -Wfloat-equal -Wformat-contains-nul -Wformat-extra-args -Wformat-security -Wformat-y2k -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Winit-self -Wint-to-pointer-cast -Winvalid-pch -Wunsafe-loop-optimizations -Wlogical-op -Wmain -Wmissing-braces -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noreturn -Wmudflap -Wmultichar -Wnonnull -Woverflow -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith -Wpointer-to-int-cast -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wstrict-aliasing -Wswitch -Wsync-nand -Wtrigraphs  -Wtype-limits -Wundef -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label -Wunused-parameter -Wunused-value  -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings -Wmissing-parameter-type -Wnested-externs -Wstrict-prototypes -Wpointer-sign -g -Wredundant-decls -Wmissing-prototypes -Wmissing-declarations -fno-dwarf2-cfi-asm -fno-asynchronous-unwind-tables -m32 -fno-stack-protector -Werror -DUSE_ASCII_FAILBACK=1 -DHAVE_UNIFONT_WIDTHSPEC=1         -ffreestanding -fno-builtin -Wno-redundant-decls   -c -o normal/normal_module-charset.o `test -f 'normal/charset.c' || echo '../../../grub-core/'`normal/charset.c
cc1: warnings being treated as errors
../../../grub-core/normal/charset.c: In function 'grub_bidi_line_logical_to_visual':
../../../grub-core/normal/charset.c:636: error: cannot optimize possibly infinite loops

-- 
Len Sorensen

Re: Frozen

[Lennart Sorensen]

On Thu, Mar 01, 2012 at 01:37:10PM -0500, Lennart Sorensen wrote:
> gcc-4.4 -DHAVE_CONFIG_H -I. -I../../../grub-core -I..  -Wall -W -I../../../include -I../include  -DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1 -m32 -DGRUB_FILE=\"normal/charset.c\" -I. -I../../../grub-core -I.. -I../../.. -I../../../include -I../include   -I../../../grub-core/lib/posix_wrap   -Os -Wall -W -Wshadow -Wold-style-declaration -Wold-style-definition -Wpointer-arith -Wundef -Wextra -Waddress -Warray-bounds -Wattributes -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered -Wcomment -Wcoverage-mismatch -Wdeprecated -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels -Wfloat-equal -Wformat-contains-nul -Wformat-extra-args -Wformat-security -Wformat-y2k -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Winit-self -Wint-to-pointer-cast -Winvalid-pch -Wunsafe-loop-optimizations -Wlogical-op -Wmain -Wmissing-braces -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noreturn -W
> mudflap -Wmultichar -Wnonnull -Woverflow -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith -Wpointer-to-int-cast -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wstrict-aliasing -Wswitch -Wsync-nand -Wtrigraphs  -Wtype-limits -Wundef -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label -Wunused-parameter -Wunused-value  -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings -Wmissing-parameter-type -Wnested-externs -Wstrict-prototypes -Wpointer-sign -g -Wredundant-decls -Wmissing-prototypes -Wmissing-declarations -fno-dwarf2-cfi-asm -fno-asynchronous-unwind-tables -m32 -fno-stack-protector -Werror -DUSE_ASCII_FAILBACK=1 -DHAVE_UNIFONT_WIDTHSPEC=1         -ffreestanding -fno-builtin -Wno-redundant-decls   -c -o normal/normal_module-charset.o `test -f 'normal/charset.c' || echo '../../../grub-core/'`normal/charset.c
> cc1: warnings being treated as errors
> ../../../grub-core/normal/charset.c: In function 'grub_bidi_line_logical_to_visual':
> ../../../grub-core/normal/charset.c:636: error: cannot optimize possibly infinite loops

Would using this instead work:

for (i = k - 1; i >= 0 && (unsigned) i > line_start - 1;

After all if i already had to be >=0 then casting it to unsigned has no
harm, whereas casting line_start to signed could potentially generate
a very negative number if line_start was very big.

The compiler approves.

-- 
Len Sorensen

Re: Frozen

[Lennart Sorensen]

On Thu, Mar 01, 2012 at 02:15:17PM -0500, Lennart Sorensen wrote:
> Would using this instead work:
> 
> for (i = k - 1; i >= 0 && (unsigned) i > line_start - 1;
> 
> After all if i already had to be >=0 then casting it to unsigned has no
> harm, whereas casting line_start to signed could potentially generate
> a very negative number if line_start was very big.
> 
> The compiler approves.

After changing that, the current bzr tree (revno: 4083) builds with no
errors on powerpc using gcc (Debian 4.4.5-8) 4.4.5 from Debian Squeeze.

-- 
Len Sorensen

Re: Frozen

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 01.03.2012 20:15, Lennart Sorensen wrote:
> On Thu, Mar 01, 2012 at 01:37:10PM -0500, Lennart Sorensen wrote:
>> gcc-4.4 -DHAVE_CONFIG_H -I. -I../../../grub-core -I..  -Wall -W -I../../../include -I../include  -DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1 -m32 -DGRUB_FILE=\"normal/charset.c\" -I. -I../../../grub-core -I.. -I../../.. -I../../../include -I../include   -I../../../grub-core/lib/posix_wrap   -Os -Wall -W -Wshadow -Wold-style-declaration -Wold-style-definition -Wpointer-arith -Wundef -Wextra -Waddress -Warray-bounds -Wattributes -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered -Wcomment -Wcoverage-mismatch -Wdeprecated -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels -Wfloat-equal -Wformat-contains-nul -Wformat-extra-args -Wformat-security -Wformat-y2k -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Winit-self -Wint-to-pointer-cast -Winvalid-pch -Wunsafe-loop-optimizations -Wlogical-op -Wmain -Wmissing-braces -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noreturn -W
>> mudflap -Wmultichar -Wnonnull -Woverflow -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith -Wpointer-to-int-cast -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wstrict-aliasing -Wswitch -Wsync-nand -Wtrigraphs  -Wtype-limits -Wundef -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label -Wunused-parameter -Wunused-value  -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings -Wmissing-parameter-type -Wnested-externs -Wstrict-prototypes -Wpointer-sign -g -Wredundant-decls -Wmissing-prototypes -Wmissing-declarations -fno-dwarf2-cfi-asm -fno-asynchronous-unwind-tables -m32 -fno-stack-protector -Werror -DUSE_ASCII_FAILBACK=1 -DHAVE_UNIFONT_WIDTHSPEC=1         -ffreestanding -fno-builtin -Wno-redundant-decls   -c -o normal/normal_module-charset.o `test -f 'normal/charset.c' || echo '../../../grub-core/'`normal/charset.c
>> cc1: warnings being treated as errors
>> ../../../grub-core/normal/charset.c: In function 'grub_bidi_line_logical_to_visual':
>> ../../../grub-core/normal/charset.c:636: error: cannot optimize possibly infinite loops
> Would using this instead work:
>
> for (i = k - 1; i>= 0&&  (unsigned) i>  line_start - 1;
>
> After all if i already had to be>=0 then casting it to unsigned has no
> harm, whereas casting line_start to signed could potentially generate
> a very negative number if line_start was very big.
You forget the case line_start = 0. Please try:
-        for (i = k - 1; i > (signed) line_start - 1 && i >= 0;
+        for (i = k - 1; i >= 0 && (unsigned) i >= line_start;
> The compiler approves.
>


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

Re: Frozen

[Andreas Born]

Am 04.03.2012 13:17, schrieb Vladimir 'φ-coder/phcoder' Serbinenko:
> You forget the case line_start = 0. Please try:
> -        for (i = k - 1; i > (signed) line_start - 1 && i >= 0;
> +        for (i = k - 1; i >= 0 && (unsigned) i >= line_start; 

Fixes it here with gcc 4.5.2. But now getting:
gcc -DHAVE_CONFIG_H -I. -I..  -Wall -W -I../include -I../include  
-DGRUB_MACHINE_PCBIOS=1 -DGRUB_MACHINE=I386_PC -DGRUB_TARGET_CPU_I386=1 
-m32 -nostdinc -isystem 
/usr/lib64/gcc/x86_64-slackware-linux/4.5.2/include 
-DGRUB_FILE=\"video/bitmap_scale.c\" -I. -I. -I.. -I.. -I../include 
-I../include     -Os -Wall -W -Wshadow -Wold-style-declaration 
-Wold-style-definition -Wpointer-arith -Wundef -Wextra -Waddress 
-Warray-bounds -Wattributes -Wbuiltin-macro-redefined -Wcast-align 
-Wchar-subscripts -Wclobbered -Wcomment -Wcoverage-mismatch -Wdeprecated 
-Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero 
-Wempty-body -Wendif-labels -Wfloat-equal -Wformat-contains-nul 
-Wformat-extra-args -Wformat-security -Wformat-y2k -Wignored-qualifiers 
-Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Winit-self 
-Wint-to-pointer-cast -Winvalid-pch -Wunsafe-loop-optimizations 
-Wlogical-op -Wmain -Wmissing-braces -Wmissing-field-initializers 
-Wmissing-format-attribute -Wmissing-noreturn -Wmudflap -Wmultichar 
-Wnonnull -Woverflow -Wpacked-bitfield-compat -Wparentheses 
-Wpointer-arith -Wpointer-to-int-cast -Wreturn-type -Wsequence-point 
-Wshadow -Wsign-compare -Wstrict-aliasing -Wswitch -Wsync-nand 
-Wtrigraphs  -Wtype-limits -Wundef -Wuninitialized -Wunknown-pragmas 
-Wunused -Wunused-function -Wunused-label -Wunused-parameter 
-Wunused-value  -Wunused-variable -Wvariadic-macros 
-Wvolatile-register-var -Wwrite-strings -Wmissing-parameter-type 
-Wnested-externs -Wstrict-prototypes -Wpointer-sign -g -Wredundant-decls 
-Wmissing-prototypes -Wmissing-declarations -falign-jumps=1 
-falign-loops=1 -falign-functions=1 -mno-mmx -mno-sse -mno-sse2 
-mno-3dnow -fno-dwarf2-cfi-asm -fno-asynchronous-unwind-tables -m32 
-fno-stack-protector -mno-stack-arg-probe -Werror   -mrtd 
-mregparm=3       -ffreestanding   -MT 
video/bitmap_scale_module-bitmap_scale.o -MD -MP -MF 
video/.deps-core/bitmap_scale_module-bitmap_scale.Tpo -c -o 
video/bitmap_scale_module-bitmap_scale.o `test -f 'video/bitmap_scale.c' 
|| echo './'`video/bitmap_scale.c
distcc[1015] ERROR: compile /home/shador/.ccache/tmp/linux.tmp.nyx.927.i 
on localhost failed
cc1: warnings being treated as errors
loader/i386/linux.c: In function 'grub_cmd_linux':
loader/i386/linux.c:292:13: error: cannot optimize possibly infinite loops
make[3]: *** [loader/i386/linux_module-linux.o] Error 1

Suggestion:
-    for (; err && *align >= min_align; (*align)--)
+    for (; err && *align + 1 > min_align; (*align)--)

That's the last one I get with my version of gcc.

Re: Frozen

[Lennart Sorensen]

On Sun, Mar 04, 2012 at 01:17:29PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 01.03.2012 20:15, Lennart Sorensen wrote:
> >On Thu, Mar 01, 2012 at 01:37:10PM -0500, Lennart Sorensen wrote:
> >>gcc-4.4 -DHAVE_CONFIG_H -I. -I../../../grub-core -I..  -Wall -W -I../../../include -I../include  -DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1 -m32 -DGRUB_FILE=\"normal/charset.c\" -I. -I../../../grub-core -I.. -I../../.. -I../../../include -I../include   -I../../../grub-core/lib/posix_wrap   -Os -Wall -W -Wshadow -Wold-style-declaration -Wold-style-definition -Wpointer-arith -Wundef -Wextra -Waddress -Warray-bounds -Wattributes -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered -Wcomment -Wcoverage-mismatch -Wdeprecated -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels -Wfloat-equal -Wformat-contains-nul -Wformat-extra-args -Wformat-security -Wformat-y2k -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Winit-self -Wint-to-pointer-cast -Winvalid-pch -Wunsafe-loop-optimizations -Wlogical-op -Wmain -Wmissing-braces -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noreturn
> -W
> >>mudflap -Wmultichar -Wnonnull -Woverflow -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith -Wpointer-to-int-cast -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wstrict-aliasing -Wswitch -Wsync-nand -Wtrigraphs  -Wtype-limits -Wundef -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label -Wunused-parameter -Wunused-value  -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings -Wmissing-parameter-type -Wnested-externs -Wstrict-prototypes -Wpointer-sign -g -Wredundant-decls -Wmissing-prototypes -Wmissing-declarations -fno-dwarf2-cfi-asm -fno-asynchronous-unwind-tables -m32 -fno-stack-protector -Werror -DUSE_ASCII_FAILBACK=1 -DHAVE_UNIFONT_WIDTHSPEC=1         -ffreestanding -fno-builtin -Wno-redundant-decls   -c -o normal/normal_module-charset.o `test -f 'normal/charset.c' || echo '../../../grub-core/'`normal/charset.c
> >>cc1: warnings being treated as errors
> >>../../../grub-core/normal/charset.c: In function 'grub_bidi_line_logical_to_visual':
> >>../../../grub-core/normal/charset.c:636: error: cannot optimize possibly infinite loops
> >Would using this instead work:
> >
> >for (i = k - 1; i>= 0&&  (unsigned) i>  line_start - 1;
> >
> >After all if i already had to be>=0 then casting it to unsigned has no
> >harm, whereas casting line_start to signed could potentially generate
> >a very negative number if line_start was very big.
> You forget the case line_start = 0. Please try:
> -        for (i = k - 1; i > (signed) line_start - 1 && i >= 0;
> +        for (i = k - 1; i >= 0 && (unsigned) i >= line_start;

The compiler objects.  Back to the "error: cannot optimize possibly
infinite loops" again.

The compiler approves of:

for (i = k - 1; i >= 0 && (unsigned) i + 1 > line_start;

I guess that's because i >=0 and i < 2147483647 (since it was signed),
and i+1 hence can't overflow.

-- 
Len Sorensen