All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Get normalized paths for comparing NFS export paths
Date: Mon, 05 Mar 2012 06:55:41 -0500	[thread overview]
Message-ID: <4F54A9BD.4020702@RedHat.com> (raw)
In-Reply-To: <1330913047.14357.19.camel@lade.trondhjem.org>



On 03/04/2012 09:04 PM, Myklebust, Trond wrote:
> On Sun, 2012-03-04 at 19:03 -0500, Steve Dickson wrote:
>>
>> On 03/04/2012 06:26 PM, Myklebust, Trond wrote:
>>> On Sun, 2012-03-04 at 17:58 -0500, Steve Dickson wrote:
>>>> So to restate... this normalizing of the path names (aka striping 
>>>> multiple slashes or added the leading slash) only need to occur on 
>>>> (successful) v4 mounts... Although the former would not be an 
>>>> problem with v2/v3 mounts but its not needed....
>>>
>>> Normalising for v4 only is OK as far as I'm concerned, but as an
>>> alternative: is there any reason why you can't just grab the path from
>>> '/proc/mounts'?
>>>
>> Well in some distros /etc/mtab is symbolically linked to /proc/mounts
>> so this problem does not exist. But from what I've been told not
>> all distros do that. Plus being backward compatible with older 
>> release of distro is a good thing... IMHO...
> 
> Which is why I'm asking you if you can't copy from /proc/mounts. Distros
> which already have a symlink betweek /etc/mtab and /proc/mounts don't
> have any of these problems...
> 
Personally I think it simpler to just normalize the paths before 
writing it to the mtab verses open up and searching /proc/mounts
esp on client where there is large amount of mounts...  

steved.

  parent reply	other threads:[~2012-03-05 11:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-03  1:42 [PATCH] Check for beginning '/' in the mount path Malahal Naineni
2012-02-03 11:15 ` Boaz Harrosh
2012-02-03 12:16   ` NeilBrown
2012-02-03 14:29     ` Malahal Naineni
2012-02-05 11:03       ` Boaz Harrosh
2012-02-06 18:11         ` Malahal Naineni
2012-02-07 20:44         ` [PATCH] Get normalized paths for comparing NFS export paths Malahal Naineni
2012-02-16 18:09           ` Malahal Naineni
2012-03-02 19:10           ` Steve Dickson
2012-03-02 19:27             ` Malahal Naineni
2012-03-02 20:57               ` Steve Dickson
2012-03-02 22:01                 ` Malahal Naineni
2012-03-03 17:39                   ` Steve Dickson
2012-03-03 19:12                     ` Myklebust, Trond
2012-03-04 22:31                       ` Steve Dickson
2012-03-04 22:46                         ` Myklebust, Trond
2012-03-04 23:08                           ` Steve Dickson
2012-03-05  4:46                           ` Malahal Naineni
2012-03-05 12:03                             ` Steve Dickson
2012-03-04 22:58                         ` Steve Dickson
2012-03-04 23:26                           ` Myklebust, Trond
2012-03-05  0:03                             ` Steve Dickson
2012-03-05  2:04                               ` Myklebust, Trond
2012-03-05  4:53                                 ` Malahal Naineni
2012-03-05 11:55                                 ` Steve Dickson [this message]
2012-03-05 14:47                                   ` Malahal Naineni
2012-03-05 15:03                                     ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F54A9BD.4020702@RedHat.com \
    --to=steved@redhat.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.