From: Steve Dickson <SteveD@redhat.com>
To: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Get normalized paths for comparing NFS export paths
Date: Mon, 05 Mar 2012 07:03:22 -0500 [thread overview]
Message-ID: <4F54AB8A.40806@RedHat.com> (raw)
In-Reply-To: <20120305044638.GA12833@us.ibm.com>
On 03/04/2012 11:46 PM, Malahal Naineni wrote:
> Myklebust, Trond [Trond.Myklebust@netapp.com] wrote:
>> No. Please don't strip the multiple slashes either. Just leave the path
>> alone after you've separated it from the devicename.
>>
>> It is quite OK to normalize the path on the _client_ side (i.e.
>> change //mnt to /mnt or whatever) but don't touch the server side.
>
> As I understand, we can normalize and store it in /etc/mtab and
> normalization is done by the kernel for /proc/mounts. In other words,
> follow the kernel and make the /etc/mtab entries consistent with the
> kernel.
>
> In my patch, I decided to normalize at umount time when we compare the
> mtab and proc file entries.
>
> Any opinion on which one is better?
I'm thinking either before the unmount or after a successful
v4 mount...
steved.
next prev parent reply other threads:[~2012-03-05 12:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 1:42 [PATCH] Check for beginning '/' in the mount path Malahal Naineni
2012-02-03 11:15 ` Boaz Harrosh
2012-02-03 12:16 ` NeilBrown
2012-02-03 14:29 ` Malahal Naineni
2012-02-05 11:03 ` Boaz Harrosh
2012-02-06 18:11 ` Malahal Naineni
2012-02-07 20:44 ` [PATCH] Get normalized paths for comparing NFS export paths Malahal Naineni
2012-02-16 18:09 ` Malahal Naineni
2012-03-02 19:10 ` Steve Dickson
2012-03-02 19:27 ` Malahal Naineni
2012-03-02 20:57 ` Steve Dickson
2012-03-02 22:01 ` Malahal Naineni
2012-03-03 17:39 ` Steve Dickson
2012-03-03 19:12 ` Myklebust, Trond
2012-03-04 22:31 ` Steve Dickson
2012-03-04 22:46 ` Myklebust, Trond
2012-03-04 23:08 ` Steve Dickson
2012-03-05 4:46 ` Malahal Naineni
2012-03-05 12:03 ` Steve Dickson [this message]
2012-03-04 22:58 ` Steve Dickson
2012-03-04 23:26 ` Myklebust, Trond
2012-03-05 0:03 ` Steve Dickson
2012-03-05 2:04 ` Myklebust, Trond
2012-03-05 4:53 ` Malahal Naineni
2012-03-05 11:55 ` Steve Dickson
2012-03-05 14:47 ` Malahal Naineni
2012-03-05 15:03 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F54AB8A.40806@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.