From: Paolo Bonzini <pbonzini@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, laurent@vivier.eu,
anthony@codemonkey.ws
Subject: Re: [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait
Date: Tue, 06 Mar 2012 10:01:43 +0100 [thread overview]
Message-ID: <4F55D277.9000708@redhat.com> (raw)
In-Reply-To: <4F54F97D.4080504@redhat.com>
Il 05/03/2012 18:35, Avi Kivity ha scritto:
>>> > > The I/O handlers would still use the qemu mutex, no? we'd just protect
>>> > > the select() (taking the mutex from before releasing the global lock,
>>> > > and reacquiring it afterwards).
>> >
>> > Yes, that could work, but it is _really_ ugly.
> Yes, it is...
>
Let's just fix it in NBD then.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: anthony@codemonkey.ws, Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, laurent@vivier.eu
Subject: Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait
Date: Tue, 06 Mar 2012 10:01:43 +0100 [thread overview]
Message-ID: <4F55D277.9000708@redhat.com> (raw)
In-Reply-To: <4F54F97D.4080504@redhat.com>
Il 05/03/2012 18:35, Avi Kivity ha scritto:
>>> > > The I/O handlers would still use the qemu mutex, no? we'd just protect
>>> > > the select() (taking the mutex from before releasing the global lock,
>>> > > and reacquiring it afterwards).
>> >
>> > Yes, that could work, but it is _really_ ugly.
> Yes, it is...
>
Let's just fix it in NBD then.
Paolo
next prev parent reply other threads:[~2012-03-06 9:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 8:34 [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait Paolo Bonzini
2012-03-05 8:34 ` [Qemu-devel] " Paolo Bonzini
2012-03-05 9:07 ` Jan Kiszka
2012-03-05 9:07 ` [Qemu-devel] " Jan Kiszka
2012-03-05 9:25 ` Paolo Bonzini
2012-03-05 9:25 ` [Qemu-devel] " Paolo Bonzini
2012-03-05 14:24 ` Avi Kivity
2012-03-05 14:24 ` [Qemu-devel] " Avi Kivity
2012-03-05 14:30 ` Paolo Bonzini
2012-03-05 14:30 ` [Qemu-devel] " Paolo Bonzini
2012-03-05 15:14 ` Avi Kivity
2012-03-05 15:14 ` [Qemu-devel] " Avi Kivity
2012-03-05 16:14 ` Paolo Bonzini
2012-03-05 16:14 ` [Qemu-devel] " Paolo Bonzini
2012-03-05 17:35 ` Avi Kivity
2012-03-05 17:35 ` [Qemu-devel] " Avi Kivity
2012-03-06 9:01 ` Paolo Bonzini [this message]
2012-03-06 9:01 ` Paolo Bonzini
2012-03-05 14:30 ` Jan Kiszka
2012-03-05 14:30 ` [Qemu-devel] " Jan Kiszka
2012-03-05 17:39 ` Avi Kivity
2012-03-05 17:39 ` [Qemu-devel] " Avi Kivity
2012-03-05 17:55 ` Jan Kiszka
2012-03-05 17:55 ` [Qemu-devel] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F55D277.9000708@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.