From: Kukjin Kim <kgene.kim@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [PATCH 2/3] ARM: Exynos: fix SDHCI device names in regulator definitions
Date: Tue, 06 Mar 2012 02:06:28 -0800 [thread overview]
Message-ID: <4F55E1A4.5050909@samsung.com> (raw)
In-Reply-To: <1330591221-31458-3-git-send-email-m.szyprowski@samsung.com>
On 03/01/12 00:40, Marek Szyprowski wrote:
> Patch 189eb7407 "ARM: EXYNOS: use 'exynos4-sdhci' as device name for sdhci
> controllers" changed the names of the SDHCI devices, but the author forgot
> to update the definitions for the regulator subsystem. This patch fixes
> this issue.
>
> Signed-off-by: Marek Szyprowski<m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> ---
> arch/arm/mach-exynos/mach-nuri.c | 4 ++--
> arch/arm/mach-exynos/mach-universal_c210.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c
> index 8c0479f..dd26581 100644
> --- a/arch/arm/mach-exynos/mach-nuri.c
> +++ b/arch/arm/mach-exynos/mach-nuri.c
> @@ -117,7 +117,7 @@ static struct s3c_sdhci_platdata nuri_hsmmc0_data __initdata = {
> };
>
> static struct regulator_consumer_supply emmc_supplies[] = {
> - REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"),
> + REGULATOR_SUPPLY("vmmc", "exynos4-sdhci.0"),
> REGULATOR_SUPPLY("vmmc", "dw_mmc"),
> };
>
> @@ -417,7 +417,7 @@ static struct regulator_consumer_supply __initdata max8997_ldo12_[] = {
> REGULATOR_SUPPLY("vddio", "6-003c"), /* HDC802 */
> };
> static struct regulator_consumer_supply __initdata max8997_ldo13_[] = {
> - REGULATOR_SUPPLY("vmmc", "s3c-sdhci.2"), /* TFLASH */
> + REGULATOR_SUPPLY("vmmc", "exynos4-sdhci.2"), /* TFLASH */
> };
> static struct regulator_consumer_supply __initdata max8997_ldo14_[] = {
> REGULATOR_SUPPLY("inmotor", "max8997-haptic"),
> diff --git a/arch/arm/mach-exynos/mach-universal_c210.c b/arch/arm/mach-exynos/mach-universal_c210.c
> index 908624c..7cd738c 100644
> --- a/arch/arm/mach-exynos/mach-universal_c210.c
> +++ b/arch/arm/mach-exynos/mach-universal_c210.c
> @@ -750,7 +750,7 @@ static struct s3c_sdhci_platdata universal_hsmmc0_data __initdata = {
> };
>
> static struct regulator_consumer_supply mmc0_supplies[] = {
> - REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"),
> + REGULATOR_SUPPLY("vmmc", "exynos4-sdhci.0"),
> };
>
> static struct regulator_init_data mmc0_fixed_voltage_init_data = {
(Cc'ed Jaehoon Chung)
Oops, I looked at same patch from Jaehoon Chung just now and it could
be. However, including same Signed-off-by from Kyungmin Park, it seems
wrong. What's happened in your side?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-03-06 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 8:40 [PATCH 0/3] Universal C210 and NURI board fixes Marek Szyprowski
2012-03-01 8:40 ` [PATCH 1/3] ARM: Exynos: fix SDHCI caps for UniversalC210 and NURI boards Marek Szyprowski
2012-03-06 10:15 ` Kukjin Kim
2012-03-06 10:31 ` Kukjin Kim
2012-03-01 8:40 ` [PATCH 2/3] ARM: Exynos: fix SDHCI device names in regulator definitions Marek Szyprowski
2012-03-06 10:06 ` Kukjin Kim [this message]
2012-03-06 10:13 ` Kyungmin Park
2012-03-06 10:20 ` Kukjin Kim
2012-03-06 11:02 ` Kyungmin Park
2012-03-01 8:40 ` [PATCH 3/3] ARM: Exynos: fix touchscreen IRQ setup on Universal C210 board Marek Szyprowski
2012-03-06 10:08 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F55E1A4.5050909@samsung.com \
--to=kgene.kim@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.