Re: [PATCH 1/3] ARM: Exynos: fix SDHCI caps for UniversalC210 and NURI boards

[Kukjin Kim <kgene.kim@samsung.com>]

On 03/06/12 02:15, Kukjin Kim wrote:
> On 03/01/12 00:40, Marek Szyprowski wrote:
>> Add a new quirk (introduced in 6e8201f57c935 "mmc: core: add the
>> capability
>> for broken voltage" to indicate that MMC core should ignore voltage
>> change
>> errors reported by the regulators core. This is required to get SDHCI
>> working on these boards again after commit ceb6143b2df81c ("mmc: sdhci:
>> fix vmmc handling").
>>
>> Signed-off-by: Marek Szyprowski<m.szyprowski@samsung.com>
>> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>> ---
>> arch/arm/mach-exynos/mach-nuri.c | 2 ++
>> arch/arm/mach-exynos/mach-universal_c210.c | 1 +
>> 2 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/mach-nuri.c
>> b/arch/arm/mach-exynos/mach-nuri.c
>> index a6b9162..8c0479f 100644
>> --- a/arch/arm/mach-exynos/mach-nuri.c
>> +++ b/arch/arm/mach-exynos/mach-nuri.c
>> @@ -112,6 +112,7 @@ static struct s3c_sdhci_platdata nuri_hsmmc0_data
>> __initdata = {
>> .host_caps = (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA |
>> MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED |
>> MMC_CAP_DISABLE | MMC_CAP_ERASE),
>> + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE,
>> .cd_type = S3C_SDHCI_CD_PERMANENT,
>> };
>>
>> @@ -151,6 +152,7 @@ static struct s3c_sdhci_platdata nuri_hsmmc2_data
>> __initdata = {
>> .host_caps = MMC_CAP_4_BIT_DATA |
>> MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED |
>> MMC_CAP_DISABLE,
>> + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE,
>> .ext_cd_gpio = EXYNOS4_GPX3(3), /* XEINT_27 */
>> .ext_cd_gpio_invert = 1,
>> .cd_type = S3C_SDHCI_CD_GPIO,
>> diff --git a/arch/arm/mach-exynos/mach-universal_c210.c
>> b/arch/arm/mach-exynos/mach-universal_c210.c
>> index 6017a21..908624c 100644
>> --- a/arch/arm/mach-exynos/mach-universal_c210.c
>> +++ b/arch/arm/mach-exynos/mach-universal_c210.c
>> @@ -745,6 +745,7 @@ static struct s3c_sdhci_platdata
>> universal_hsmmc0_data __initdata = {
>> .host_caps = (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA |
>> MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED |
>> MMC_CAP_DISABLE),
>> + .host_caps2 = MMC_CAP2_BROKEN_VOLTAGE,
>> .cd_type = S3C_SDHCI_CD_PERMANENT,
>> };
>>
>
> Hi Marek,
>
> If possible, please adding cover letter for patch set(series), I think

Just kindly ignore above. I found your cover letter :(

> these are just independent patches though. Anyway, will apply this.
>

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.