* [meta-oe][PATCH v2] udev: consolekit package requires x11
@ 2012-03-05 22:35 Andreas Oberritter
2012-03-06 8:54 ` Koen Kooi
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Oberritter @ 2012-03-05 22:35 UTC (permalink / raw)
To: openembedded-devel
* consolekit fails to build without x11, so drop the
runtime dependency on consolekit if x11 is unavailable.
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
---
v1->v2: Instead of removing the package, drop the runtime
dependency on consolekit.
meta-oe/recipes-core/udev/udev_173.bb | 2 +-
meta-oe/recipes-core/udev/udev_175.bb | 2 +-
meta-oe/recipes-core/udev/udev_181.bb | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta-oe/recipes-core/udev/udev_173.bb b/meta-oe/recipes-core/udev/udev_173.bb
index e4e634a..a111f11 100644
--- a/meta-oe/recipes-core/udev/udev_173.bb
+++ b/meta-oe/recipes-core/udev/udev_173.bb
@@ -81,7 +81,7 @@ FILES_${PN} += "/lib/udev*"
FILES_${PN}-dbg += "/lib/udev/.debug"
FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
-RDEPENDS_${PN}-consolekit += "consolekit"
+RDEPENDS_${PN}-consolekit += "${@base_contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)}"
do_install () {
install -d ${D}${usrsbindir} \
diff --git a/meta-oe/recipes-core/udev/udev_175.bb b/meta-oe/recipes-core/udev/udev_175.bb
index b6484d9..114dbe9 100644
--- a/meta-oe/recipes-core/udev/udev_175.bb
+++ b/meta-oe/recipes-core/udev/udev_175.bb
@@ -77,7 +77,7 @@ FILES_${PN} += "/lib/udev*"
FILES_${PN}-dbg += "/lib/udev/.debug"
FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
-RDEPENDS_${PN}-consolekit += "consolekit"
+RDEPENDS_${PN}-consolekit += "${@base_contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)}"
do_install () {
install -d ${D}${usrsbindir} \
diff --git a/meta-oe/recipes-core/udev/udev_181.bb b/meta-oe/recipes-core/udev/udev_181.bb
index 1e0a02a..5e27706 100644
--- a/meta-oe/recipes-core/udev/udev_181.bb
+++ b/meta-oe/recipes-core/udev/udev_181.bb
@@ -73,7 +73,7 @@ FILES_${PN} += "/lib/udev*"
FILES_${PN}-dbg += "/lib/udev/.debug"
FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
-RDEPENDS_${PN}-consolekit += "consolekit"
+RDEPENDS_${PN}-consolekit += "${@base_contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)}"
FILES_udev-utils = "${bindir}/udevadm"
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [meta-oe][PATCH v2] udev: consolekit package requires x11
2012-03-05 22:35 [meta-oe][PATCH v2] udev: consolekit package requires x11 Andreas Oberritter
@ 2012-03-06 8:54 ` Koen Kooi
2012-03-06 12:26 ` Andreas Oberritter
0 siblings, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2012-03-06 8:54 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 05-03-12 23:35, Andreas Oberritter schreef:
> * consolekit fails to build without x11, so drop the runtime dependency
> on consolekit if x11 is unavailable.
>
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org> --- v1->v2:
> Instead of removing the package, drop the runtime dependency on
> consolekit.
It's only missing a PR bump now :)
regards,
Koen
>
> meta-oe/recipes-core/udev/udev_173.bb | 2 +-
> meta-oe/recipes-core/udev/udev_175.bb | 2 +-
> meta-oe/recipes-core/udev/udev_181.bb | 2 +- 3 files changed, 3
> insertions(+), 3 deletions(-)
>
> diff --git a/meta-oe/recipes-core/udev/udev_173.bb
> b/meta-oe/recipes-core/udev/udev_173.bb index e4e634a..a111f11 100644 ---
> a/meta-oe/recipes-core/udev/udev_173.bb +++
> b/meta-oe/recipes-core/udev/udev_173.bb @@ -81,7 +81,7 @@ FILES_${PN} +=
> "/lib/udev*" FILES_${PN}-dbg += "/lib/udev/.debug"
>
> FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
> -RDEPENDS_${PN}-consolekit += "consolekit" +RDEPENDS_${PN}-consolekit +=
> "${@base_contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)}"
>
> do_install () { install -d ${D}${usrsbindir} \ diff --git
> a/meta-oe/recipes-core/udev/udev_175.bb
> b/meta-oe/recipes-core/udev/udev_175.bb index b6484d9..114dbe9 100644 ---
> a/meta-oe/recipes-core/udev/udev_175.bb +++
> b/meta-oe/recipes-core/udev/udev_175.bb @@ -77,7 +77,7 @@ FILES_${PN} +=
> "/lib/udev*" FILES_${PN}-dbg += "/lib/udev/.debug"
>
> FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
> -RDEPENDS_${PN}-consolekit += "consolekit" +RDEPENDS_${PN}-consolekit +=
> "${@base_contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)}"
>
> do_install () { install -d ${D}${usrsbindir} \ diff --git
> a/meta-oe/recipes-core/udev/udev_181.bb
> b/meta-oe/recipes-core/udev/udev_181.bb index 1e0a02a..5e27706 100644 ---
> a/meta-oe/recipes-core/udev/udev_181.bb +++
> b/meta-oe/recipes-core/udev/udev_181.bb @@ -73,7 +73,7 @@ FILES_${PN} +=
> "/lib/udev*" FILES_${PN}-dbg += "/lib/udev/.debug"
>
> FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
> -RDEPENDS_${PN}-consolekit += "consolekit" +RDEPENDS_${PN}-consolekit +=
> "${@base_contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)}"
>
> FILES_udev-utils = "${bindir}/udevadm"
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org
iEYEARECAAYFAk9V0N8ACgkQMkyGM64RGpEd0gCcC49CpgTooJffNtAtfnDqUJhG
AzYAnA3AWyRgf+wGGXvHQeYIGlOjvHWM
=Zt3c
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [meta-oe][PATCH v2] udev: consolekit package requires x11
2012-03-06 8:54 ` Koen Kooi
@ 2012-03-06 12:26 ` Andreas Oberritter
2012-03-06 13:01 ` Otavio Salvador
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Oberritter @ 2012-03-06 12:26 UTC (permalink / raw)
To: openembedded-devel
On 06.03.2012 09:54, Koen Kooi wrote:
> Op 05-03-12 23:35, Andreas Oberritter schreef:
>> * consolekit fails to build without x11, so drop the runtime dependency
>> on consolekit if x11 is unavailable.
>
>> Signed-off-by: Andreas Oberritter <obi@opendreambox.org> --- v1->v2:
>> Instead of removing the package, drop the runtime dependency on
>> consolekit.
>
> It's only missing a PR bump now :)
I don't thinks so, because with x11 nothing changes and without x11 udev
couldn't be built before (this is what the patch addresses).
Albeit, I'm going to send a patch with bumped PRs.
Regards,
Andreas
>
> regards,
>
> Koen
>
>
>
>> meta-oe/recipes-core/udev/udev_173.bb | 2 +-
>> meta-oe/recipes-core/udev/udev_175.bb | 2 +-
>> meta-oe/recipes-core/udev/udev_181.bb | 2 +- 3 files changed, 3
>> insertions(+), 3 deletions(-)
>
>> diff --git a/meta-oe/recipes-core/udev/udev_173.bb
>> b/meta-oe/recipes-core/udev/udev_173.bb index e4e634a..a111f11 100644 ---
>> a/meta-oe/recipes-core/udev/udev_173.bb +++
>> b/meta-oe/recipes-core/udev/udev_173.bb @@ -81,7 +81,7 @@ FILES_${PN} +=
>> "/lib/udev*" FILES_${PN}-dbg += "/lib/udev/.debug"
>
>> FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
>> -RDEPENDS_${PN}-consolekit += "consolekit" +RDEPENDS_${PN}-consolekit +=
>> "${@base_contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)}"
>
>> do_install () { install -d ${D}${usrsbindir} \ diff --git
>> a/meta-oe/recipes-core/udev/udev_175.bb
>> b/meta-oe/recipes-core/udev/udev_175.bb index b6484d9..114dbe9 100644 ---
>> a/meta-oe/recipes-core/udev/udev_175.bb +++
>> b/meta-oe/recipes-core/udev/udev_175.bb @@ -77,7 +77,7 @@ FILES_${PN} +=
>> "/lib/udev*" FILES_${PN}-dbg += "/lib/udev/.debug"
>
>> FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
>> -RDEPENDS_${PN}-consolekit += "consolekit" +RDEPENDS_${PN}-consolekit +=
>> "${@base_contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)}"
>
>> do_install () { install -d ${D}${usrsbindir} \ diff --git
>> a/meta-oe/recipes-core/udev/udev_181.bb
>> b/meta-oe/recipes-core/udev/udev_181.bb index 1e0a02a..5e27706 100644 ---
>> a/meta-oe/recipes-core/udev/udev_181.bb +++
>> b/meta-oe/recipes-core/udev/udev_181.bb @@ -73,7 +73,7 @@ FILES_${PN} +=
>> "/lib/udev*" FILES_${PN}-dbg += "/lib/udev/.debug"
>
>> FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
>> -RDEPENDS_${PN}-consolekit += "consolekit" +RDEPENDS_${PN}-consolekit +=
>> "${@base_contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)}"
>
>> FILES_udev-utils = "${bindir}/udevadm"
>
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [meta-oe][PATCH v2] udev: consolekit package requires x11
2012-03-06 12:26 ` Andreas Oberritter
@ 2012-03-06 13:01 ` Otavio Salvador
2012-03-06 13:20 ` Andreas Oberritter
0 siblings, 1 reply; 6+ messages in thread
From: Otavio Salvador @ 2012-03-06 13:01 UTC (permalink / raw)
To: openembedded-devel
On Tue, Mar 6, 2012 at 09:26, Andreas Oberritter <obi@opendreambox.org> wrote:
> I don't thinks so, because with x11 nothing changes and without x11 udev
> couldn't be built before (this is what the patch addresses).
>
> Albeit, I'm going to send a patch with bumped PRs.
I think it is always safe to bump PR so it can trigger, if it is the
case, a regression as soon as possible otherwise a subtle change chan
break stuff and being unnoticed for loooong time.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH v2] udev: consolekit package requires x11
2012-03-06 13:01 ` Otavio Salvador
@ 2012-03-06 13:20 ` Andreas Oberritter
2012-03-06 14:14 ` Otavio Salvador
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Oberritter @ 2012-03-06 13:20 UTC (permalink / raw)
To: openembedded-devel
On 06.03.2012 14:01, Otavio Salvador wrote:
> On Tue, Mar 6, 2012 at 09:26, Andreas Oberritter <obi@opendreambox.org> wrote:
>> I don't thinks so, because with x11 nothing changes and without x11 udev
>> couldn't be built before (this is what the patch addresses).
>>
>> Albeit, I'm going to send a patch with bumped PRs.
>
> I think it is always safe to bump PR so it can trigger, if it is the
> case, a regression as soon as possible otherwise a subtle change chan
> break stuff and being unnoticed for loooong time.
Well, I don't share your opinion, but I guess it would save quite some
of my time submitting patches if I just blindly bumped every PR, no
matter whether the patch changes existing packages or not.
AFAIR, modified content of packages was the main criterion for PR bumps
in OE-classic.
Regards,
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-06 14:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-05 22:35 [meta-oe][PATCH v2] udev: consolekit package requires x11 Andreas Oberritter
2012-03-06 8:54 ` Koen Kooi
2012-03-06 12:26 ` Andreas Oberritter
2012-03-06 13:01 ` Otavio Salvador
2012-03-06 13:20 ` Andreas Oberritter
2012-03-06 14:14 ` Otavio Salvador
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.