* [PATCH] pinctrl: include machine header to core.h @ 2012-03-06 12:55 ` Linus Walleij 0 siblings, 0 replies; 8+ messages in thread From: Linus Walleij @ 2012-03-06 12:55 UTC (permalink / raw) To: linux-arm-kernel From: Linus Walleij <linus.walleij@linaro.org> struct pinctrl_setting contains an enum pinctrl_map_type field, so we need to include machine.h. Also fix kerneldoc to indicate that the pinctrl_setting is about both muxing and other config. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/pinctrl/core.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h index 5b3ff13..42fb0ea 100644 --- a/drivers/pinctrl/core.h +++ b/drivers/pinctrl/core.h @@ -12,6 +12,7 @@ #include <linux/mutex.h> #include <linux/radix-tree.h> #include <linux/pinctrl/pinconf.h> +#include <linux/pinctrl/machine.h> struct pinctrl_gpio_range; -- 1.7.8 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] pinctrl: include machine header to core.h @ 2012-03-06 12:55 ` Linus Walleij 0 siblings, 0 replies; 8+ messages in thread From: Linus Walleij @ 2012-03-06 12:55 UTC (permalink / raw) To: linux-kernel, linux-arm-kernel Cc: Stephen Warren, Shawn Guo, Thomas Abraham, Dong Aisheng, Rajendra Nayak, Haojian Zhuang, Linus Walleij From: Linus Walleij <linus.walleij@linaro.org> struct pinctrl_setting contains an enum pinctrl_map_type field, so we need to include machine.h. Also fix kerneldoc to indicate that the pinctrl_setting is about both muxing and other config. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/pinctrl/core.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h index 5b3ff13..42fb0ea 100644 --- a/drivers/pinctrl/core.h +++ b/drivers/pinctrl/core.h @@ -12,6 +12,7 @@ #include <linux/mutex.h> #include <linux/radix-tree.h> #include <linux/pinctrl/pinconf.h> +#include <linux/pinctrl/machine.h> struct pinctrl_gpio_range; -- 1.7.8 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] pinctrl: include machine header to core.h 2012-03-06 12:55 ` Linus Walleij @ 2012-03-06 17:28 ` Stephen Warren -1 siblings, 0 replies; 8+ messages in thread From: Stephen Warren @ 2012-03-06 17:28 UTC (permalink / raw) To: linux-arm-kernel On 03/06/2012 05:55 AM, Linus Walleij wrote: > From: Linus Walleij <linus.walleij@linaro.org> > > struct pinctrl_setting contains an enum pinctrl_map_type > field, so we need to include machine.h. Also fix kerneldoc > to indicate that the pinctrl_setting is about both muxing > and other config. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Stephen Warren <swarren@wwwdotorg.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] pinctrl: include machine header to core.h @ 2012-03-06 17:28 ` Stephen Warren 0 siblings, 0 replies; 8+ messages in thread From: Stephen Warren @ 2012-03-06 17:28 UTC (permalink / raw) To: Linus Walleij Cc: linux-kernel, linux-arm-kernel, Linus Walleij, Haojian Zhuang, Thomas Abraham, Rajendra Nayak, Dong Aisheng, Shawn Guo On 03/06/2012 05:55 AM, Linus Walleij wrote: > From: Linus Walleij <linus.walleij@linaro.org> > > struct pinctrl_setting contains an enum pinctrl_map_type > field, so we need to include machine.h. Also fix kerneldoc > to indicate that the pinctrl_setting is about both muxing > and other config. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Stephen Warren <swarren@wwwdotorg.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] pinctrl: include machine header to core.h 2012-03-06 12:55 ` Linus Walleij @ 2012-03-06 18:48 ` Sergei Shtylyov -1 siblings, 0 replies; 8+ messages in thread From: Sergei Shtylyov @ 2012-03-06 18:48 UTC (permalink / raw) To: linux-arm-kernel Hello. On 03/06/2012 03:55 PM, Linus Walleij wrote: > From: Linus Walleij<linus.walleij@linaro.org> > struct pinctrl_setting contains an enum pinctrl_map_type > field, so we need to include machine.h. Also fix kerneldoc > to indicate that the pinctrl_setting is about both muxing > and other config. I don't see where you touch kernel-doc... > Signed-off-by: Linus Walleij<linus.walleij@linaro.org> > --- > drivers/pinctrl/core.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h > index 5b3ff13..42fb0ea 100644 > --- a/drivers/pinctrl/core.h > +++ b/drivers/pinctrl/core.h > @@ -12,6 +12,7 @@ > #include<linux/mutex.h> > #include<linux/radix-tree.h> > #include<linux/pinctrl/pinconf.h> > +#include<linux/pinctrl/machine.h> > > struct pinctrl_gpio_range; WBR, Sergei ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] pinctrl: include machine header to core.h @ 2012-03-06 18:48 ` Sergei Shtylyov 0 siblings, 0 replies; 8+ messages in thread From: Sergei Shtylyov @ 2012-03-06 18:48 UTC (permalink / raw) To: Linus Walleij Cc: linux-kernel, linux-arm-kernel, Stephen Warren, Linus Walleij, Haojian Zhuang, Thomas Abraham, Rajendra Nayak, Dong Aisheng, Shawn Guo Hello. On 03/06/2012 03:55 PM, Linus Walleij wrote: > From: Linus Walleij<linus.walleij@linaro.org> > struct pinctrl_setting contains an enum pinctrl_map_type > field, so we need to include machine.h. Also fix kerneldoc > to indicate that the pinctrl_setting is about both muxing > and other config. I don't see where you touch kernel-doc... > Signed-off-by: Linus Walleij<linus.walleij@linaro.org> > --- > drivers/pinctrl/core.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h > index 5b3ff13..42fb0ea 100644 > --- a/drivers/pinctrl/core.h > +++ b/drivers/pinctrl/core.h > @@ -12,6 +12,7 @@ > #include<linux/mutex.h> > #include<linux/radix-tree.h> > #include<linux/pinctrl/pinconf.h> > +#include<linux/pinctrl/machine.h> > > struct pinctrl_gpio_range; WBR, Sergei ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] pinctrl: include machine header to core.h 2012-03-06 18:48 ` Sergei Shtylyov @ 2012-03-06 22:25 ` Linus Walleij -1 siblings, 0 replies; 8+ messages in thread From: Linus Walleij @ 2012-03-06 22:25 UTC (permalink / raw) To: linux-arm-kernel On Tue, Mar 6, 2012 at 7:48 PM, Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote: > ? I don't see where you touch kernel-doc... Bah, missed to git add it. Here is the new patch: >From 872acc322c74bb06b7ceb61fe93314e2da32362c Mon Sep 17 00:00:00 2001 From: Linus Walleij <linus.walleij@linaro.org> Date: Tue, 6 Mar 2012 13:52:22 +0100 Subject: [PATCH] pinctrl: include machine header to core.h struct pinctrl_setting contains an enum pinctrl_map_type field, so we need to include machine.h. Also fix kerneldoc to indicate that the pinctrl_setting is about both muxing and other config. Acked-by: Stephen Warren <swarren@wwwdotorg.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/pinctrl/core.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h index 5b3ff13..efbfb62 100644 --- a/drivers/pinctrl/core.h +++ b/drivers/pinctrl/core.h @@ -12,6 +12,7 @@ #include <linux/mutex.h> #include <linux/radix-tree.h> #include <linux/pinctrl/pinconf.h> +#include <linux/pinctrl/machine.h> struct pinctrl_gpio_range; @@ -96,7 +97,7 @@ struct pinctrl_setting_configs { }; /** - * struct pinctrl_setting - an individual mux setting + * struct pinctrl_setting - an individual mux or config setting * @node: list node for struct pinctrl_settings's @settings field * @type: the type of setting * @pctldev: pin control device handling to be programmed -- 1.7.8 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] pinctrl: include machine header to core.h @ 2012-03-06 22:25 ` Linus Walleij 0 siblings, 0 replies; 8+ messages in thread From: Linus Walleij @ 2012-03-06 22:25 UTC (permalink / raw) To: Sergei Shtylyov Cc: Linus Walleij, linux-kernel, linux-arm-kernel, Stephen Warren, Haojian Zhuang, Thomas Abraham, Rajendra Nayak, Dong Aisheng, Shawn Guo On Tue, Mar 6, 2012 at 7:48 PM, Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote: > I don't see where you touch kernel-doc... Bah, missed to git add it. Here is the new patch: >From 872acc322c74bb06b7ceb61fe93314e2da32362c Mon Sep 17 00:00:00 2001 From: Linus Walleij <linus.walleij@linaro.org> Date: Tue, 6 Mar 2012 13:52:22 +0100 Subject: [PATCH] pinctrl: include machine header to core.h struct pinctrl_setting contains an enum pinctrl_map_type field, so we need to include machine.h. Also fix kerneldoc to indicate that the pinctrl_setting is about both muxing and other config. Acked-by: Stephen Warren <swarren@wwwdotorg.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/pinctrl/core.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h index 5b3ff13..efbfb62 100644 --- a/drivers/pinctrl/core.h +++ b/drivers/pinctrl/core.h @@ -12,6 +12,7 @@ #include <linux/mutex.h> #include <linux/radix-tree.h> #include <linux/pinctrl/pinconf.h> +#include <linux/pinctrl/machine.h> struct pinctrl_gpio_range; @@ -96,7 +97,7 @@ struct pinctrl_setting_configs { }; /** - * struct pinctrl_setting - an individual mux setting + * struct pinctrl_setting - an individual mux or config setting * @node: list node for struct pinctrl_settings's @settings field * @type: the type of setting * @pctldev: pin control device handling to be programmed -- 1.7.8 ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-03-06 22:25 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-03-06 12:55 [PATCH] pinctrl: include machine header to core.h Linus Walleij 2012-03-06 12:55 ` Linus Walleij 2012-03-06 17:28 ` Stephen Warren 2012-03-06 17:28 ` Stephen Warren 2012-03-06 18:48 ` Sergei Shtylyov 2012-03-06 18:48 ` Sergei Shtylyov 2012-03-06 22:25 ` Linus Walleij 2012-03-06 22:25 ` Linus Walleij
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.