All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] Formfactor fix
@ 2012-03-06 23:55 Paul Eggleton
  2012-03-06 23:55 ` [PATCH 1/1] formfactor: use full path to fbset Paul Eggleton
  2012-03-12 17:40 ` [PATCH 0/1] Formfactor fix Saul Wold
  0 siblings, 2 replies; 6+ messages in thread
From: Paul Eggleton @ 2012-03-06 23:55 UTC (permalink / raw)
  To: openembedded-core

The following change since commit d7b8c247227f3cc82f92292407f548927e9fde78:

  base.bbclass: Fix PACKAGECONFIG handling when no flags are set (2012-03-05 13:03:41 -0800)

is available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib paule/formfactor
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/formfactor

Paul Eggleton (1):
  formfactor: use full path to fbset

 meta/recipes-bsp/formfactor/files/config      |    6 +++---
 meta/recipes-bsp/formfactor/formfactor_0.0.bb |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
1.7.5.4




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] formfactor: use full path to fbset
  2012-03-06 23:55 [PATCH 0/1] Formfactor fix Paul Eggleton
@ 2012-03-06 23:55 ` Paul Eggleton
  2012-03-07  2:14   ` Khem Raj
  2012-03-12 17:40 ` [PATCH 0/1] Formfactor fix Saul Wold
  1 sibling, 1 reply; 6+ messages in thread
From: Paul Eggleton @ 2012-03-06 23:55 UTC (permalink / raw)
  To: openembedded-core

When using rootless X, /usr/sbin is not in PATH and thus running "fbset"
will fail; so specify /usr/sbin/fbset instead.

Fixes [YOCTO #1986]

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/recipes-bsp/formfactor/files/config      |    6 +++---
 meta/recipes-bsp/formfactor/formfactor_0.0.bb |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-bsp/formfactor/files/config b/meta/recipes-bsp/formfactor/files/config
index e936916..a3f762a 100755
--- a/meta/recipes-bsp/formfactor/files/config
+++ b/meta/recipes-bsp/formfactor/files/config
@@ -29,15 +29,15 @@ if [ -z "$DISPLAY_ORIENTATION" ]; then
 fi
 
 if [ -z "$DISPLAY_WIDTH_PIXELS" ]; then
-    DISPLAY_WIDTH_PIXELS=`fbset | grep geometry | awk '{ print $2 }'`
+    DISPLAY_WIDTH_PIXELS=`/usr/sbin/fbset | grep geometry | awk '{ print $2 }'`
 fi
 
 if [ -z "$DISPLAY_HEIGHT_PIXELS" ]; then
-    DISPLAY_HEIGHT_PIXELS=`fbset | grep geometry | awk '{ print $3 }'`
+    DISPLAY_HEIGHT_PIXELS=`/usr/sbin/fbset | grep geometry | awk '{ print $3 }'`
 fi
 
 if [ -z "$DISPLAY_BPP" ]; then
-    DISPLAY_BPP=`fbset | grep geometry | awk '{ print $6 }'`
+    DISPLAY_BPP=`/usr/sbin/fbset | grep geometry | awk '{ print $6 }'`
 fi
 
 # 
diff --git a/meta/recipes-bsp/formfactor/formfactor_0.0.bb b/meta/recipes-bsp/formfactor/formfactor_0.0.bb
index abf20e0..31b4490 100644
--- a/meta/recipes-bsp/formfactor/formfactor_0.0.bb
+++ b/meta/recipes-bsp/formfactor/formfactor_0.0.bb
@@ -3,7 +3,7 @@ SECTION = "base"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-PR = "r19"
+PR = "r20"
 
 SRC_URI = "file://config file://machconfig"
 S = "${WORKDIR}"
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] formfactor: use full path to fbset
  2012-03-06 23:55 ` [PATCH 1/1] formfactor: use full path to fbset Paul Eggleton
@ 2012-03-07  2:14   ` Khem Raj
  2012-03-12 17:53     ` Paul Eggleton
  0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2012-03-07  2:14 UTC (permalink / raw)
  To: openembedded-core

On 03/06/2012 03:55 PM, Paul Eggleton wrote:
> When using rootless X, /usr/sbin is not in PATH and thus running "fbset"
> will fail; so specify /usr/sbin/fbset instead.
>

just curious why is /usr/sbin omitted from PATH ?



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/1] Formfactor fix
  2012-03-06 23:55 [PATCH 0/1] Formfactor fix Paul Eggleton
  2012-03-06 23:55 ` [PATCH 1/1] formfactor: use full path to fbset Paul Eggleton
@ 2012-03-12 17:40 ` Saul Wold
  1 sibling, 0 replies; 6+ messages in thread
From: Saul Wold @ 2012-03-12 17:40 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer; +Cc: Paul Eggleton

On 03/06/2012 03:55 PM, Paul Eggleton wrote:
> The following change since commit d7b8c247227f3cc82f92292407f548927e9fde78:
>
>    base.bbclass: Fix PACKAGECONFIG handling when no flags are set (2012-03-05 13:03:41 -0800)
>
> is available in the git repository at:
>    git://git.openembedded.org/openembedded-core-contrib paule/formfactor
>    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/formfactor
>
> Paul Eggleton (1):
>    formfactor: use full path to fbset
>
>   meta/recipes-bsp/formfactor/files/config      |    6 +++---
>   meta/recipes-bsp/formfactor/formfactor_0.0.bb |    2 +-
>   2 files changed, 4 insertions(+), 4 deletions(-)
>

Merged into OE-Core

Thanks
	Sau!



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] formfactor: use full path to fbset
  2012-03-07  2:14   ` Khem Raj
@ 2012-03-12 17:53     ` Paul Eggleton
  2012-03-12 19:39       ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Eggleton @ 2012-03-12 17:53 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembedded-core

On Tuesday 06 March 2012 18:14:52 Khem Raj wrote:
> On 03/06/2012 03:55 PM, Paul Eggleton wrote:
> > When using rootless X, /usr/sbin is not in PATH and thus running "fbset"
> > will fail; so specify /usr/sbin/fbset instead.
> 
> just curious why is /usr/sbin omitted from PATH ?

With the rootless X implementation we have, you're logged in as "xuser" 
instead of root. I guess our default is to not include /sbin and /usr/sbin in 
PATH for non-root users.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] formfactor: use full path to fbset
  2012-03-12 17:53     ` Paul Eggleton
@ 2012-03-12 19:39       ` Khem Raj
  0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2012-03-12 19:39 UTC (permalink / raw)
  To: Paul Eggleton; +Cc: openembedded-core

On Mon, Mar 12, 2012 at 10:53 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> I guess our default is to not include /sbin and /usr/sbin in
> PATH for non-root users.

OK true. I get it now



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-03-12 19:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-06 23:55 [PATCH 0/1] Formfactor fix Paul Eggleton
2012-03-06 23:55 ` [PATCH 1/1] formfactor: use full path to fbset Paul Eggleton
2012-03-07  2:14   ` Khem Raj
2012-03-12 17:53     ` Paul Eggleton
2012-03-12 19:39       ` Khem Raj
2012-03-12 17:40 ` [PATCH 0/1] Formfactor fix Saul Wold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.