All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: Rafal Milecki <zajec5@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	b43-dev-list <b43-dev@lists.infradead.org>
Subject: [RFC] bcma: replace ssb_sprom structure with bcma_sprom structure
Date: Wed, 7 Mar 2012 08:45:58 +0100	[thread overview]
Message-ID: <4F571236.7070608@broadcom.com> (raw)
In-Reply-To: <4F569C78.90204@hauke-m.de>

On 03/07/2012 12:23 AM, Hauke Mehrtens wrote:
> On 03/06/2012 01:26 PM, Arend van Spriel wrote:
>> BCMA shared a structure with SSB in which sprom data was stored. This
>> could have been appropriate but with upcoming srom revisions that are
>> of no interest to SSB it is better to have own definitions with BCMA.
>>
>> This patch adds support for srom revisions 8 and 9.
>
> Will sprom version 10 contain many new or different attributes so the
> struct has to be extended a lot in comparison to the changes made from
> version 8 to 9?
>

For version 10 there are only a couple of new attributes, but version 11 
is a major overhaul. Initially, I intended to have the bcma_sprom 
structure contain a union of revision specific structs, but the flat 
ssb_sprom structure made me reconsider. Looking at the current size of 
bcma_sprom I am tempted to move back to the original union solution.

>>
>> Signed-off-by: Arend van Spriel<arend@broadcom.com>
>> ---
>> The BCMA structure is based on internal specifications. Therefor the structure
>> fields are not matching the SSB sprom structure. By dropping the use of the SSB
>> sprom structure in BCMA a fair amount of work is needed in b43 driver. If it
>> helps I can provide a mapping between bcma_sprom and ssb_sprom structure members.
> The bcm47xx architecture code will not compile with this patch either.
>
> A quick look into b43 showed that it uses the boardflags flags all other
> the code and the other stuff in most cases just in some initialization
> function of the specific phy so it should be manageable to use a
> different sprom strcut for bcma. Is there any other PHY than the N-PHY
> that is used with ssb and bcma?

I believe all AXI chips are having some flavour of N-PHY (or 11ac).

Gr. AvS

WARNING: multiple messages have this Message-ID (diff)
From: "Arend van Spriel" <arend@broadcom.com>
To: "Hauke Mehrtens" <hauke@hauke-m.de>
Cc: "Rafal Milecki" <zajec5@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	b43-dev-list <b43-dev@lists.infradead.org>
Subject: Re: [RFC] bcma: replace ssb_sprom structure with bcma_sprom structure
Date: Wed, 7 Mar 2012 08:45:58 +0100	[thread overview]
Message-ID: <4F571236.7070608@broadcom.com> (raw)
In-Reply-To: <4F569C78.90204@hauke-m.de>

On 03/07/2012 12:23 AM, Hauke Mehrtens wrote:
> On 03/06/2012 01:26 PM, Arend van Spriel wrote:
>> BCMA shared a structure with SSB in which sprom data was stored. This
>> could have been appropriate but with upcoming srom revisions that are
>> of no interest to SSB it is better to have own definitions with BCMA.
>>
>> This patch adds support for srom revisions 8 and 9.
>
> Will sprom version 10 contain many new or different attributes so the
> struct has to be extended a lot in comparison to the changes made from
> version 8 to 9?
>

For version 10 there are only a couple of new attributes, but version 11 
is a major overhaul. Initially, I intended to have the bcma_sprom 
structure contain a union of revision specific structs, but the flat 
ssb_sprom structure made me reconsider. Looking at the current size of 
bcma_sprom I am tempted to move back to the original union solution.

>>
>> Signed-off-by: Arend van Spriel<arend@broadcom.com>
>> ---
>> The BCMA structure is based on internal specifications. Therefor the structure
>> fields are not matching the SSB sprom structure. By dropping the use of the SSB
>> sprom structure in BCMA a fair amount of work is needed in b43 driver. If it
>> helps I can provide a mapping between bcma_sprom and ssb_sprom structure members.
> The bcm47xx architecture code will not compile with this patch either.
>
> A quick look into b43 showed that it uses the boardflags flags all other
> the code and the other stuff in most cases just in some initialization
> function of the specific phy so it should be manageable to use a
> different sprom strcut for bcma. Is there any other PHY than the N-PHY
> that is used with ssb and bcma?

I believe all AXI chips are having some flavour of N-PHY (or 11ac).

Gr. AvS


  reply	other threads:[~2012-03-07  7:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06 12:26 [RFC] bcma: replace ssb_sprom structure with bcma_sprom structure Arend van Spriel
2012-03-06 13:27 ` Rafał Miłecki
2012-03-06 13:27   ` Rafał Miłecki
2012-03-06 13:42   ` Arend van Spriel
2012-03-06 13:42     ` Arend van Spriel
2012-03-06 23:23 ` Hauke Mehrtens
2012-03-06 23:23   ` Hauke Mehrtens
2012-03-07  7:45   ` Arend van Spriel [this message]
2012-03-07  7:45     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F571236.7070608@broadcom.com \
    --to=arend@broadcom.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=hauke@hauke-m.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.