From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH] bridge: fix "entering disabled state" logging
Date: Wed, 07 Mar 2012 10:04:04 +0200 [thread overview]
Message-ID: <4F571674.6000107@gmail.com> (raw)
In-Reply-To: <20120306.143323.1591818099708591757.davem@davemloft.net>
On 03/06/2012 09:33 PM, David Miller wrote:
> From: Paulius Zaleckas<paulius.zaleckas@gmail.com>
> Date: Tue, 06 Mar 2012 16:22:19 +0200
>
>> Now we have:
>> eth0: link *down*
>> br0: port 1(eth0) entering *forwarding* state
>>
>> State should be logged *after* it was changed, not before.
>>
>> Reported-by: Zilvinas Valinskas<zilvinas@wilibox.com>
>> Signed-off-by: Paulius Zaleckas<paulius.zaleckas@gmail.com>
>
> This is intentional, this was a discussion about this.
>
> "Entering" means "about to" therefore we say it before it happens.
You have missed the whole point here... please look at dmesg output, I
have bolded what you should pay attention to. It should say "entering
disabled state" instead of "entering forwarding state".
However I do agree with you and Stephen that it should say "entered" and
not "entering". I will send you patch changing this.
I will also resend this patch with better description.
WARNING: multiple messages have this Message-ID (diff)
From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH] bridge: fix "entering disabled state" logging
Date: Wed, 07 Mar 2012 10:04:04 +0200 [thread overview]
Message-ID: <4F571674.6000107@gmail.com> (raw)
In-Reply-To: <20120306.143323.1591818099708591757.davem@davemloft.net>
On 03/06/2012 09:33 PM, David Miller wrote:
> From: Paulius Zaleckas<paulius.zaleckas@gmail.com>
> Date: Tue, 06 Mar 2012 16:22:19 +0200
>
>> Now we have:
>> eth0: link *down*
>> br0: port 1(eth0) entering *forwarding* state
>>
>> State should be logged *after* it was changed, not before.
>>
>> Reported-by: Zilvinas Valinskas<zilvinas@wilibox.com>
>> Signed-off-by: Paulius Zaleckas<paulius.zaleckas@gmail.com>
>
> This is intentional, this was a discussion about this.
>
> "Entering" means "about to" therefore we say it before it happens.
You have missed the whole point here... please look at dmesg output, I
have bolded what you should pay attention to. It should say "entering
disabled state" instead of "entering forwarding state".
However I do agree with you and Stephen that it should say "entered" and
not "entering". I will send you patch changing this.
I will also resend this patch with better description.
next prev parent reply other threads:[~2012-03-07 8:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 14:22 [Bridge] [PATCH] bridge: fix "entering disabled state" logging Paulius Zaleckas
2012-03-06 14:22 ` Paulius Zaleckas
2012-03-06 14:34 ` [Bridge] " Paulius Zaleckas
2012-03-06 14:34 ` Paulius Zaleckas
2012-03-06 17:09 ` [Bridge] " Stephen Hemminger
2012-03-06 17:09 ` Stephen Hemminger
2012-03-06 19:33 ` [Bridge] " David Miller
2012-03-06 19:33 ` David Miller
2012-03-06 19:33 ` [Bridge] " David Miller
2012-03-06 19:33 ` David Miller
2012-03-07 8:04 ` Paulius Zaleckas [this message]
2012-03-07 8:04 ` Paulius Zaleckas
2012-03-08 3:59 ` [Bridge] " David Lamparter
2012-03-08 3:59 ` David Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F571674.6000107@gmail.com \
--to=paulius.zaleckas@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.