From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pxafb: do console locking before calling fb_blank()
Date: Wed, 07 Mar 2012 10:09:18 +0000 [thread overview]
Message-ID: <4F5733CE.2060900@gmx.de> (raw)
In-Reply-To: <1330264322-5938-1-git-send-email-anarsoul@gmail.com>
On 02/26/2012 01:52 PM, Vasily Khoruzhick wrote:
> Otherwise we hit WARN_CONSOLE_UNLOCKED in do_unblank_screen
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/pxafb.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c
> index 1d1e4f1..c176561 100644
> --- a/drivers/video/pxafb.c
> +++ b/drivers/video/pxafb.c
> @@ -54,6 +54,7 @@
> #include <linux/mutex.h>
> #include <linux/kthread.h>
> #include <linux/freezer.h>
> +#include <linux/console.h>
>
> #include <mach/hardware.h>
> #include <asm/io.h>
> @@ -730,9 +731,12 @@ static int overlayfb_open(struct fb_info *info, int user)
> if (user = 0)
> return -ENODEV;
>
> - if (ofb->usage++ = 0)
> + if (ofb->usage++ = 0) {
> /* unblank the base framebuffer */
> + console_lock();
> fb_blank(&ofb->fbi->fb, FB_BLANK_UNBLANK);
> + console_unlock();
> + }
>
> return 0;
> }
WARNING: multiple messages have this Message-ID (diff)
From: FlorianSchandinat@gmx.de (Florian Tobias Schandinat)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxafb: do console locking before calling fb_blank()
Date: Wed, 07 Mar 2012 10:09:18 +0000 [thread overview]
Message-ID: <4F5733CE.2060900@gmx.de> (raw)
In-Reply-To: <1330264322-5938-1-git-send-email-anarsoul@gmail.com>
On 02/26/2012 01:52 PM, Vasily Khoruzhick wrote:
> Otherwise we hit WARN_CONSOLE_UNLOCKED in do_unblank_screen
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/pxafb.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c
> index 1d1e4f1..c176561 100644
> --- a/drivers/video/pxafb.c
> +++ b/drivers/video/pxafb.c
> @@ -54,6 +54,7 @@
> #include <linux/mutex.h>
> #include <linux/kthread.h>
> #include <linux/freezer.h>
> +#include <linux/console.h>
>
> #include <mach/hardware.h>
> #include <asm/io.h>
> @@ -730,9 +731,12 @@ static int overlayfb_open(struct fb_info *info, int user)
> if (user == 0)
> return -ENODEV;
>
> - if (ofb->usage++ == 0)
> + if (ofb->usage++ == 0) {
> /* unblank the base framebuffer */
> + console_lock();
> fb_blank(&ofb->fbi->fb, FB_BLANK_UNBLANK);
> + console_unlock();
> + }
>
> return 0;
> }
next prev parent reply other threads:[~2012-03-07 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 13:52 [PATCH] pxafb: do console locking before calling fb_blank() Vasily Khoruzhick
2012-02-26 13:52 ` Vasily Khoruzhick
2012-03-07 10:09 ` Florian Tobias Schandinat [this message]
2012-03-07 10:09 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5733CE.2060900@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.