[RESEND PATCH v3] Fix a copy & paste error in erst.c.

[RESEND PATCH v3] Fix a copy & paste error in erst.c.

[Jiang Liu]

This patch fixes a copy & paste error in erst.c and it applies
to v3.3-rc6.

Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Acked-by: Huang Ying <ying.huang@intel.com>
---
 drivers/acpi/apei/erst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
index eb9fab5..e4d9d24 100644
--- a/drivers/acpi/apei/erst.c
+++ b/drivers/acpi/apei/erst.c
@@ -917,7 +917,7 @@ static int erst_check_table(struct acpi_table_erst *erst_tab)
 {
 	if ((erst_tab->header_length !=
 	     (sizeof(struct acpi_table_erst) - sizeof(erst_tab->header)))
-	    && (erst_tab->header_length != sizeof(struct acpi_table_einj)))
+	    && (erst_tab->header_length != sizeof(struct acpi_table_erst)))
 		return -EINVAL;
 	if (erst_tab->header.length < sizeof(struct acpi_table_erst))
 		return -EINVAL;
-- 
1.7.5.4

Re: [RESEND PATCH v3] Fix a copy & paste error in erst.c.

[Bjorn Helgaas]

On Tue, Mar 6, 2012 at 9:29 AM, Jiang Liu <liuj97@gmail.com> wrote:
> This patch fixes a copy & paste error in erst.c and it applies
> to v3.3-rc6.

It'd be nice if the subject line gave a hint about what sort of
problem this patch fixes.  It doesn't matter *how* the original error
was made; it's a question of what behavior we're changing.

Distro and stable kernel maintainers have to decide whether this is
important enough to be backported, and "fix copy & paste error"
doesn't tell them anything useful.

Maybe something like:

    ACPI, APEI, Fix ERST header length check

    This fixes the ERST header length check.  Without this patch, we
    mistakenly ignore the ERST table, and hardware errors can't be saved
    in the persistent store.


> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
> Acked-by: Huang Ying <ying.huang@intel.com>
> ---
>  drivers/acpi/apei/erst.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
> index eb9fab5..e4d9d24 100644
> --- a/drivers/acpi/apei/erst.c
> +++ b/drivers/acpi/apei/erst.c
> @@ -917,7 +917,7 @@ static int erst_check_table(struct acpi_table_erst *erst_tab)
>  {
>        if ((erst_tab->header_length !=
>             (sizeof(struct acpi_table_erst) - sizeof(erst_tab->header)))
> -           && (erst_tab->header_length != sizeof(struct acpi_table_einj)))
> +           && (erst_tab->header_length != sizeof(struct acpi_table_erst)))
>                return -EINVAL;
>        if (erst_tab->header.length < sizeof(struct acpi_table_erst))
>                return -EINVAL;
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RESEND PATCH v3] Fix a copy & paste error in erst.c.

[Jiang Liu]

Thanks, Bjorn.
Will send another version with clear patch description.

On 03/07/2012 12:55 AM, Bjorn Helgaas wrote:
> On Tue, Mar 6, 2012 at 9:29 AM, Jiang Liu <liuj97@gmail.com> wrote:
>> This patch fixes a copy & paste error in erst.c and it applies
>> to v3.3-rc6.
> 
> It'd be nice if the subject line gave a hint about what sort of
> problem this patch fixes.  It doesn't matter *how* the original error
> was made; it's a question of what behavior we're changing.
> 
> Distro and stable kernel maintainers have to decide whether this is
> important enough to be backported, and "fix copy & paste error"
> doesn't tell them anything useful.
> 
> Maybe something like:
> 
>     ACPI, APEI, Fix ERST header length check
> 
>     This fixes the ERST header length check.  Without this patch, we
>     mistakenly ignore the ERST table, and hardware errors can't be saved
>     in the persistent store.
> 
> 
>> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
>> Acked-by: Huang Ying <ying.huang@intel.com>
>> ---
>>  drivers/acpi/apei/erst.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
>> index eb9fab5..e4d9d24 100644
>> --- a/drivers/acpi/apei/erst.c
>> +++ b/drivers/acpi/apei/erst.c
>> @@ -917,7 +917,7 @@ static int erst_check_table(struct acpi_table_erst *erst_tab)
>>  {
>>        if ((erst_tab->header_length !=
>>             (sizeof(struct acpi_table_erst) - sizeof(erst_tab->header)))
>> -           && (erst_tab->header_length != sizeof(struct acpi_table_einj)))
>> +           && (erst_tab->header_length != sizeof(struct acpi_table_erst)))
>>                return -EINVAL;
>>        if (erst_tab->header.length < sizeof(struct acpi_table_erst))
>>                return -EINVAL;
>> --
>> 1.7.5.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html