All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Chen Yufei <cyfdecyf@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Remove type field in ModuleEntry as it's not used.
Date: Wed, 07 Mar 2012 17:19:20 +0100	[thread overview]
Message-ID: <4F578A88.7000200@suse.de> (raw)
In-Reply-To: <1331134603-73952-1-git-send-email-cyfdecyf@gmail.com>

Am 07.03.2012 16:36, schrieb Chen Yufei:
> Signed-off-by: Chen Yufei <cyfdecyf@gmail.com>

There's separate init_type_list[]s per type and the type field is not
even initialized, so:

Acked-by: Andreas Färber <afaerber@suse.de>

Thanks,
Andreas

> ---
>  module.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/module.c b/module.c
> index 106a969..c3a6da7 100644
> --- a/module.c
> +++ b/module.c
> @@ -19,7 +19,6 @@
>  
>  typedef struct ModuleEntry
>  {
> -    module_init_type type;
>      void (*init)(void);
>      QTAILQ_ENTRY(ModuleEntry) node;
>  } ModuleEntry;

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Chen Yufei <cyfdecyf@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Remove type field in ModuleEntry as it's not used.
Date: Wed, 07 Mar 2012 17:19:20 +0100	[thread overview]
Message-ID: <4F578A88.7000200@suse.de> (raw)
In-Reply-To: <1331134603-73952-1-git-send-email-cyfdecyf@gmail.com>

Am 07.03.2012 16:36, schrieb Chen Yufei:
> Signed-off-by: Chen Yufei <cyfdecyf@gmail.com>

There's separate init_type_list[]s per type and the type field is not
even initialized, so:

Acked-by: Andreas Färber <afaerber@suse.de>

Thanks,
Andreas

> ---
>  module.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/module.c b/module.c
> index 106a969..c3a6da7 100644
> --- a/module.c
> +++ b/module.c
> @@ -19,7 +19,6 @@
>  
>  typedef struct ModuleEntry
>  {
> -    module_init_type type;
>      void (*init)(void);
>      QTAILQ_ENTRY(ModuleEntry) node;
>  } ModuleEntry;

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2012-03-07 16:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 15:36 [Qemu-trivial] [PATCH] Remove type field in ModuleEntry as it's not used Chen Yufei
2012-03-07 15:36 ` [Qemu-devel] " Chen Yufei
2012-03-07 16:19 ` Andreas Färber [this message]
2012-03-07 16:19   ` Andreas Färber
2012-03-15  8:17 ` [Qemu-trivial] " Stefan Hajnoczi
2012-03-15  8:17   ` [Qemu-devel] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F578A88.7000200@suse.de \
    --to=afaerber@suse.de \
    --cc=cyfdecyf@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.