All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Hauer <s.hauer@pengutronix.de>,
	Sascha@alsa-project.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 00/17] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi
Date: Wed, 7 Mar 2012 17:03:00 -0600	[thread overview]
Message-ID: <4F57E924.4050208@freescale.com> (raw)
In-Reply-To: <20120307210833.GO3107@opensource.wolfsonmicro.com>

Mark Brown wrote:
> Turn on the debug logging in soc-core.c and it'll chatter away about
> what's up; not finding cards is a perfectly normal thing s we're not too
> verbose.

So it turns out there are a couple problems.

1) This patch is missing:

http://patchwork.ozlabs.org/patch/128533/

Our exalted maintainer apparently forgot to apply this patch in a timely
manner for 3.3, so it probably won't make it.  But that's something I'll
just have to deal with.

2) The p1022_ds.c needs the equivalent of this patch:

http://mailman.alsa-project.org/pipermail/alsa-devel/2011-November/046253.html

I have no idea how the P1022DS ever worked, because the WM8776 driver has
always needed the SND_SOC_DAIFMT_Cxx_xxx macro defined.

Apparently, p1022_ds.c needs to set a value for SND_SOC_DAIFMT_INV_MASK.
I tried SND_SOC_DAIFMT_NB_NF, and that seems to work.

Shawn, I'd make the change myself, but I don't want to step on your toes
while doing it.  Do you want to make it yourself?

-- 
Timur Tabi
Linux kernel developer at Freescale

WARNING: multiple messages have this Message-ID (diff)
From: timur@freescale.com (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/17] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi
Date: Wed, 7 Mar 2012 17:03:00 -0600	[thread overview]
Message-ID: <4F57E924.4050208@freescale.com> (raw)
In-Reply-To: <20120307210833.GO3107@opensource.wolfsonmicro.com>

Mark Brown wrote:
> Turn on the debug logging in soc-core.c and it'll chatter away about
> what's up; not finding cards is a perfectly normal thing s we're not too
> verbose.

So it turns out there are a couple problems.

1) This patch is missing:

http://patchwork.ozlabs.org/patch/128533/

Our exalted maintainer apparently forgot to apply this patch in a timely
manner for 3.3, so it probably won't make it.  But that's something I'll
just have to deal with.

2) The p1022_ds.c needs the equivalent of this patch:

http://mailman.alsa-project.org/pipermail/alsa-devel/2011-November/046253.html

I have no idea how the P1022DS ever worked, because the WM8776 driver has
always needed the SND_SOC_DAIFMT_Cxx_xxx macro defined.

Apparently, p1022_ds.c needs to set a value for SND_SOC_DAIFMT_INV_MASK.
I tried SND_SOC_DAIFMT_NB_NF, and that seems to work.

Shawn, I'd make the change myself, but I don't want to step on your toes
while doing it.  Do you want to make it yourself?

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2012-03-07 23:03 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05 14:30 [PATCH v2 00/17] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Shawn Guo
2012-03-05 14:30 ` Shawn Guo
2012-03-05 14:20 ` Mark Brown
2012-03-05 14:20   ` Mark Brown
2012-03-05 14:44   ` Shawn Guo
2012-03-05 14:44     ` Shawn Guo
2012-03-05 14:35     ` Mark Brown
2012-03-05 14:35       ` Mark Brown
2012-03-05 14:30 ` [PATCH v2 01/17] ASoC: imx: move eukrea audmux call into ASoC machine driver Shawn Guo
2012-03-05 14:30   ` Shawn Guo
2012-03-05 17:46   ` Mark Brown
2012-03-05 17:46     ` Mark Brown
2012-03-05 17:55     ` Matt Sealey
2012-03-05 17:55       ` Matt Sealey
2012-03-05 20:36       ` Mark Brown
2012-03-05 20:36         ` Mark Brown
2012-03-05 19:27     ` Sascha Hauer
2012-03-05 19:27       ` Sascha Hauer
2012-03-05 23:45       ` Shawn Guo
2012-03-05 23:45         ` Shawn Guo
2012-03-06  0:06       ` Mark Brown
2012-03-06  0:06         ` Mark Brown
2012-03-05 14:30 ` [PATCH v2 02/17] ASoC: imx: move phycore " Shawn Guo
2012-03-05 14:30   ` Shawn Guo
2012-03-05 14:30 ` [PATCH v2 03/17] ARM: imx: merge audmux-v1 and audmux-v2 Shawn Guo
2012-03-05 14:30   ` Shawn Guo
2012-03-05 14:30 ` [PATCH v2 04/17] ARM: imx: convert audmux to a platform driver Shawn Guo
2012-03-05 14:30   ` Shawn Guo
2012-03-05 14:30 ` [PATCH v2 05/17] ASoC: imx: move audmux driver into sound/soc/imx Shawn Guo
2012-03-05 14:30   ` Shawn Guo
2012-03-05 14:30 ` [PATCH v2 06/17] ASoC: imx: rename audmux prefix mxc to imx Shawn Guo
2012-03-05 14:30   ` Shawn Guo
2012-03-05 14:30 ` [PATCH v2 07/17] ASoC: imx: separate imx-pcm bits from imx-ssi driver Shawn Guo
2012-03-05 14:30   ` Shawn Guo
2012-03-05 14:30 ` [PATCH v2 08/17] ASoC: imx: add an explicit Kconfig option for " Shawn Guo
2012-03-05 14:30   ` Shawn Guo
2012-03-05 14:30 ` [PATCH v2 09/17] ASoC: fsl: separate SSI and DMA Kconfig options Shawn Guo
2012-03-05 14:30   ` Shawn Guo
2012-03-07 20:20   ` Timur Tabi
2012-03-07 20:20     ` Timur Tabi
2012-03-08 13:08     ` Shawn Guo
2012-03-08 13:08       ` Shawn Guo
2012-03-05 14:30 ` [PATCH v2 10/17] ASoC: imx: merge sound/soc/imx into sound/soc/fsl Shawn Guo
2012-03-05 14:30   ` Shawn Guo
2012-03-05 17:39   ` Sascha Hauer
2012-03-05 17:39     ` Sascha Hauer
2012-03-05 23:46     ` Shawn Guo
2012-03-05 23:46       ` Shawn Guo
2012-03-06  5:46     ` Shawn Guo
2012-03-06  5:46       ` Shawn Guo
2012-03-05 14:30 ` [PATCH v2 11/17] ASoC: fsl: create fsl_utils to accommodate the common functions Shawn Guo
2012-03-05 14:30   ` Shawn Guo
2012-03-05 14:49   ` Mark Brown
2012-03-05 14:49     ` Mark Brown
2012-03-05 15:48     ` Timur Tabi
2012-03-05 15:48       ` Timur Tabi
2012-03-05 16:15       ` Mark Brown
2012-03-05 16:15         ` Mark Brown
2012-03-06  6:27     ` Shawn Guo
2012-03-06  6:27       ` Shawn Guo
2012-03-05 14:31 ` [PATCH v2 12/17] ASoC: fsl: check property 'compatible' for the machine name Shawn Guo
2012-03-05 14:31   ` Shawn Guo
2012-03-05 14:31 ` [PATCH v2 13/17] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX Shawn Guo
2012-03-05 14:31   ` Shawn Guo
2012-03-05 14:31 ` [PATCH v2 14/17] ASoC: fsl: remove the fatal error checking on codec-handle Shawn Guo
2012-03-05 14:31   ` Shawn Guo
2012-03-05 14:31 ` [PATCH v2 15/17] ASoC: fsl: let fsl_ssi work with imx pcm and machine drivers Shawn Guo
2012-03-05 14:31   ` Shawn Guo
2012-03-05 14:31 ` [PATCH v2 16/17] ASoC: fsl: add dt support for imx-audmux Shawn Guo
2012-03-05 14:31   ` Shawn Guo
2012-03-06 12:49   ` Mark Brown
2012-03-06 12:49     ` Mark Brown
2012-03-06 13:13     ` Shawn Guo
2012-03-06 13:13       ` Shawn Guo
2012-03-05 14:31 ` [PATCH v2 17/17] ASoC: fsl: add imx-sgtl5000 machine driver Shawn Guo
2012-03-05 14:31   ` Shawn Guo
2012-03-05 14:46   ` Mark Brown
2012-03-05 14:46     ` Mark Brown
2012-03-06  7:39     ` Shawn Guo
2012-03-06  7:39       ` Shawn Guo
2012-03-06 12:02       ` Mark Brown
2012-03-06 12:02         ` Mark Brown
2012-03-06 13:34         ` Shawn Guo
2012-03-06 13:34           ` Shawn Guo
2012-03-06 13:35           ` Mark Brown
2012-03-06 13:35             ` Mark Brown
2012-03-05 17:42   ` Sascha Hauer
2012-03-05 17:42     ` Sascha Hauer
2012-03-05 18:09     ` Matt Sealey
2012-03-05 18:09       ` Matt Sealey
2012-03-05 19:32       ` Sascha Hauer
2012-03-05 19:32         ` Sascha Hauer
2012-03-05 20:44       ` Mark Brown
2012-03-05 20:44         ` Mark Brown
2012-03-05 21:08         ` Timur Tabi
2012-03-05 21:08           ` Timur Tabi
2012-03-06 15:50     ` Shawn Guo
2012-03-06 15:50       ` Shawn Guo
2012-03-07  8:37       ` Sascha Hauer
2012-03-07  8:37         ` Sascha Hauer
2012-03-07 21:05 ` [PATCH v2 00/17] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Timur Tabi
2012-03-07 21:05   ` Timur Tabi
2012-03-07 21:08   ` Mark Brown
2012-03-07 21:08     ` Mark Brown
2012-03-07 23:03     ` Timur Tabi [this message]
2012-03-07 23:03       ` Timur Tabi
2012-03-08 11:51       ` Mark Brown
2012-03-08 11:51         ` Mark Brown
2012-03-08 12:33       ` Shawn Guo
2012-03-08 12:33         ` Shawn Guo
2012-03-08 12:36         ` Tabi Timur-B04825
2012-03-08 12:36           ` Tabi Timur-B04825
2012-03-07 23:18 ` Timur Tabi
2012-03-07 23:18   ` Timur Tabi
2012-03-08 12:02   ` Mark Brown
2012-03-08 12:02     ` Mark Brown
2012-03-08 12:37     ` Shawn Guo
2012-03-08 12:37       ` Shawn Guo
2012-03-08 13:11   ` Shawn Guo
2012-03-08 13:11     ` Shawn Guo
2012-03-08 14:45     ` Tabi Timur-B04825
2012-03-08 14:45       ` Tabi Timur-B04825

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F57E924.4050208@freescale.com \
    --to=timur@freescale.com \
    --cc=Sascha@alsa-project.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.