From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: William Irwin <wli@holomorphy.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] hugetlb: drop prev_vma in hugetlb_get_unmapped_area_topdown
Date: Thu, 08 Mar 2012 10:28:50 +0800 [thread overview]
Message-ID: <4F581962.8040403@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120307140101.b0624e80.akpm@linux-foundation.org>
On 03/08/2012 06:01 AM, Andrew Morton wrote:
> On Fri, 13 Jan 2012 19:44:53 +0800
> Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> wrote:
>
>> Afte call find_vma_prev(mm, addr, &prev_vma), following condition is always
>> true:
>> !prev_vma || (addr >= prev_vma->vm_end)
>> it can be happily drop prev_vma and use find_vma instead of find_vma_prev
>
> I had to rework this patch due to 097d59106a8e4b ("vm: avoid using
> find_vma_prev() unnecessarily") in mainline. Can you please check my
> handiwork?
>
It looks good to me, thanks Andrew!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: William Irwin <wli@holomorphy.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] hugetlb: drop prev_vma in hugetlb_get_unmapped_area_topdown
Date: Thu, 08 Mar 2012 10:28:50 +0800 [thread overview]
Message-ID: <4F581962.8040403@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120307140101.b0624e80.akpm@linux-foundation.org>
On 03/08/2012 06:01 AM, Andrew Morton wrote:
> On Fri, 13 Jan 2012 19:44:53 +0800
> Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> wrote:
>
>> Afte call find_vma_prev(mm, addr, &prev_vma), following condition is always
>> true:
>> !prev_vma || (addr >= prev_vma->vm_end)
>> it can be happily drop prev_vma and use find_vma instead of find_vma_prev
>
> I had to rework this patch due to 097d59106a8e4b ("vm: avoid using
> find_vma_prev() unnecessarily") in mainline. Can you please check my
> handiwork?
>
It looks good to me, thanks Andrew!
next prev parent reply other threads:[~2012-03-08 2:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 11:44 [PATCH 1/5] hugetlbfs: fix hugetlb_get_unmapped_area Xiao Guangrong
2012-01-13 11:44 ` Xiao Guangrong
2012-01-13 11:44 ` [PATCH 2/5] hugetlb: drop prev_vma in hugetlb_get_unmapped_area_topdown Xiao Guangrong
2012-01-13 11:44 ` Xiao Guangrong
2012-03-07 22:01 ` Andrew Morton
2012-03-07 22:01 ` Andrew Morton
2012-03-08 2:28 ` Xiao Guangrong [this message]
2012-03-08 2:28 ` Xiao Guangrong
2012-01-13 11:45 ` [PATCH 3/5] hugetlb: try to search again if it is really needed Xiao Guangrong
2012-01-13 11:45 ` Xiao Guangrong
2012-02-01 22:43 ` Andrew Morton
2012-02-01 22:43 ` Andrew Morton
2012-02-02 5:19 ` Xiao Guangrong
2012-02-02 5:19 ` Xiao Guangrong
2012-01-13 11:46 ` [PATCH 4/5] mm: do not reset cached_hole_size when vma is unmapped Xiao Guangrong
2012-01-13 11:46 ` Xiao Guangrong
2012-01-13 11:47 ` [PATCH 5/5] mm: search from free_area_cache for the bigger size Xiao Guangrong
2012-01-13 11:47 ` Xiao Guangrong
2012-02-01 22:44 ` Andrew Morton
2012-02-01 22:44 ` Andrew Morton
2012-02-02 7:07 ` Xiao Guangrong
2012-02-02 7:07 ` Xiao Guangrong
2012-01-31 6:05 ` [PATCH 1/5] hugetlbfs: fix hugetlb_get_unmapped_area Xiao Guangrong
2012-01-31 6:05 ` Xiao Guangrong
2012-02-01 22:43 ` Andrew Morton
2012-02-01 22:43 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F581962.8040403@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.