Re: [PATCH] stmmac: Allow stmmac to work with other PHY buses(v2).

[Florian Fainelli <florian@openwrt.org>]

Hi,

Le 03/07/12 09:08, Srinivas KANDAGATLA a écrit :
> David Miller wrote:
>> From: Giuseppe CAVALLARO<peppe.cavallaro@st.com>
>> Date: Tue,  6 Mar 2012 06:42:00 +0100
>>
>>
>>> After commit "db8857b stmmac: use an unique MDIO bus name" and "90b9a54
>>> stmmac: fix phy naming inconsistency" stmmac cant work with other MDIO
>>> buses, because mdio_bus name is fixed in the dirver.
>>>
>>
>> This sounds inaccurate, you're making it sound like these commits
>> introduced this limitation, as far as I can tell they did not.
>>
>>
> Thanks for your comments,
>
> Commit comment is true to some extent, before "db8857b stmmac: use an
> unique MDIO bus name" and "a77e929 mdio-gpio: use an unique MDIO bus
> name" we managed to get stmmac use mdio bus by specifying same id in
> platform data of both the drivers.

You could get it working with your platform supplied MDIO bus name more 
by accident than on purpose.

> However after these commits this method was no more possible because
> stmmac can connect to phys on stmmac-x mdio buses Only.
>
> I think, originally the problem was in stmmac to some extent which
> became worse after adding prefix mdio bus.
> Here is the new patch removing the misleading comments.

Your new explanation makes much more sense to me now. Feel free to add my:

Acked-by: Florian Fainelli <florian@openwrt.org>

>
>
>> Before the MDIO bus name was just plain "%x" and the bus_id number
>> was placed there.  Then it became the same thing, except with some
>> (potentially fixed) prefix.
>>
>> Nothing about that change makes any difference whatsoever about
>> what you're modifications are trying to allow.
>>
>> BTW, also, commit "90b9a54" is ambiguous.
>>
>>
> Actual commit was : 90b9a5454fd2e626aa1614fe9ece6b63a0dc37af
>
> Thanks,
> srini
>> [davem@bql net]$ git show 90b9a54
>> error: short SHA1 90b9a54 is ambiguous.
>> error: short SHA1 90b9a54 is ambiguous.
>> fatal: ambiguous argument '90b9a54': unknown revision or path not in the working tree.
>>
>