From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC 1/1] ath9k_hw: Fix enabling of MCI and RTT
Date: Thu, 8 Mar 2012 18:21:38 +0530 [thread overview]
Message-ID: <4F58AB5A.3050708@qca.qualcomm.com> (raw)
In-Reply-To: <20312.43226.814441.345911@gargle.gargle.HOWL>
Hi Sujith,
On Thursday 08 March 2012 06:10 PM, Sujith Manoharan wrote:
> Mohammed Shafi Shajakhan wrote:
>> +
>> + if (AR_SREV_9462(ah)) {
>> + ah->ent_mode = REG_READ(ah, AR_ENT_OTP);
>> + if (!(ah->ent_mode& AR_ENT_OTP_49GHZ_DISABLE))
>> + pCap->hw_caps |= ATH9K_HW_CAP_MCI;
>> + }
>> +
>> + if (AR_SREV_9462_20(ah))
>> + pCap->hw_caps |= ATH9K_HW_CAP_RTT;
>
> ah->ent_mode is already being updated earlier in ath9k_hw_fill_cap_info(),
> so there is no need to read AR_ENT_OTP again.
did notice the check AR9300_20_LATER :). just thought if we change
something and 'ent_mode' holds some other value. anyway will just leave
the check.
>
> Sujith
--
thanks,
shafi
WARNING: multiple messages have this Message-ID (diff)
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
<Mohammed@venema.h4ckr.net>, <ath9k-devel@lists.ath9k.org>,
<linux-wireless@vger.kernel.org>,
Rodriguez Luis <rodrigue@qca.qualcomm.com>
Subject: Re: [ath9k-devel] [RFC 1/1] ath9k_hw: Fix enabling of MCI and RTT
Date: Thu, 8 Mar 2012 18:21:38 +0530 [thread overview]
Message-ID: <4F58AB5A.3050708@qca.qualcomm.com> (raw)
In-Reply-To: <20312.43226.814441.345911@gargle.gargle.HOWL>
Hi Sujith,
On Thursday 08 March 2012 06:10 PM, Sujith Manoharan wrote:
> Mohammed Shafi Shajakhan wrote:
>> +
>> + if (AR_SREV_9462(ah)) {
>> + ah->ent_mode = REG_READ(ah, AR_ENT_OTP);
>> + if (!(ah->ent_mode& AR_ENT_OTP_49GHZ_DISABLE))
>> + pCap->hw_caps |= ATH9K_HW_CAP_MCI;
>> + }
>> +
>> + if (AR_SREV_9462_20(ah))
>> + pCap->hw_caps |= ATH9K_HW_CAP_RTT;
>
> ah->ent_mode is already being updated earlier in ath9k_hw_fill_cap_info(),
> so there is no need to read AR_ENT_OTP again.
did notice the check AR9300_20_LATER :). just thought if we change
something and 'ent_mode' holds some other value. anyway will just leave
the check.
>
> Sujith
--
thanks,
shafi
next prev parent reply other threads:[~2012-03-08 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 10:08 [ath9k-devel] [RFC 1/1] ath9k_hw: Fix enabling of MCI and RTT Mohammed Shafi Shajakhan
2012-03-08 10:08 ` Mohammed Shafi Shajakhan
2012-03-08 12:40 ` [ath9k-devel] " Sujith Manoharan
2012-03-08 12:40 ` Sujith Manoharan
2012-03-08 12:51 ` Mohammed Shafi Shajakhan [this message]
2012-03-08 12:51 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F58AB5A.3050708@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.