All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Aneesh V <aneesh@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/8] OMAP4: hwmod: add EMIF hw mod data
Date: Thu, 8 Mar 2012 17:41:32 +0100	[thread overview]
Message-ID: <4F58E13C.8040906@ti.com> (raw)
In-Reply-To: <1331222065-3579-2-git-send-email-aneesh@ti.com>

Hi Aneesh

On 3/8/2012 4:54 PM, Aneesh V wrote:
> From: Benoit Cousson<b-cousson@ti.com>
>
> Add hwmod data for EMIF IP instances in OMAP4.

Paul has just posted an OMAP4 hwmod series (ARM: OMAP4: hwmod data: add 
almost all remaining IP blocks) that does contain the EMIF hwmods, so 
assuming that you are not adding some custom dev_attr here, it should 
work for you.

Regards,
Benoit



>
> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
> ---
> Changes since RFC:
> - Improved commit log
> ---
>   arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  110 ++++++++++++++++++++++++++++
>   1 files changed, 110 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index f9f1510..2b107c7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -5480,6 +5480,111 @@ static struct omap_hwmod omap44xx_usb_tll_hs_hwmod = {
>   	.slaves_cnt	= ARRAY_SIZE(omap44xx_usb_tll_hs_slaves),
>   };
>
> +/*
> + * 'emif' class
> + * external memory interface no1
> + */
> +
> +static struct omap_hwmod_class omap44xx_emif_hwmod_class = {
> +	.name	= "emif",
> +};
> +
> +/* emif1 */
> +static struct omap_hwmod omap44xx_emif1_hwmod;
> +static struct omap_hwmod_irq_info omap44xx_emif1_irqs[] = {
> +	{ .irq = 110 + OMAP44XX_IRQ_GIC_START },
> +	{ .irq = -1 }
> +};
> +
> +static struct omap_hwmod_addr_space omap44xx_emif1_addrs[] = {
> +	{
> +		.pa_start	= 0x4c000000,
> +		.pa_end		= 0x4c0000ff,
> +		.flags		= ADDR_TYPE_RT
> +	},
> +	{ }
> +};
> +
> +/* emif_fw ->  emif1 */
> +static struct omap_hwmod_ocp_if omap44xx_emif_fw__emif1 = {
> +	.master		=&omap44xx_emif_fw_hwmod,
> +	.slave		=&omap44xx_emif1_hwmod,
> +	.clk		= "l3_div_ck",
> +	.addr		= omap44xx_emif1_addrs,
> +	.user		= OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> +/* emif1 slave ports */
> +static struct omap_hwmod_ocp_if *omap44xx_emif1_slaves[] = {
> +	&omap44xx_emif_fw__emif1,
> +};
> +
> +static struct omap_hwmod omap44xx_emif1_hwmod = {
> +	.name		= "emif1",
> +	.class		=&omap44xx_emif_hwmod_class,
> +	.flags		= HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
> +	.mpu_irqs	= omap44xx_emif1_irqs,
> +	.main_clk	= "emif1_fck",
> +	.clkdm_name	= "l3_emif_clkdm",
> +	.prcm		= {
> +		.omap4 = {
> +			.clkctrl_offs = OMAP4_CM_MEMIF_EMIF_1_CLKCTRL_OFFSET,
> +			.context_offs = OMAP4_RM_MEMIF_EMIF_1_CONTEXT_OFFSET,
> +			.modulemode   = MODULEMODE_HWCTRL,
> +		},
> +	},
> +	.slaves		= omap44xx_emif1_slaves,
> +	.slaves_cnt	= ARRAY_SIZE(omap44xx_emif1_slaves),
> +};
> +
> +/* emif2 */
> +static struct omap_hwmod omap44xx_emif2_hwmod;
> +static struct omap_hwmod_irq_info omap44xx_emif2_irqs[] = {
> +	{ .irq = 111 + OMAP44XX_IRQ_GIC_START },
> +	{ .irq = -1 }
> +};
> +
> +static struct omap_hwmod_addr_space omap44xx_emif2_addrs[] = {
> +	{
> +		.pa_start	= 0x4d000000,
> +		.pa_end		= 0x4d0000ff,
> +		.flags		= ADDR_TYPE_RT
> +	},
> +	{ }
> +};
> +
> +/* emif_fw ->  emif2 */
> +static struct omap_hwmod_ocp_if omap44xx_emif_fw__emif2 = {
> +	.master		=&omap44xx_emif_fw_hwmod,
> +	.slave		=&omap44xx_emif2_hwmod,
> +	.clk		= "l3_div_ck",
> +	.addr		= omap44xx_emif2_addrs,
> +	.user		= OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> +/* emif2 slave ports */
> +static struct omap_hwmod_ocp_if *omap44xx_emif2_slaves[] = {
> +	&omap44xx_emif_fw__emif2,
> +};
> +
> +static struct omap_hwmod omap44xx_emif2_hwmod = {
> +	.name		= "emif2",
> +	.class		=&omap44xx_emif_hwmod_class,
> +	.flags		= HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
> +	.mpu_irqs	= omap44xx_emif2_irqs,
> +	.main_clk	= "emif2_fck",
> +	.clkdm_name	= "l3_emif_clkdm",
> +	.prcm		= {
> +		.omap4 = {
> +			.clkctrl_offs = OMAP4_CM_MEMIF_EMIF_1_CLKCTRL_OFFSET,
> +			.context_offs = OMAP4_RM_MEMIF_EMIF_1_CONTEXT_OFFSET,
> +			.modulemode   = MODULEMODE_HWCTRL,
> +		}
> +	},
> +	.slaves		= omap44xx_emif2_slaves,
> +	.slaves_cnt	= ARRAY_SIZE(omap44xx_emif2_slaves),
> +};
> +
>   static __initdata struct omap_hwmod *omap44xx_hwmods[] = {
>
>   	/* dmm class */
> @@ -5629,6 +5734,11 @@ static __initdata struct omap_hwmod *omap44xx_hwmods[] = {
>   	/* wd_timer class */
>   	&omap44xx_wd_timer2_hwmod,
>   	&omap44xx_wd_timer3_hwmod,
> +
> +	/* emif class */
> +	&omap44xx_emif1_hwmod,
> +	&omap44xx_emif2_hwmod,
> +
>   	NULL,
>   };
>


WARNING: multiple messages have this Message-ID (diff)
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Aneesh V <aneesh@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/8] OMAP4: hwmod: add EMIF hw mod data
Date: Thu, 8 Mar 2012 17:41:32 +0100	[thread overview]
Message-ID: <4F58E13C.8040906@ti.com> (raw)
In-Reply-To: <1331222065-3579-2-git-send-email-aneesh@ti.com>

Hi Aneesh

On 3/8/2012 4:54 PM, Aneesh V wrote:
> From: Benoit Cousson<b-cousson@ti.com>
>
> Add hwmod data for EMIF IP instances in OMAP4.

Paul has just posted an OMAP4 hwmod series (ARM: OMAP4: hwmod data: add 
almost all remaining IP blocks) that does contain the EMIF hwmods, so 
assuming that you are not adding some custom dev_attr here, it should 
work for you.

Regards,
Benoit



>
> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
> ---
> Changes since RFC:
> - Improved commit log
> ---
>   arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  110 ++++++++++++++++++++++++++++
>   1 files changed, 110 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index f9f1510..2b107c7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -5480,6 +5480,111 @@ static struct omap_hwmod omap44xx_usb_tll_hs_hwmod = {
>   	.slaves_cnt	= ARRAY_SIZE(omap44xx_usb_tll_hs_slaves),
>   };
>
> +/*
> + * 'emif' class
> + * external memory interface no1
> + */
> +
> +static struct omap_hwmod_class omap44xx_emif_hwmod_class = {
> +	.name	= "emif",
> +};
> +
> +/* emif1 */
> +static struct omap_hwmod omap44xx_emif1_hwmod;
> +static struct omap_hwmod_irq_info omap44xx_emif1_irqs[] = {
> +	{ .irq = 110 + OMAP44XX_IRQ_GIC_START },
> +	{ .irq = -1 }
> +};
> +
> +static struct omap_hwmod_addr_space omap44xx_emif1_addrs[] = {
> +	{
> +		.pa_start	= 0x4c000000,
> +		.pa_end		= 0x4c0000ff,
> +		.flags		= ADDR_TYPE_RT
> +	},
> +	{ }
> +};
> +
> +/* emif_fw ->  emif1 */
> +static struct omap_hwmod_ocp_if omap44xx_emif_fw__emif1 = {
> +	.master		=&omap44xx_emif_fw_hwmod,
> +	.slave		=&omap44xx_emif1_hwmod,
> +	.clk		= "l3_div_ck",
> +	.addr		= omap44xx_emif1_addrs,
> +	.user		= OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> +/* emif1 slave ports */
> +static struct omap_hwmod_ocp_if *omap44xx_emif1_slaves[] = {
> +	&omap44xx_emif_fw__emif1,
> +};
> +
> +static struct omap_hwmod omap44xx_emif1_hwmod = {
> +	.name		= "emif1",
> +	.class		=&omap44xx_emif_hwmod_class,
> +	.flags		= HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
> +	.mpu_irqs	= omap44xx_emif1_irqs,
> +	.main_clk	= "emif1_fck",
> +	.clkdm_name	= "l3_emif_clkdm",
> +	.prcm		= {
> +		.omap4 = {
> +			.clkctrl_offs = OMAP4_CM_MEMIF_EMIF_1_CLKCTRL_OFFSET,
> +			.context_offs = OMAP4_RM_MEMIF_EMIF_1_CONTEXT_OFFSET,
> +			.modulemode   = MODULEMODE_HWCTRL,
> +		},
> +	},
> +	.slaves		= omap44xx_emif1_slaves,
> +	.slaves_cnt	= ARRAY_SIZE(omap44xx_emif1_slaves),
> +};
> +
> +/* emif2 */
> +static struct omap_hwmod omap44xx_emif2_hwmod;
> +static struct omap_hwmod_irq_info omap44xx_emif2_irqs[] = {
> +	{ .irq = 111 + OMAP44XX_IRQ_GIC_START },
> +	{ .irq = -1 }
> +};
> +
> +static struct omap_hwmod_addr_space omap44xx_emif2_addrs[] = {
> +	{
> +		.pa_start	= 0x4d000000,
> +		.pa_end		= 0x4d0000ff,
> +		.flags		= ADDR_TYPE_RT
> +	},
> +	{ }
> +};
> +
> +/* emif_fw ->  emif2 */
> +static struct omap_hwmod_ocp_if omap44xx_emif_fw__emif2 = {
> +	.master		=&omap44xx_emif_fw_hwmod,
> +	.slave		=&omap44xx_emif2_hwmod,
> +	.clk		= "l3_div_ck",
> +	.addr		= omap44xx_emif2_addrs,
> +	.user		= OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> +/* emif2 slave ports */
> +static struct omap_hwmod_ocp_if *omap44xx_emif2_slaves[] = {
> +	&omap44xx_emif_fw__emif2,
> +};
> +
> +static struct omap_hwmod omap44xx_emif2_hwmod = {
> +	.name		= "emif2",
> +	.class		=&omap44xx_emif_hwmod_class,
> +	.flags		= HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
> +	.mpu_irqs	= omap44xx_emif2_irqs,
> +	.main_clk	= "emif2_fck",
> +	.clkdm_name	= "l3_emif_clkdm",
> +	.prcm		= {
> +		.omap4 = {
> +			.clkctrl_offs = OMAP4_CM_MEMIF_EMIF_1_CLKCTRL_OFFSET,
> +			.context_offs = OMAP4_RM_MEMIF_EMIF_1_CONTEXT_OFFSET,
> +			.modulemode   = MODULEMODE_HWCTRL,
> +		}
> +	},
> +	.slaves		= omap44xx_emif2_slaves,
> +	.slaves_cnt	= ARRAY_SIZE(omap44xx_emif2_slaves),
> +};
> +
>   static __initdata struct omap_hwmod *omap44xx_hwmods[] = {
>
>   	/* dmm class */
> @@ -5629,6 +5734,11 @@ static __initdata struct omap_hwmod *omap44xx_hwmods[] = {
>   	/* wd_timer class */
>   	&omap44xx_wd_timer2_hwmod,
>   	&omap44xx_wd_timer3_hwmod,
> +
> +	/* emif class */
> +	&omap44xx_emif1_hwmod,
> +	&omap44xx_emif2_hwmod,
> +
>   	NULL,
>   };
>


  reply	other threads:[~2012-03-08 16:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 15:54 [PATCH 0/8] Add TI EMIF SDRAM controller driver Aneesh V
2012-03-08 15:54 ` [PATCH 1/8] OMAP4: hwmod: add EMIF hw mod data Aneesh V
2012-03-08 16:41   ` Cousson, Benoit [this message]
2012-03-08 16:41     ` Cousson, Benoit
2012-03-08 16:43     ` Aneesh V
2012-03-08 15:54 ` [PATCH 2/8] misc: ddr: add LPDDR2 data from JESD209-2 Aneesh V
2012-03-08 15:54 ` [PATCH 3/8] misc: emif: add register definitions for EMIF Aneesh V
2012-03-08 15:54 ` [PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver Aneesh V
2012-03-08 15:54 ` [PATCH 5/8] misc: emif: handle frequency and voltage change events Aneesh V
2012-03-08 15:54 ` [PATCH 6/8] misc: emif: add interrupt and temperature handling Aneesh V
2012-03-08 15:54 ` [PATCH 7/8] misc: emif: add one-time settings Aneesh V
2012-03-08 15:54 ` [PATCH 8/8] misc: emif: add debugfs entries for emif Aneesh V
2012-03-08 20:59 ` [PATCH 0/8] Add TI EMIF SDRAM controller driver Greg KH
2012-03-08 21:47   ` Paul Walmsley
2012-03-09  3:59   ` Aneesh V
2012-03-12 15:58 ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F58E13C.8040906@ti.com \
    --to=b-cousson@ti.com \
    --cc=aneesh@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.