All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@ubuntu.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: Ted Ts'o <tytso@mit.edu>, Eric Sandeen <sandeen@redhat.com>,
	ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: mkfs.ext4 vs. e2fsck discard oddities
Date: Thu, 08 Mar 2012 11:48:23 -0500	[thread overview]
Message-ID: <4F58E2D7.205@ubuntu.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1203011540180.6491@dhcp-27-109.brq.redhat.com>

On 3/1/2012 9:54 AM, Lukas Czerner wrote:
> Well, it is not default right ? So the user should better know what is
> he doing. Moreover it is not like it is end of the world when we do not
> provide that option, since SSD's will handle over provisioning to some
> extent even without slowdown, and as for thin-provisioned devices you
> should know why you're overriding defaults and what it means for you.
>
> Anyway, if people really want this another option to discard all the
> block groups including those UNINIT ones, I guess I can not resist that
> :). '-E discard_all' maybe ?

I think the option is a little more generic than discard.  The uninit 
groups are not discarded because they are not checked in the first 
place.  A bad group descriptor checksum will force the group to be 
checked, and thus discarded as well.  I think what is needed is an 
option to trigger the same thing: force all groups to be checked, even 
if they are uninit and have good descriptor checksums.  Maybe -E thorough?


  reply	other threads:[~2012-03-08 16:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 17:34 mkfs.ext4 vs. e2fsck discard oddities Eric Sandeen
2012-02-29  7:12 ` Lukas Czerner
2012-02-29 16:01   ` Eric Sandeen
2012-03-01  4:47   ` Theodore Tso
2012-03-01  7:12     ` Lukas Czerner
2012-03-01 14:38       ` Ted Ts'o
2012-03-01 14:54         ` Lukas Czerner
2012-03-08 16:48           ` Phillip Susi [this message]
2012-03-09  8:59             ` Lukas Czerner
2012-03-09 15:14               ` Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F58E2D7.205@ubuntu.com \
    --to=psusi@ubuntu.com \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.