Re: mkfs.ext4 vs. e2fsck discard oddities

[Phillip Susi <psusi@ubuntu.com>]

On 3/9/2012 3:59 AM, Lukas Czerner wrote:
> Why would we try to check UNINIT groups with valid descriptor checksums
> ? I think that this problem will be solved with BLOCK_DISCARDED flag as
> we discussed with Ted in another thread. No need to have yet another
> option so it is win-win :)

Because not skipping a specific action on an uninitialized group ( 
discard ) is a specific case of the more general form of not skipping 
uninitialized groups.  I thought that it might sometimes be useful to 
actually verify the group is correct instead of trusting the uninit 
flag, especially if you are about to discard it.  Also any other things 
that are added in the future and skipped for uninit groups would not 
need yet another flag to specifically not skip that action, since it 
will be covered by the more general flag already.

Also the way the code was structured it looked like it would be much 
simpler to bypass the skip and do the full check of the uninit group 
than to modify it to discard the group even though checking it was skipped.