From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v3] USB: Support for LPC32xx SoC
Date: Thu, 08 Mar 2012 23:01:00 +0100 [thread overview]
Message-ID: <4F592C1C.1050909@antcom.de> (raw)
In-Reply-To: <20120308211120.GB21058@kroah.com>
On 08/03/12 22:11, Greg Kroah-Hartman wrote:
>> - pnx4008_unset_usb_bits();
>> + if (machine_is_pnx4008())
>> + pnx4008_unset_usb_bits();
>
> How come some of these pnx4008_* functions you have wrapped in
> machine_is_pnx4008(), but not all of them?
>
> Actually, why don't those functions do that kind of checking themselves,
> without having to do this before you call them each time?
Good idea, I moved the machine dependent execution of the bits()
functions into the functions.
The dependency is only in the bits functions because those are done via
interfaces not available on LPC. The other pnx4008 functions seem to be
mostly compatible.
Thanks for your notes!
Roland
WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
w.sang@pengutronix.de, kevin.wells@nxp.com,
linux-arm-kernel@lists.infradead.org, arnd@arndb.de
Subject: Re: [PATCH RESEND v3] USB: Support for LPC32xx SoC
Date: Thu, 08 Mar 2012 23:01:00 +0100 [thread overview]
Message-ID: <4F592C1C.1050909@antcom.de> (raw)
In-Reply-To: <20120308211120.GB21058@kroah.com>
On 08/03/12 22:11, Greg Kroah-Hartman wrote:
>> - pnx4008_unset_usb_bits();
>> + if (machine_is_pnx4008())
>> + pnx4008_unset_usb_bits();
>
> How come some of these pnx4008_* functions you have wrapped in
> machine_is_pnx4008(), but not all of them?
>
> Actually, why don't those functions do that kind of checking themselves,
> without having to do this before you call them each time?
Good idea, I moved the machine dependent execution of the bits()
functions into the functions.
The dependency is only in the bits functions because those are done via
interfaces not available on LPC. The other pnx4008 functions seem to be
mostly compatible.
Thanks for your notes!
Roland
next prev parent reply other threads:[~2012-03-08 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 21:21 [PATCH RESEND v3] USB: Support for LPC32xx SoC Roland Stigge
2012-03-06 21:21 ` Roland Stigge
2012-03-08 21:11 ` Greg Kroah-Hartman
2012-03-08 21:11 ` Greg Kroah-Hartman
2012-03-08 22:01 ` Roland Stigge [this message]
2012-03-08 22:01 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F592C1C.1050909@antcom.de \
--to=stigge@antcom.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.