All of lore.kernel.org
 help / color / mirror / Atom feed
From: paul.liu@linaro.org (Ying-Chun Liu (PaulLiu))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10] Regulator: Add Anatop regulator driver
Date: Fri, 09 Mar 2012 16:00:25 +0800	[thread overview]
Message-ID: <4F59B899.2080704@linaro.org> (raw)
In-Reply-To: <20120308141847.GG27213@game.jcrosoft.org>

(2012?03?08? 22:18), Jean-Christophe PLAGNIOL-VILLARD wrote:
>> +static int __devexit anatop_regulator_remove(struct platform_device *pdev)
>> +{
>> +	struct regulator_dev *rdev = platform_get_drvdata(pdev);
>> +	struct anatop_regulator *sreg = rdev_get_drvdata(rdev);
>> +	kfree(sreg->name);
>> +	regulator_unregister(rdev);
> return from the unregister
>> +	return 0;
>> +}
> Best Regards,
> J.

Hi Jean-Christophe,

I've modify the patch based on your review. However, the last one cannot
be made because regulator_unregister is void return.

Yours Sincerely,
Paul

WARNING: multiple messages have this Message-ID (diff)
From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
	patches@linaro.org, Nancy Chen <Nancy.Chen@freescale.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
	Axel Lin <axel.lin@gmail.com>
Subject: Re: [PATCH v10] Regulator: Add Anatop regulator driver
Date: Fri, 09 Mar 2012 16:00:25 +0800	[thread overview]
Message-ID: <4F59B899.2080704@linaro.org> (raw)
In-Reply-To: <20120308141847.GG27213@game.jcrosoft.org>

(2012年03月08日 22:18), Jean-Christophe PLAGNIOL-VILLARD wrote:
>> +static int __devexit anatop_regulator_remove(struct platform_device *pdev)
>> +{
>> +	struct regulator_dev *rdev = platform_get_drvdata(pdev);
>> +	struct anatop_regulator *sreg = rdev_get_drvdata(rdev);
>> +	kfree(sreg->name);
>> +	regulator_unregister(rdev);
> return from the unregister
>> +	return 0;
>> +}
> Best Regards,
> J.

Hi Jean-Christophe,

I've modify the patch based on your review. However, the last one cannot
be made because regulator_unregister is void return.

Yours Sincerely,
Paul

  reply	other threads:[~2012-03-09  8:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08  9:59 [PATCH v10] Regulator: Add Anatop regulator driver Ying-Chun Liu (PaulLiu)
2012-03-08  9:59 ` Ying-Chun Liu (PaulLiu)
2012-03-08 14:18 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 14:18   ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09  8:00   ` Ying-Chun Liu (PaulLiu) [this message]
2012-03-09  8:00     ` Ying-Chun Liu (PaulLiu)
2012-03-09  9:58     ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09  9:58       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09 12:31       ` Mark Brown
2012-03-09 12:31         ` Mark Brown
2012-03-09  2:59 ` Axel Lin
2012-03-09  2:59   ` Axel Lin
2012-03-09  3:45 ` Axel Lin
2012-03-09  3:45   ` Axel Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F59B899.2080704@linaro.org \
    --to=paul.liu@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.